From df2c4952df6d93c575fb8a3c853dc9d4c2449f36 Mon Sep 17 00:00:00 2001 From: Simon Charette Date: Fri, 7 Feb 2025 16:34:17 -0500 Subject: Fixed #36173 -- Stabilized identity of Concat with an explicit output_field. When Expression.__init__() overrides make use of *args, **kwargs captures their argument values are respectively bound as a tuple and dict instances. These composite values might themselves contain values that require special identity treatments such as Concat(output_field) as it's a Field instance. Refs #30628 which introduced bound Field differentiation but lacked argument captures handling. Thanks erchenstein for the report. --- django/db/models/expressions.py | 23 ++++++++++++++++------- 1 file changed, 16 insertions(+), 7 deletions(-) (limited to 'django') diff --git a/django/db/models/expressions.py b/django/db/models/expressions.py index 57ceadcec4..444e2fab7b 100644 --- a/django/db/models/expressions.py +++ b/django/db/models/expressions.py @@ -523,6 +523,18 @@ class Expression(BaseExpression, Combinable): def _constructor_signature(cls): return inspect.signature(cls.__init__) + @classmethod + def _identity(cls, value): + if isinstance(value, tuple): + return tuple(map(cls._identity, value)) + if isinstance(value, dict): + return tuple((key, cls._identity(val)) for key, val in value.items()) + if isinstance(value, fields.Field): + if value.name and value.model: + return value.model._meta.label, value.name + return type(value) + return make_hashable(value) + @cached_property def identity(self): args, kwargs = self._constructor_args @@ -532,13 +544,10 @@ class Expression(BaseExpression, Combinable): next(arguments) identity = [self.__class__] for arg, value in arguments: - if isinstance(value, fields.Field): - if value.name and value.model: - value = (value.model._meta.label, value.name) - else: - value = type(value) - else: - value = make_hashable(value) + # If __init__() makes use of *args or **kwargs captures `value` + # will respectively be a tuple or a dict that must have its + # constituents unpacked (mainly if contain Field instances). + value = self._identity(value) identity.append((arg, value)) return tuple(identity) -- cgit v1.3