From 53bc81dca3d785d0b399cacbf84cc660355895fc Mon Sep 17 00:00:00 2001 From: Claude Paroz Date: Mon, 20 Oct 2014 22:32:43 +0200 Subject: [1.7.x] Fixed #21740 -- Allowed test client data to be an empty string This fixes a regression introduced by 2a31d00933. Thanks tony-zhu for the report. Backport of f0bb3c98cc from master. --- django/test/client.py | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) (limited to 'django') diff --git a/django/test/client.py b/django/test/client.py index 22c7b18b07..7a1802b496 100644 --- a/django/test/client.py +++ b/django/test/client.py @@ -278,8 +278,9 @@ class RequestFactory(object): def get(self, path, data=None, secure=False, **extra): "Construct a GET request." + data = {} if data is None else data r = { - 'QUERY_STRING': urlencode(data or {}, doseq=True), + 'QUERY_STRING': urlencode(data, doseq=True), } r.update(extra) return self.generic('GET', path, secure=secure, **r) @@ -288,7 +289,8 @@ class RequestFactory(object): secure=False, **extra): "Construct a POST request." - post_data = self._encode_data(data or {}, content_type) + data = {} if data is None else data + post_data = self._encode_data(data, content_type) return self.generic('POST', path, post_data, content_type, secure=secure, **extra) @@ -296,8 +298,9 @@ class RequestFactory(object): def head(self, path, data=None, secure=False, **extra): "Construct a HEAD request." + data = {} if data is None else data r = { - 'QUERY_STRING': urlencode(data or {}, doseq=True), + 'QUERY_STRING': urlencode(data, doseq=True), } r.update(extra) return self.generic('HEAD', path, secure=secure, **r) -- cgit v1.3