From 09f2cdbe1a43e79e31f5ea509b59d4c87db29832 Mon Sep 17 00:00:00 2001 From: Tim Graham Date: Tue, 16 Jun 2015 11:02:27 -0400 Subject: Refs #16860 -- Fixed a resource and deprecation warning in password validation. --- django/contrib/auth/password_validation.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'django') diff --git a/django/contrib/auth/password_validation.py b/django/contrib/auth/password_validation.py index f01c13d841..efad0d72a6 100644 --- a/django/contrib/auth/password_validation.py +++ b/django/contrib/auth/password_validation.py @@ -161,7 +161,9 @@ class CommonPasswordValidator(object): try: common_passwords_lines = gzip.open(password_list_path).read().decode('utf-8').splitlines() except IOError: - common_passwords_lines = open(password_list_path).readlines() + with open(password_list_path) as f: + common_passwords_lines = f.readlines() + self.passwords = {p.strip() for p in common_passwords_lines} def validate(self, password, user=None): -- cgit v1.3