From 856072dd4a3e479aa09b0ab6b498ff599ca2a809 Mon Sep 17 00:00:00 2001 From: UmanShahzad Date: Sat, 29 Apr 2017 19:10:43 -0400 Subject: Fixed #28142 -- Fixed is_safe_url() crash on invalid IPv6 URLs. --- django/utils/http.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) (limited to 'django/utils') diff --git a/django/utils/http.py b/django/utils/http.py index 1433df4ff0..07b6ae246a 100644 --- a/django/utils/http.py +++ b/django/utils/http.py @@ -349,7 +349,10 @@ def _is_safe_url(url, allowed_hosts, require_https=False): # urlparse is not so flexible. Treat any url with three slashes as unsafe. if url.startswith('///'): return False - url_info = _urlparse(url) + try: + url_info = _urlparse(url) + except ValueError: # e.g. invalid IPv6 addresses + return False # Forbid URLs like http:///example.com - with a scheme, but without a hostname. # In that URL, example.com is not the hostname but, a path component. However, # Chrome will still consider example.com to be the hostname, so we must not -- cgit v1.3