From 26489d4e2aa2a5d06b228643dfc232c05bb47872 Mon Sep 17 00:00:00 2001 From: Adrian Holovaty Date: Fri, 15 Dec 2006 23:07:41 +0000 Subject: newforms: Fixed unexpected behavior with CharField(required=False, min_length=X). Thanks for reporting, Benjamin Slavin git-svn-id: http://code.djangoproject.com/svn/django/trunk@4217 bcc190cf-cafb-0310-a4f2-bffc1f526a37 --- django/newforms/fields.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) (limited to 'django/newforms') diff --git a/django/newforms/fields.py b/django/newforms/fields.py index 24849bdbcf..af2533cec5 100644 --- a/django/newforms/fields.py +++ b/django/newforms/fields.py @@ -77,7 +77,10 @@ class CharField(Field): def clean(self, value): "Validates max_length and min_length. Returns a Unicode object." Field.clean(self, value) - if value in EMPTY_VALUES: value = u'' + if value in EMPTY_VALUES: + value = u'' + if not self.required: + return value value = smart_unicode(value) if self.max_length is not None and len(value) > self.max_length: raise ValidationError(gettext(u'Ensure this value has at most %d characters.') % self.max_length) -- cgit v1.3