From b99cc935ebedf52111507ca92641ffde73a3d9ae Mon Sep 17 00:00:00 2001 From: Jacob Kaplan-Moss Date: Thu, 28 Aug 2008 15:06:18 +0000 Subject: Fixed #7753: clean `NullBooleanField` correctly when using `HiddenInput`. Thanks to julien and ElliottM. git-svn-id: http://code.djangoproject.com/svn/django/trunk@8661 bcc190cf-cafb-0310-a4f2-bffc1f526a37 --- django/forms/fields.py | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) (limited to 'django/forms/fields.py') diff --git a/django/forms/fields.py b/django/forms/fields.py index afbf6146b0..b582659099 100644 --- a/django/forms/fields.py +++ b/django/forms/fields.py @@ -594,7 +594,18 @@ class NullBooleanField(BooleanField): widget = NullBooleanSelect def clean(self, value): - return {True: True, False: False}.get(value, None) + """ + Explicitly checks for the string 'True' and 'False', which is what a + hidden field will submit for True and False. Unlike the + Booleanfield we also need to check for True, because we are not using + the bool() function + """ + if value in (True, 'True'): + return True + elif value in (False, 'False'): + return False + else: + return None class ChoiceField(Field): widget = Select -- cgit v1.3