From d87bd29c4f8dfcdf3f4a4eb8340e6770a2416fe3 Mon Sep 17 00:00:00 2001 From: can Date: Wed, 17 Apr 2019 09:24:28 +0300 Subject: Fixed #30335, #29139 -- Fixed crash when ordering or aggregating over a nested JSONField key transform. --- django/db/models/sql/compiler.py | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) (limited to 'django/db/models/sql') diff --git a/django/db/models/sql/compiler.py b/django/db/models/sql/compiler.py index f4b1faabc2..3d133cb672 100644 --- a/django/db/models/sql/compiler.py +++ b/django/db/models/sql/compiler.py @@ -14,6 +14,7 @@ from django.db.models.sql.query import Query, get_order_dir from django.db.transaction import TransactionManagementError from django.db.utils import DatabaseError, NotSupportedError from django.utils.deprecation import RemovedInDjango31Warning +from django.utils.hashable import make_hashable FORCE = object() @@ -126,9 +127,10 @@ class SQLCompiler: for expr in expressions: sql, params = self.compile(expr) - if (sql, tuple(params)) not in seen: + params_hash = make_hashable(params) + if (sql, params_hash) not in seen: result.append((sql, params)) - seen.add((sql, tuple(params))) + seen.add((sql, params_hash)) return result def collapse_group_by(self, expressions, having): @@ -352,9 +354,10 @@ class SQLCompiler: # is refactored into expressions, then we can check each part as we # generate it. without_ordering = self.ordering_parts.search(sql).group(1) - if (without_ordering, tuple(params)) in seen: + params_hash = make_hashable(params) + if (without_ordering, params_hash) in seen: continue - seen.add((without_ordering, tuple(params))) + seen.add((without_ordering, params_hash)) result.append((resolved, (sql, params, is_ref))) return result -- cgit v1.3