From 7a67b065d7e5653f3af1cbd28882d33d2a088b02 Mon Sep 17 00:00:00 2001 From: Simon Charette Date: Mon, 17 Jul 2023 12:51:54 -0400 Subject: [4.2.x] Fixed #34717 -- Fixed QuerySet.aggregate() crash when referencing window functions. Regression in 59bea9efd2768102fc9d3aedda469502c218e9b7. Refs #28477. Thanks younes-chaoui for the report. Backport of 68912e4f6f84f21322f92a2c7b6c77f68f91b9c9 from main --- django/db/models/sql/query.py | 6 ++++++ 1 file changed, 6 insertions(+) (limited to 'django/db/models/sql') diff --git a/django/db/models/sql/query.py b/django/db/models/sql/query.py index 97c0bb4a08..c9656cc450 100644 --- a/django/db/models/sql/query.py +++ b/django/db/models/sql/query.py @@ -390,6 +390,7 @@ class Query(BaseExpression): # Store annotation mask prior to temporarily adding aggregations for # resolving purpose to facilitate their subsequent removal. refs_subquery = False + refs_window = False replacements = {} annotation_select_mask = self.annotation_select_mask for alias, aggregate_expr in aggregate_exprs.items(): @@ -406,6 +407,10 @@ class Query(BaseExpression): getattr(self.annotations[ref], "subquery", False) for ref in aggregate.get_refs() ) + refs_window |= any( + getattr(self.annotations[ref], "contains_over_clause", True) + for ref in aggregate.get_refs() + ) aggregate = aggregate.replace_expressions(replacements) self.annotations[alias] = aggregate replacements[Ref(alias, aggregate)] = aggregate @@ -438,6 +443,7 @@ class Query(BaseExpression): or self.is_sliced or has_existing_aggregation or refs_subquery + or refs_window or qualify or self.distinct or self.combinator -- cgit v1.3