From 33bfc66add643f49d466c5a646989ad91677753d Mon Sep 17 00:00:00 2001 From: Tim Graham Date: Sat, 4 Apr 2026 18:02:17 -0400 Subject: Fixed #37023 -- Made XML serializer put each ManyToManyField object on its own line. --- django/core/serializers/xml_serializer.py | 8 +++++++- tests/serializers/test_xml.py | 5 ++++- 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/django/core/serializers/xml_serializer.py b/django/core/serializers/xml_serializer.py index 82a345d57f..5dfbb76a01 100644 --- a/django/core/serializers/xml_serializer.py +++ b/django/core/serializers/xml_serializer.py @@ -199,6 +199,8 @@ class Serializer(base.Serializer): else: def handle_m2m(value): + # Put each object on its own line. + self.indent(self.indent_level + 1) self.xml.addQuickElement("object", attrs={"pk": str(value.pk)}) def queryset_iterator(obj, field): @@ -217,9 +219,13 @@ class Serializer(base.Serializer): field.name, queryset_iterator(obj, field), ) + relobj = None for relobj in m2m_iter: handle_m2m(relobj) - + if relobj: + # If there are related objects (which appear each on their own + # line), put the closing on the next line. + self.indent(self.indent_level) self.xml.endElement("field") self.indent_level -= 1 diff --git a/tests/serializers/test_xml.py b/tests/serializers/test_xml.py index 0ae66f77d0..884746dfac 100644 --- a/tests/serializers/test_xml.py +++ b/tests/serializers/test_xml.py @@ -24,7 +24,10 @@ class XmlSerializerTestCase(SerializersTestBase, TestCase): %(author_pk)s Poker has no place on ESPN 2006-06-16T11:00:00 - + + + + -- cgit v1.3