| Age | Commit message (Collapse) | Author |
|
Backport of 944a2bb7c1 from master
|
|
InlineFormSet.
Thanks treysta at gmail.com for the suggestion.
Backport of 9bfe66164e from master
|
|
Thanks ebertti at yahoo.com.br for the suggestion.
Backport of 018e2c055a from master
|
|
fields.
The ModelForm docs suggested that fields defined declaratively override
default fields generated from the form Meta.
This is conceptually wrong, especially with inheritance in mind. Meta is
usually defined on the topmost ModelForm subclass, while fields can come
from anywhere in the MRO, especially base classes; therefore we suggested
that something defined in a base class override something from a subclass.
This patch rephrases the docs around the idea that Meta is used to generate
*missing* fields.
Refs #8620, #19617.
Thanks @mjtamlyn and @timgraham for the review.
Backport of 54cd930baf from master
|
|
Backport of 2fbf949760 from master
|
|
Backport of aa41eb9b8b from master
|
|
Backport of fba6c2ede7 from master
|
|
Backport of c0f03175ce from master
|
|
Thanks gregcorey@ for the suggestion.
Backport of 660c30ed95 from master
|
|
Thanks johnsmith for the suggestion.
Backport of 181f63c22d from master
|
|
Thanks Marc Tamlyn and Tim Graham for the review.
Backport of 7442eb1a24 from master.
|
|
Backport of 3632d289de from master.
|
|
Thanks to frog32 for the report and to Tim Graham for the review.
|
|
error_messages
|
|
|
|
|
|
There was an inconsistency between how the label_tag for forms were
generated depending on which method was used: as_p, as_ul and as_table
contained code to append the label_suffix where as label_tag called on a
form field directly did NOT append the label_suffix. The code for
appending the label_suffix has been moved in to the label_tag code of
the field and the HTML generation code for as_p, as_ul and as_table now
calls this code as well.
This is a backwards incompatible change because users who have added the
label_suffix manually in their templates may now get double label_suffix
characters in their forms.
|
|
Fixed typo: froms -> forms
|
|
Thanks sane4ka.sh@ for the report.
|
|
|
|
|
|
|
|
|
|
added '__all__' shortcut
This also updates all dependent functionality, including modelform_factory
and modelformset_factory, and the generic views `ModelFormMixin`,
`CreateView` and `UpdateView` which gain a new `fields` attribute.
|
|
Fixed #20327.
|
|
Refs #20104.
|
|
Thanks to feraudyh at yahoo.com for the report.
|
|
|
|
This is provided as a new "validate_max" formset_factory option defaulting to
False, since the non-validating behavior of max_num is longstanding, and there
is certainly code relying on it. (In fact, even the Django admin relies on it
for the case where there are more existing inlines than the given max_num). It
may be that at some point we want to deprecate validate_max=False and
eventually remove the option, but this commit takes no steps in that direction.
This also fixes the DoS-prevention absolute_max enforcement so that it causes a
form validation error rather than an IndexError, and ensures that absolute_max
is always 1000 more than max_num, to prevent surprising changes in behavior
with max_num close to absolute_max.
Lastly, this commit fixes the previous inconsistency between a regular formset
and a model formset in the precedence of max_num and initial data. Previously
in a regular formset, if the provided initial data was longer than max_num, it
was truncated; in a model formset, all initial forms would be displayed
regardless of max_num. Now regular formsets are the same as model formsets; all
initial forms are displayed, even if more than max_num. (But if validate_max is
True, submitting these forms will result in a "too many forms" validation
error!) This combination of behaviors was chosen to keep the max_num validation
simple and consistent, and avoid silent data loss due to truncation of initial
data.
Thanks to Preston for discussion of the design choices.
|
|
Thanks Simon Charette for his help on the patch. Refs #16630.
|
|
This is a security fix. Disclosure and advisory coming shortly.
|
|
|
|
|
|
Thanks Tiberiu Ana for the report and patch.
|
|
Refs #16630.
|
|
modelformset_factory
|
|
Thanks will@ for the suggestion.
|
|
Thanks wim@ for the suggestion.
|
|
Thanks ingenieroariel for the suggestion and slurms for the review.
|
|
Added -n to sphinx builds to catch issues going forward.
|
|
|
|
|
|
Also fixes #9045.
|
|
|
|
validation fails.
|
|
|
|
draft patch.
|
|
|
|
Jamie Curle.
|
|
the form is invalid.
Thanks Ben Sturmfels for the patch.
|