| Age | Commit message (Collapse) | Author |
|
This is provided as a new "validate_max" formset_factory option defaulting to
False, since the non-validating behavior of max_num is longstanding, and there
is certainly code relying on it. (In fact, even the Django admin relies on it
for the case where there are more existing inlines than the given max_num). It
may be that at some point we want to deprecate validate_max=False and
eventually remove the option, but this commit takes no steps in that direction.
This also fixes the DoS-prevention absolute_max enforcement so that it causes a
form validation error rather than an IndexError, and ensures that absolute_max
is always 1000 more than max_num, to prevent surprising changes in behavior
with max_num close to absolute_max.
Lastly, this commit fixes the previous inconsistency between a regular formset
and a model formset in the precedence of max_num and initial data. Previously
in a regular formset, if the provided initial data was longer than max_num, it
was truncated; in a model formset, all initial forms would be displayed
regardless of max_num. Now regular formsets are the same as model formsets; all
initial forms are displayed, even if more than max_num. (But if validate_max is
True, submitting these forms will result in a "too many forms" validation
error!) This combination of behaviors was chosen to keep the max_num validation
simple and consistent, and avoid silent data loss due to truncation of initial
data.
Thanks to Preston for discussion of the design choices.
|
|
When the 'invalid' error message is set at field level, it masks
the error message raised by the validator, if any.
|
|
Thanks leandron85@ for the suggestion.
|
|
Thanks Simon Charette for his help on the patch. Refs #16630.
|
|
Thanks diegueus9 for the report and itsallvoodoo for the draft patch.
|
|
Refs #16630.
|
|
Refs #16630.
|
|
modelformset_factory
|
|
Thanks will@ for the suggestion.
|
|
Thanks wim@ for the suggestion.
|
|
Thanks ingenieroariel for the suggestion and slurms for the review.
|
|
Added -n to sphinx builds to catch issues going forward.
|
|
|
|
|
|
|
|
the value_from_datadict method.
|
|
|
|
Thanks henrik@aisti.fi for the suggestion in #19119.
|
|
Thanks henrik@aisti.fi for the report.
|
|
value
|
|
|
|
|
|
draft patch.
|
|
Refs #16630.
|
|
draft patch.
|
|
clarify clean_<field> docs, ticket #18917
|
|
brutasse for the patch.
|
|
|
|
cleaned_data is no longer deleted when form validation fails but only
contains the data that did validate.
Thanks to the various contributors to this patch (see ticket).
|
|
Thanks fabian and charettes.
|
|
|
|
Thanks Audrey Roy for the patch.
|
|
Thanks Vinay Sajip for the support of his django3 branch and
Jannis Leidel for the review.
|
|
Thanks Florian Apolloner for the patch.
|
|
|
|
Thanks poirier for the report.
|
|
|
|
addition to regular files. Thank you to Brian Rosner, for encouraging me to first contribute to Django 4 years ago.
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17925 bcc190cf-cafb-0310-a4f2-bffc1f526a37
|
|
The deprecation schedule was slightly accelerated because of possible security ramifications.
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17847 bcc190cf-cafb-0310-a4f2-bffc1f526a37
|
|
super() instead of relying on self.cleaned_data. Thanks, DrMeers.
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17433 bcc190cf-cafb-0310-a4f2-bffc1f526a37
|
|
rendered strings. This means we can access individual radio buttons' properties in the template (see new docs)
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17175 bcc190cf-cafb-0310-a4f2-bffc1f526a37
|
|
buttons of a RadioSelect in a template
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17173 bcc190cf-cafb-0310-a4f2-bffc1f526a37
|
|
[16955]
git-svn-id: http://code.djangoproject.com/svn/django/trunk@16983 bcc190cf-cafb-0310-a4f2-bffc1f526a37
|
|
git-svn-id: http://code.djangoproject.com/svn/django/trunk@16821 bcc190cf-cafb-0310-a4f2-bffc1f526a37
|
|
empty_value. Thanks to vanschelven and taavi223.
git-svn-id: http://code.djangoproject.com/svn/django/trunk@16820 bcc190cf-cafb-0310-a4f2-bffc1f526a37
|
|
URLField.verify_exists.
git-svn-id: http://code.djangoproject.com/svn/django/trunk@16776 bcc190cf-cafb-0310-a4f2-bffc1f526a37
|
|
avoid potential leakage of local filesystem data. A security announcement will be made shortly.
git-svn-id: http://code.djangoproject.com/svn/django/trunk@16760 bcc190cf-cafb-0310-a4f2-bffc1f526a37
|
|
This allows to make these links more resilent to changes in the target URLs.
Thanks Jannis for the report and Aymeric Augustin for the patch.
Fixes #16586.
git-svn-id: http://code.djangoproject.com/svn/django/trunk@16720 bcc190cf-cafb-0310-a4f2-bffc1f526a37
|
|
git-svn-id: http://code.djangoproject.com/svn/django/trunk@16633 bcc190cf-cafb-0310-a4f2-bffc1f526a37
|
|
example. Thanks to santi.romero, el barto, and julien.
git-svn-id: http://code.djangoproject.com/svn/django/trunk@16626 bcc190cf-cafb-0310-a4f2-bffc1f526a37
|