| Age | Commit message (Collapse) | Author |
|---|
|
Refactored get_apps() to rely on that method.
This commit is fully backwards-compatible.
|
|
Refactored get_app() to rely on that method.
get_app() starts by calling _populate(), which goes through
INSTALLED_APPS and, for each app, imports the app module and attempts to
import the models module. At this point, no further imports are
necessary to return the models module for a given app. Therefore, the
implementation of get_app() can be simplified and the safeguards for
race conditions can be removed.
Besides, the emptyOK parameter isn't used anywhere in Django. It was
introduced in d6c95e93 but not actually used nor documented, and it has
just been carried around since then. Since it's an obscure private API,
it's acceptable to stop supporting it without a deprecation path. This
branch aims at providing first-class support for applications without a
models module eventually.
For backwards-compatibility, get_app() still raises ImproperlyConfigured
when an app isn't found, even though LookupError is technically more
correct. I haven't gone as far as to preserve the exact error messages.
I've adjusted a few tests instead.
|
|
Marginally improved creation of AppConfig stubs for non-installed apps.
|
|
This commit is a refactoring with no change of functionality, according
to the following invariants:
- An app_label that was in app_configs and app_models stays in
app_config and has its 'installed' attribute set to True.
- An app_label that was in app_models but not in app_configs is added to
app_configs and has its 'installed' attribute set to True.
As a consequence, all the code that iterated on app_configs is modified
to check for the 'installed' attribute. Code that iterated on app_models
is rewritten in terms of app_configs.
Many tests that stored and restored the state of the app cache were
updated.
In the long term, we should reconsider the usefulness of allowing
importing models from non-installed applications. This doesn't sound
particularly useful, can be a trap in some circumstances, and causes
significant complexity in sensitive areas of Django.
|
|
get_app_errors() always returned an empty dictionary; this behavior is
preserved in django.db.models.loading until that module is deprecated.
|
|
This is a step towards allowing applications without a models module.
|
|
Since the original ones in django.db.models.loading were kept only for
backwards compatibility, there's no need to recreate them. However, many
internals of Django still relied on them.
They were also imported in django.db.models. They never appear in the
documentation, except a quick mention of get_models and get_app in the
1.2 release notes to document an edge case in GIS. I don't think that
makes them a public API.
This commit doesn't change the overall amount of global state but
clarifies that it's tied to the app_cache object instead of hiding it
behind half a dozen functions.
|
|
Its only difference with OrderedDict is that it didn't deepcopy its
keys. However it wasn't used anywhere with models modules as keys, only
as values. So this commit doesn't result in any change in functionality.
|
|
It was only storing redundant information. This is part of the effort to
allow applications without a models module.
|
|
This commit doesn't contain any code changes; it's purely a refactoring.
|
|
|
|
|
|
Thanks to trac user adepue for the report and original patch.
|
|
|
|
Refs #21574
|
|
exception.
Thanks to Keryn Knight for the report.
|
|
|
|
This reverts commit 07fe0bf3f4a49a734f83f5ea30130449dacf9660.
This was not working properly on system without geos library
installed.
|
|
Currently, if the authentication mechanism uses a custom HTTP header
and not REMOTE_USER, it is not easy to test. This commit modifies
remote user tests in order to make them more generic.
|
|
|
|
|
|
|
|
All input is now coerced to text before being normalized.
This changes nothing under Python 2 but it allows bytes
to be passed to the function without a TypeError under Python3
(bytes are assumed to be utf-8 encoded text).
Thanks to trac user vajrasky for the report.
|
|
|
|
Current language is no longer saved to session by LocaleMiddleware
on every response (the behavior introduced in #14825).
Instead language stored in session is reintroduced into new session
after logout.
Forward port of c558a43fd6 to master.
|
|
|
|
|
|
Thanks to Aymeric Augustin for the review and Trac alias monkut for the report.
|
|
Thanks moritz.pfeiffer at alp-phone.ch for the report and
Tim Graham for the initial patch.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Trigger AttributeError in ValidationError.message_dict when error_dict is missing.
|
|
|
|
I've chosen a quick deprecation path, as Geo Sitemaps themselves
are deprecated from some time now.
|
|
|
|
missing.
The goal of this change is twofold; firstly, matching the behavior of Django 1.6
and secondly, an AttributeError is more informative than an obscure ValueError
about mismatching sequence lengths.
Refs #20867.
|
|
With Python 2.7 and up, named parameter keys are not limited to
bytestrings any longer. This mainly reverts 3bd384aa626.
|
|
Thanks trac username zanuxzan for the report and original patch.
|
|
This was a regression in Django 1.6 that was only partially
restored in 839940f27f.
Thanks Jonas Haag for the report.
|
|
Thanks dibrovsd at gmail.com for the report and Simon Charette
for the review.
|
|
Thanks to @dmyerscoug for the report and original patch
and to @alasdairnicol for the added tests.
|
|
re-exposing the name
|
|
|
|
|
|
This is for general consistency in the GeoDjango DB backends.
Thanks Claude for the fix.
Refs #19678.
|
|
|
