| Age | Commit message (Collapse) | Author |
|
In any case, setting those variables to non-ascii utf-8 bytestrings
is now considered a programming error.
|
|
The commit of 266de5f9ae9e9f2fbfaec3b7e4b5fb9941967801 included only
tests, this time also code changes included...
|
|
This is provided as a new "validate_max" formset_factory option defaulting to
False, since the non-validating behavior of max_num is longstanding, and there
is certainly code relying on it. (In fact, even the Django admin relies on it
for the case where there are more existing inlines than the given max_num). It
may be that at some point we want to deprecate validate_max=False and
eventually remove the option, but this commit takes no steps in that direction.
This also fixes the DoS-prevention absolute_max enforcement so that it causes a
form validation error rather than an IndexError, and ensures that absolute_max
is always 1000 more than max_num, to prevent surprising changes in behavior
with max_num close to absolute_max.
Lastly, this commit fixes the previous inconsistency between a regular formset
and a model formset in the precedence of max_num and initial data. Previously
in a regular formset, if the provided initial data was longer than max_num, it
was truncated; in a model formset, all initial forms would be displayed
regardless of max_num. Now regular formsets are the same as model formsets; all
initial forms are displayed, even if more than max_num. (But if validate_max is
True, submitting these forms will result in a "too many forms" validation
error!) This combination of behaviors was chosen to keep the max_num validation
simple and consistent, and avoid silent data loss due to truncation of initial
data.
Thanks to Preston for discussion of the design choices.
|
|
|
|
Thanks jrothenbuhler for draft patch, Konark Modi for updates.
|
|
When the 'invalid' error message is set at field level, it masks
the error message raised by the validator, if any.
|
|
Thanks Florian Apolloner for the report and the review.
Also fixes #19643.
|
|
Thanks Loic Bistuer for spotting the regression and the initial
patch. Refs #16612.
|
|
return a QuerySet.
|
|
Thanks Loic Bistuer for the report and the patch.
|
|
Thanks rubyruy for the report and the patch.
|
|
|
|
Thanks Simon Charette for the review.
|
|
Thanks loic84 for the report.
|
|
Thanks facundo.olano at gmail.com for the report and thikonom for
the initial patch.
|
|
|
|
Thanks theaspect at gmail.com for the report and volrath for the
patch.
|
|
IPAddressField/GenericIPAddressField
|
|
Fixes #17663
|
|
Thanks Simon Charette for his help on the patch. Refs #16630.
|
|
This is a security fix. Disclosure and advisory coming shortly.
|
|
Thanks c.pollock at bangor.ac.uk for the report.
|
|
|
|
Fixed #19703 -- Typo in get_declared_fields docstring
|
|
validation messages
This was made possible by commit 3f1a0c0040b9. Thanks Evil Clay
for the report and Alexey Boriskin his work on the ticket.
|
|
|
|
Refs #16630.
|
|
Refs #16630.
|
|
strptime generates an UnicodeEncodeError when using a non-ascii
unicode string on Python 2.
|
|
Thanks Evil Clay for the report and Emil Stenstrom for the initial
patch.
|
|
|
|
|
|
Refs #16612. Thanks Aymeric Augustin for the suggestion.
|
|
modelformset_factory
|
|
Refs #19399. Thanks to Track alias KJ for the patch.
|
|
These features are implemented, tracked in tickets, or not necessary.
Thanks Bruno Renié.
|
|
Thanks ingenieroariel for the suggestion and slurms for the review.
|
|
ID check is now done the same way as MultipleHiddenInput.
|
|
|
|
|
|
Thanks dibrovsd@gmail.com for the report.
|
|
Thanks qcwxezdas for the report. Refs #13839.
|
|
|
|
Thanks to Patryk Zawadzki for the patch.
|
|
Thanks Simon Charette for the report and the initial patch.
|
|
Browsers consider the first newline in textareas as some display
artifact, not real content. Hence they are not sending it back to
the server. If we want to keep initial newlines, we have to add one
when we render the textarea.
Thanks bastih for the report and initial patch.
|
|
When calling model_to_dict, improve performance of the generated SQL by
using values_list to determine primary keys of many to many objects. Add
a specific test for this function, test_model_to_dict_many_to_many
Thanks to brian for the original report and suggested fix.
|
|
for Python 2 object model compatibility methods.
|
|
Thanks Dan Fairs for the report and the initial patch.
|
|
supplied error_class
Patch with tests from charettes, updated.
|