summaryrefslogtreecommitdiff
path: root/django/forms/models.py
AgeCommit message (Collapse)Author
2013-01-24[1.5.x] Avoided a possible regression in 5097d3c5.Aymeric Augustin
QuerySet.none() returns an instance of EmptyQuerySet, which may have undesirable side effects in the presence of custom query set classes. The implementation of .none() was refactored in master to have the same effect as .filter(pk__in=[]). Refs #19652. Thanks Simon Charrette for the report.
2013-01-11[1.5.x] Fixed #10239 - Added docs for modelform_factoryTim Graham
Thanks ingenieroariel for the suggestion and slurms for the review. Backport of 71d76ec011 from master
2012-12-28[1.5.x] Fix #19524 -- Incorrect caching of parents of unsaved model instances.Aymeric Augustin
Thanks qcwxezdas for the report. Refs #13839. Backport of e9c24be.
2012-12-19[1.5.x] Fixed #18172 -- Made models with __iter__ usable in ↵Patryk Zawadzki
ModelMultipleChoiceField Thanks to Patryk Zawadzki for the patch. Backpatch of 3989ce52ef78840eefe01541628daa220191c0ad
2012-11-04[1.5.x] Merge pull request #495 from aisipos/ticket_18949Alex Gaynor
Fixed #18949 -- Improve performance of model_to_dict with many-to-many Backport of 4d766b3c9aca36cbe7dc71df0cc93fb6f9deea60.
2012-10-03Fixed #14567 -- Made ModelMultipleChoiceField return EmptyQuerySet as empty ↵Stephen Burrows
value
2012-08-30Fixed #18751 -- Cleaned up BaseFormSet._should_delete_formClaude Paroz
We can do that now that cleaned_data is guaranteed to be present. Related to [121fd109]. Thanks Simon Charette for his work on the ticket.
2012-08-23[py3] Removed duplicate imports.Aymeric Augustin
Fixed #18837. Refs #18791.
2012-08-14[py3] Removed a remaining use of __metaclass__.Aymeric Augustin
2012-08-08[py3] Fixed 'iterable but non string' detectionClaude Paroz
In Python 3, the str type has an __iter__ attribute. Therefore, the presence of an __iter__ attribute is not sufficient to distinguish 'standard' iterables (list, tuple) from strings.
2012-08-07[py3] Ported django.utils.encoding.Aymeric Augustin
* Renamed smart_unicode to smart_text (but kept the old name under Python 2 for backwards compatibility). * Renamed smart_str to smart_bytes. * Re-introduced smart_str as an alias for smart_text under Python 3 and smart_bytes under Python 2 (which is backwards compatible). Thus smart_str always returns a str objects. * Used the new smart_str in a few places where both Python 2 and 3 want a str.
2012-08-07[py3] Fixed access to dict keys/values/items.Aymeric Augustin
2012-08-04Fixed #5524 -- Do not remove cleaned_data when a form fails validationClaude Paroz
cleaned_data is no longer deleted when form validation fails but only contains the data that did validate. Thanks to the various contributors to this patch (see ticket).
2012-08-03Replaced some byte strings by str() callsClaude Paroz
This is a useful trick when Python 2 awaits byte strings and Python 3 Unicode (regular) strings.
2012-07-25it's -> itsPiet Delport
2012-07-22[py3] Replaced unicode/str by six.text_type/bytes.Aymeric Augustin
2012-07-22[py3] Used six.with_metaclass wherever necessary.Aymeric Augustin
2012-06-07Fixed #18269 -- Applied unicode_literals for Python 3 compatibility.Claude Paroz
Thanks Vinay Sajip for the support of his django3 branch and Jannis Leidel for the review.
2012-05-19Marked bytestrings with b prefix. Refs #18269Claude Paroz
This is a preparation for unicode literals general usage in Django (Python 3 compatibility).
2012-04-29Fixed #18013 -- Use the new 'as' syntax for exceptions.Claude Paroz
Thanks Clueless for the initial patch. Note that unittest has been purposely left out (external package only used by Python 2.6).
2012-02-04Fixed #17594 -- Stopped ModelFormset.save from running a SELECT query by ↵Jannis Leidel
relying on the fact that the initial form is already set. Thanks, tswicegood. git-svn-id: http://code.djangoproject.com/svn/django/trunk@17434 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2012-01-15Added support for specifying initial values to model formsets and inline ↵Ramiro Morales
formsets. This make them consistent with the similar capability of regular formsets. Thanks to simon29 form the report and to Claude Paroz for the patch. Fixes #14574. git-svn-id: http://code.djangoproject.com/svn/django/trunk@17373 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-10-17Remove several more relative imports.Alex Gaynor
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17007 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-08-23Fixed #15315 -- Added support for the 'widget' argument to ↵Russell Keith-Magee
modelform_factory. Thanks to SardarNL and Will Hardy for the patch. git-svn-id: http://code.djangoproject.com/svn/django/trunk@16659 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-08-12Fixed #16584 -- Fixed a bunch of typos in code comments. Thanks, Bernhard Essl.Jannis Leidel
git-svn-id: http://code.djangoproject.com/svn/django/trunk@16598 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-07-13Fixed #16225 -- Removed unused imports. Many thanks to Aymeric Augustin for ↵Jannis Leidel
the work on the patch and Alex for reviewing. git-svn-id: http://code.djangoproject.com/svn/django/trunk@16539 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-06-07Fixed #14082 -- Use metaclass of provided ModelForm subclass in ↵Carl Meyer
modelform_factory. Thanks jspiros and Stephen Burrows for the patch. git-svn-id: http://code.djangoproject.com/svn/django/trunk@16334 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-05-01Replaced old-style with new-style decorator syntax.Jannis Leidel
git-svn-id: http://code.djangoproject.com/svn/django/trunk@16138 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-04-22Fixed #6953 -- Correctly sort ManyToMany fields in ModelForms. Thanks, ↵Jannis Leidel
dgouldin, mk and Alex. git-svn-id: http://code.djangoproject.com/svn/django/trunk@16063 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-03-14Importing django.forms no longer requires DJANGO_SETTINGS_MODULE. Moved ↵Adrian Holovaty
django.db.connections import in django.forms.models to the method where it's used. git-svn-id: http://code.djangoproject.com/svn/django/trunk@15797 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-02-21Fixed #14099 - BaseModelFormSet should use _should_delete_formLuke Plant
Thanks to kenth for the report and patch. git-svn-id: http://code.djangoproject.com/svn/django/trunk@15612 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-02-19Fixed #9161 -- Ensure that ModelMultipleChoiceField respects to_field_name ↵Russell Keith-Magee
in validation. Thanks to Honza for the report, and Gregor Müllegger for the patch. git-svn-id: http://code.djangoproject.com/svn/django/trunk@15587 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-02-05Fixed #15167 -- Ensure that non-form errors are always part of an ErrorList. ↵Russell Keith-Magee
Thanks to Harm Geerts for the report and patch. git-svn-id: http://code.djangoproject.com/svn/django/trunk@15424 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-01-25Fixed #14938 - Fixed save-as-new on inline formset with new forms.Carl Meyer
git-svn-id: http://code.djangoproject.com/svn/django/trunk@15306 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-01-25Removed dead code in modelforms.Carl Meyer
git-svn-id: http://code.djangoproject.com/svn/django/trunk@15305 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-01-25Fixed #11319 - Added lookup support for ForeignKey.to_field. Also reverted ↵Carl Meyer
no-longer-needed model formsets workaround for lack of such support from r10756. Thanks Russell and Alex for review. git-svn-id: http://code.djangoproject.com/svn/django/trunk@15303 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-12-12Fixed #14144 -- Made sure custom validators are called in ↵Jannis Leidel
ModelMultipleChoiceFields. Thanks, matiasb. git-svn-id: http://code.djangoproject.com/svn/django/trunk@14886 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-11-18Fixed pk uniqueness validation for new objects created outside of a ↵Carl Meyer
ModelForm. Also removed need for ModelForm to poke at Model._state.adding, keeping it an internal ORM concern. git-svn-id: http://code.djangoproject.com/svn/django/trunk@14613 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-11-18Fixed #14234 -- Re-validating a model instance added via ModelForm no longer ↵Carl Meyer
throws spurious PK uniqueness errors. Thanks to David Reynolds and Jeremy Dunck. Also moved Model._adding to Model._state.adding to reduce instance namespace footprint. git-svn-id: http://code.djangoproject.com/svn/django/trunk@14612 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-10-13Fixed #14119 -- fields_for_model no longer returns all fields when fields ↵Honza Král
parameter is the empty tuple. Thanks alexdutton! git-svn-id: http://code.djangoproject.com/svn/django/trunk@14199 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-10-13Fixed #13811 -- Changed unique validation in model formsets to ignore None ↵Honza Král
values, not just omit them git-svn-id: http://code.djangoproject.com/svn/django/trunk@14193 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-09-11Fixed #13149 -- The admin `ForeignKeyRawIdWidget` now properly handles ↵Justin Bronn
non-integer values. Thanks, Chris Adams. git-svn-id: http://code.djangoproject.com/svn/django/trunk@13751 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-09-11Fixed #11905: Raise an error on model form creation if a non-existent field ↵Karen Tracey
was listed in fields. Thanks ben and copelco. git-svn-id: http://code.djangoproject.com/svn/django/trunk@13739 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-09-10Fixed #13095 -- `formfield_callback` keyword argument is now more sane and ↵Justin Bronn
works with widgets defined in `ModelForm.Meta.widgets`. Thanks, hvdklauw for bug report, vung for initial patch, and carljm for review. git-svn-id: http://code.djangoproject.com/svn/django/trunk@13730 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-08-14Fixed #13679, #13231, #7287 -- Ensured that models that have ↵Russell Keith-Magee
ForeignKeys/ManyToManyField can use a a callable default that returns a model instance/queryset. #13679 was a regression in behavior; the other two tickets are pleasant side effects. Thanks to 3point2 for the report. git-svn-id: http://code.djangoproject.com/svn/django/trunk@13577 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-05-04Fixed #12164 -- Removed the Python 2.3 compatibility imports and ↵Russell Keith-Magee
workarounds. Thanks to timo and claudep for the patch. git-svn-id: http://code.djangoproject.com/svn/django/trunk@13094 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-04-27Fixed #12749 -- Corrected a problem with validation of inline primary keys. ↵Russell Keith-Magee
Thanks to Chris.Wesseling@cwi.nl for the report, and nessita for the test case. git-svn-id: http://code.djangoproject.com/svn/django/trunk@13034 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-04-27Fixed #13407 -- Corrected verbose names for autogenerated m2m models, and ↵Russell Keith-Magee
cleaned up the default form prefix when an autogenerated m2m through model is used in a formset. Thanks to carljm for the report. git-svn-id: http://code.djangoproject.com/svn/django/trunk@13029 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-03-31Restored pre-r10062 behavior allowing None from formfield_callback to ↵Brian Rosner
exclude itself from the form git-svn-id: http://code.djangoproject.com/svn/django/trunk@12891 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-03-27Fixed #13023 - Removed ambiguity with regard to the max_num option of ↵Jannis Leidel
formsets and as a result of admin inlines. Thanks to Gabriel Hurley for the patch. git-svn-id: http://code.djangoproject.com/svn/django/trunk@12872 bcc190cf-cafb-0310-a4f2-bffc1f526a37