summaryrefslogtreecommitdiff
path: root/django/forms/models.py
AgeCommit message (Collapse)Author
2011-03-14Importing django.forms no longer requires DJANGO_SETTINGS_MODULE. Moved ↵Adrian Holovaty
django.db.connections import in django.forms.models to the method where it's used. git-svn-id: http://code.djangoproject.com/svn/django/trunk@15797 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-02-21Fixed #14099 - BaseModelFormSet should use _should_delete_formLuke Plant
Thanks to kenth for the report and patch. git-svn-id: http://code.djangoproject.com/svn/django/trunk@15612 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-02-19Fixed #9161 -- Ensure that ModelMultipleChoiceField respects to_field_name ↵Russell Keith-Magee
in validation. Thanks to Honza for the report, and Gregor Müllegger for the patch. git-svn-id: http://code.djangoproject.com/svn/django/trunk@15587 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-02-05Fixed #15167 -- Ensure that non-form errors are always part of an ErrorList. ↵Russell Keith-Magee
Thanks to Harm Geerts for the report and patch. git-svn-id: http://code.djangoproject.com/svn/django/trunk@15424 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-01-25Fixed #14938 - Fixed save-as-new on inline formset with new forms.Carl Meyer
git-svn-id: http://code.djangoproject.com/svn/django/trunk@15306 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-01-25Removed dead code in modelforms.Carl Meyer
git-svn-id: http://code.djangoproject.com/svn/django/trunk@15305 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-01-25Fixed #11319 - Added lookup support for ForeignKey.to_field. Also reverted ↵Carl Meyer
no-longer-needed model formsets workaround for lack of such support from r10756. Thanks Russell and Alex for review. git-svn-id: http://code.djangoproject.com/svn/django/trunk@15303 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-12-12Fixed #14144 -- Made sure custom validators are called in ↵Jannis Leidel
ModelMultipleChoiceFields. Thanks, matiasb. git-svn-id: http://code.djangoproject.com/svn/django/trunk@14886 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-11-18Fixed pk uniqueness validation for new objects created outside of a ↵Carl Meyer
ModelForm. Also removed need for ModelForm to poke at Model._state.adding, keeping it an internal ORM concern. git-svn-id: http://code.djangoproject.com/svn/django/trunk@14613 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-11-18Fixed #14234 -- Re-validating a model instance added via ModelForm no longer ↵Carl Meyer
throws spurious PK uniqueness errors. Thanks to David Reynolds and Jeremy Dunck. Also moved Model._adding to Model._state.adding to reduce instance namespace footprint. git-svn-id: http://code.djangoproject.com/svn/django/trunk@14612 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-10-13Fixed #14119 -- fields_for_model no longer returns all fields when fields ↵Honza Král
parameter is the empty tuple. Thanks alexdutton! git-svn-id: http://code.djangoproject.com/svn/django/trunk@14199 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-10-13Fixed #13811 -- Changed unique validation in model formsets to ignore None ↵Honza Král
values, not just omit them git-svn-id: http://code.djangoproject.com/svn/django/trunk@14193 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-09-11Fixed #13149 -- The admin `ForeignKeyRawIdWidget` now properly handles ↵Justin Bronn
non-integer values. Thanks, Chris Adams. git-svn-id: http://code.djangoproject.com/svn/django/trunk@13751 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-09-11Fixed #11905: Raise an error on model form creation if a non-existent field ↵Karen Tracey
was listed in fields. Thanks ben and copelco. git-svn-id: http://code.djangoproject.com/svn/django/trunk@13739 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-09-10Fixed #13095 -- `formfield_callback` keyword argument is now more sane and ↵Justin Bronn
works with widgets defined in `ModelForm.Meta.widgets`. Thanks, hvdklauw for bug report, vung for initial patch, and carljm for review. git-svn-id: http://code.djangoproject.com/svn/django/trunk@13730 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-08-14Fixed #13679, #13231, #7287 -- Ensured that models that have ↵Russell Keith-Magee
ForeignKeys/ManyToManyField can use a a callable default that returns a model instance/queryset. #13679 was a regression in behavior; the other two tickets are pleasant side effects. Thanks to 3point2 for the report. git-svn-id: http://code.djangoproject.com/svn/django/trunk@13577 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-05-04Fixed #12164 -- Removed the Python 2.3 compatibility imports and ↵Russell Keith-Magee
workarounds. Thanks to timo and claudep for the patch. git-svn-id: http://code.djangoproject.com/svn/django/trunk@13094 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-04-27Fixed #12749 -- Corrected a problem with validation of inline primary keys. ↵Russell Keith-Magee
Thanks to Chris.Wesseling@cwi.nl for the report, and nessita for the test case. git-svn-id: http://code.djangoproject.com/svn/django/trunk@13034 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-04-27Fixed #13407 -- Corrected verbose names for autogenerated m2m models, and ↵Russell Keith-Magee
cleaned up the default form prefix when an autogenerated m2m through model is used in a formset. Thanks to carljm for the report. git-svn-id: http://code.djangoproject.com/svn/django/trunk@13029 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-03-31Restored pre-r10062 behavior allowing None from formfield_callback to ↵Brian Rosner
exclude itself from the form git-svn-id: http://code.djangoproject.com/svn/django/trunk@12891 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-03-27Fixed #13023 - Removed ambiguity with regard to the max_num option of ↵Jannis Leidel
formsets and as a result of admin inlines. Thanks to Gabriel Hurley for the patch. git-svn-id: http://code.djangoproject.com/svn/django/trunk@12872 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-03-18Fixed #13138: Ensure required=False on a model form field overrides Karen Tracey
blank=False on the underlying model field during model form clean, in order to maintain backward compatibility. Thanks to saxon75 for the report. git-svn-id: http://code.djangoproject.com/svn/django/trunk@12802 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-03-16Fixed #12881: Corrected handling of inherited unique constraints. Thanks for ↵Karen Tracey
report fgaudin. git-svn-id: http://code.djangoproject.com/svn/django/trunk@12797 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-03-08Fixed #11183 - BaseForm init leaves pointers pointing back to base_fieldsLuke Plant
Thanks to margieroginski for the report git-svn-id: http://code.djangoproject.com/svn/django/trunk@12733 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-03-06Fixed #12960. The return value of ModelForm.clean() is now applied to the ↵Joseph Kocherhans
model. Thanks for the report, krejcik. git-svn-id: http://code.djangoproject.com/svn/django/trunk@12690 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-02-25Fixed #12901. Again. Model validation will not be performed on excluded ↵Joseph Kocherhans
fields that were overridden in the form. Thanks, ammarr. git-svn-id: http://code.djangoproject.com/svn/django/trunk@12590 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-02-23Fixed #12420. Now that OneToOneField allows assignment of None, stop ↵Joseph Kocherhans
guarding against it in ModelForms. Thanks, andrewsk. git-svn-id: http://code.djangoproject.com/svn/django/trunk@12545 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-02-23Fixed #12285. ModelForm raises a more informative error if it doesn't have a ↵Joseph Kocherhans
model class defined. Thanks, tobias. git-svn-id: http://code.djangoproject.com/svn/django/trunk@12526 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-02-22Fixed #12901. Exclude overridden form fields from model field validation. ↵Joseph Kocherhans
Thanks, Honza Král. git-svn-id: http://code.djangoproject.com/svn/django/trunk@12496 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-02-10Fixed #12698. Model.clean() used with a ModelForm no longer causes a ↵Joseph Kocherhans
KeyError when raising a ValidationError. Note that previously it was possible to raise a ValidationError in the same place with a message_dict attribute. That behavior was a bug and will no longer have the same behavior. git-svn-id: http://code.djangoproject.com/svn/django/trunk@12402 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-01-26Fixed #12508 - Added ability to dynamically add inlines in the admin app.Jannis Leidel
Refs #13. Also introduces an ``empty_form`` attribute on formsets to make it easier to implement dynamic forms. Many thanks to Zain Memon for the initial patch from his Summer of Code 2009 project, Stanislaus Madueke for his django-dynamic-formset app and all the other people helping out. git-svn-id: http://code.djangoproject.com/svn/django/trunk@12297 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-01-21Fixed #12596. Calling super from a ModelForm's clean method is once again ↵Joseph Kocherhans
optional. Failing to call super only skips unique validation as documented. Thanks for the initial patch and tests, carljm. git-svn-id: http://code.djangoproject.com/svn/django/trunk@12269 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-01-12Fixed #12510. Changed ModelChoiceField to stop using some of its ↵Joseph Kocherhans
superclasses implementation. This could cause more than one query when generating choices. Thanks, Petr Marhoun and Honza Kral. git-svn-id: http://code.djangoproject.com/svn/django/trunk@12211 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-01-12Fixed #12512. Changed ModelForm to stop performing model validation on ↵Joseph Kocherhans
fields that are not part of the form. Thanks, Honza Kral and Ivan Sagalaev. This reverts some admin and test changes from [12098] and also fixes #12507, #12520, #12552 and #12553. git-svn-id: http://code.djangoproject.com/svn/django/trunk@12206 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-01-10Fixed #9223 -- Added support for declarative widgets to ModelForm. I declare ↵Adrian Holovaty
thanks to isagalaev. git-svn-id: http://code.djangoproject.com/svn/django/trunk@12194 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-01-05Merged soc2009/model-validation to trunk. Thanks, Honza!Joseph Kocherhans
git-svn-id: http://code.djangoproject.com/svn/django/trunk@12098 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-12-22Fixed #1142 -- Added multiple database support.Russell Keith-Magee
This monster of a patch is the result of Alex Gaynor's 2009 Google Summer of Code project. Congratulations to Alex for a job well done. Big thanks also go to: * Justin Bronn for keeping GIS in line with the changes, * Karen Tracey and Jani Tiainen for their help testing Oracle support * Brett Hoerner, Jon Loyens, and Craig Kimmerer for their feedback. * Malcolm Treddinick for his guidance during the GSoC submission process. * Simon Willison for driving the original design process * Cal Henderson for complaining about ponies he wanted. ... and everyone else too numerous to mention that helped to bring this feature into fruition. git-svn-id: http://code.djangoproject.com/svn/django/trunk@11952 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-12-16Fixed #10263 -- Added a queryset argument to BaseInlineFormSet, normalizing ↵Russell Keith-Magee
with BaseModelFormSet, and allowing for custom ordering/subsets in inlines. Thanks to Paulo Scardine for the patch. git-svn-id: http://code.djangoproject.com/svn/django/trunk@11874 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-12-13Fixed #12215: Added len to ModelChoiceIterator. Thanks Alex and Tobias.Karen Tracey
git-svn-id: http://code.djangoproject.com/svn/django/trunk@11850 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-10-30Fixed #11872 -- Instantiate the correct model in BaseInlineFormSet.__init__ ↵Brian Rosner
when instance is None. Thanks tobias. git-svn-id: http://code.djangoproject.com/svn/django/trunk@11688 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-10-24Fixed #11402: added a `QuerySet.exists()` method. Thanks, Alex Gaynor.Jacob Kaplan-Moss
git-svn-id: http://code.djangoproject.com/svn/django/trunk@11646 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-07-03Fixed #10922 -- Corrected handling of POST data to ensure that the right ↵Russell Keith-Magee
objects are updated on save when the ordering field is editable. Thanks to Alex Gaynor, Karen Tracy, and Will Hardy for their contributions to this patch. git-svn-id: http://code.djangoproject.com/svn/django/trunk@11160 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-05-29Fixed a few Python 2.3 incompatibilities that were causing test failures.Gary Wilson Jr
git-svn-id: http://code.djangoproject.com/svn/django/trunk@10863 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-05-19Fixed #11149 -- Don't call save_form_data on file-type fields multiple times ↵Karen Tracey
when saving a model form. git-svn-id: http://code.djangoproject.com/svn/django/trunk@10826 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-05-15Fixed #11120 -- Corrected handling of inlines attached to inherited classes, ↵Russell Keith-Magee
broken by r10756. Thanks to George Song and Michael Strickland for the simultaneous reports. git-svn-id: http://code.djangoproject.com/svn/django/trunk@10787 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-05-14Fixed #10992: fixed a bug saving inlines with custom primary key fields. ↵Jacob Kaplan-Moss
Thanks, Zain. git-svn-id: http://code.djangoproject.com/svn/django/trunk@10777 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-05-13Fixed #10243, #11043 -- Corrected handling of formsets over a ForeignKey ↵Russell Keith-Magee
that uses to_field, and by extension, fixed the admin for handling fields of that type. Thanks to apollo13 for the initial patch. git-svn-id: http://code.djangoproject.com/svn/django/trunk@10756 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-05-10Changed r10668 to not falsely error out when using generic inlines.Malcolm Tredinnick
The bug was picked up by the tests already, but only if run against a backend that supports referential integrity. git-svn-id: http://code.djangoproject.com/svn/django/trunk@10732 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-05-10Fixed #10792 -- Ensured that ModelChoiceFields don't provide an empty option ↵Russell Keith-Magee
when the underlying field has blank=False and there is a default value available. Thanks to carljm for the report and patch. git-svn-id: http://code.djangoproject.com/svn/django/trunk@10729 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-05-08Fixed #10750: respect comment=False in inline formsets. Thanks, Koen Biermans.Jacob Kaplan-Moss
git-svn-id: http://code.djangoproject.com/svn/django/trunk@10706 bcc190cf-cafb-0310-a4f2-bffc1f526a37