summaryrefslogtreecommitdiff
path: root/django/forms/models.py
AgeCommit message (Collapse)Author
2009-07-03Fixed #10922 -- Corrected handling of POST data to ensure that the right ↵Russell Keith-Magee
objects are updated on save when the ordering field is editable. Thanks to Alex Gaynor, Karen Tracy, and Will Hardy for their contributions to this patch. git-svn-id: http://code.djangoproject.com/svn/django/trunk@11160 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-05-29Fixed a few Python 2.3 incompatibilities that were causing test failures.Gary Wilson Jr
git-svn-id: http://code.djangoproject.com/svn/django/trunk@10863 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-05-19Fixed #11149 -- Don't call save_form_data on file-type fields multiple times ↵Karen Tracey
when saving a model form. git-svn-id: http://code.djangoproject.com/svn/django/trunk@10826 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-05-15Fixed #11120 -- Corrected handling of inlines attached to inherited classes, ↵Russell Keith-Magee
broken by r10756. Thanks to George Song and Michael Strickland for the simultaneous reports. git-svn-id: http://code.djangoproject.com/svn/django/trunk@10787 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-05-14Fixed #10992: fixed a bug saving inlines with custom primary key fields. ↵Jacob Kaplan-Moss
Thanks, Zain. git-svn-id: http://code.djangoproject.com/svn/django/trunk@10777 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-05-13Fixed #10243, #11043 -- Corrected handling of formsets over a ForeignKey ↵Russell Keith-Magee
that uses to_field, and by extension, fixed the admin for handling fields of that type. Thanks to apollo13 for the initial patch. git-svn-id: http://code.djangoproject.com/svn/django/trunk@10756 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-05-10Changed r10668 to not falsely error out when using generic inlines.Malcolm Tredinnick
The bug was picked up by the tests already, but only if run against a backend that supports referential integrity. git-svn-id: http://code.djangoproject.com/svn/django/trunk@10732 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-05-10Fixed #10792 -- Ensured that ModelChoiceFields don't provide an empty option ↵Russell Keith-Magee
when the underlying field has blank=False and there is a default value available. Thanks to carljm for the report and patch. git-svn-id: http://code.djangoproject.com/svn/django/trunk@10729 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-05-08Fixed #10750: respect comment=False in inline formsets. Thanks, Koen Biermans.Jacob Kaplan-Moss
git-svn-id: http://code.djangoproject.com/svn/django/trunk@10706 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-05-07Fixed #9493 -- Corrected error handling of formsets that violate unique ↵Russell Keith-Magee
constraints across the component forms. Thanks to Alex Gaynor for the patch. git-svn-id: http://code.djangoproject.com/svn/django/trunk@10682 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-05-07Fixed #10893 -- Corrected a problem with using list_editable in the admin ↵Russell Keith-Magee
when the model has a manual primary key. Thanks to Alex Gaynor for the patch. git-svn-id: http://code.djangoproject.com/svn/django/trunk@10681 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-04-30Fixed #10134 -- Added unique_for_[date|day|month|year] validation to ↵Russell Keith-Magee
ModelForm handling. Thanks to Alex Gaynor for the patch. git-svn-id: http://code.djangoproject.com/svn/django/trunk@10646 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-04-22Fixed #10163: add an artificial ordering to querysets used by formsets, thus ↵Jacob Kaplan-Moss
ensuring that POSTed data "lines up" correctly every time. Thanks to Karen Tracey for pointing in the right direction here. git-svn-id: http://code.djangoproject.com/svn/django/trunk@10625 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-04-22Fixed #10208: `ModelAdmin` now respects the `exclude` and `field` atributes ↵Jacob Kaplan-Moss
of custom `ModelForm`s. Thanks, Alex Gaynor. git-svn-id: http://code.djangoproject.com/svn/django/trunk@10619 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-04-18Fixed #10799: fixed the use of list_editable with model inheritance and ↵Jacob Kaplan-Moss
custom one-to-one parent links. Thanks, Alex Gaynor. git-svn-id: http://code.djangoproject.com/svn/django/trunk@10590 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-04-18Fixed #10156: `ModelMultipleChoiceField.clean` now does a single query ↵Jacob Kaplan-Moss
instead of O(N). Thanks, Alex Gaynor. Also, I ported a few more doctests to unittests. git-svn-id: http://code.djangoproject.com/svn/django/trunk@10582 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-04-16Fixed #10363 -- Modified ModelForm handling to ensure that excluded fields ↵Russell Keith-Magee
can't be saved onto the model. Thanks to jgoldberg for the report, an Alex Gaynor for the fix. git-svn-id: http://code.djangoproject.com/svn/django/trunk@10575 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-04-11Fixed #10645 -- Added some robustness around some admin and modelform params.Malcolm Tredinnick
Fieldset dictionary names, search fields and unique_together attribute names all have to be convertible to strings (that has always been true). If somebody passes in a unicode object, Python barfs because Django uses those values as keyword argument names and function calls require parameter names to be str objects. We now convert thing to strs automatically. git-svn-id: http://code.djangoproject.com/svn/django/trunk@10510 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-04-10Fixed #10038: make `BaseModelFormSet.save_existing_objects` use ↵Jacob Kaplan-Moss
`Form.has_changed()` instead of looking at `changed_data` directly. Thanks, karihre. git-svn-id: http://code.djangoproject.com/svn/django/trunk@10495 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-04-02Fixed #9651: fixed save_as with inline forms. Thanks, kmike and Mnewman.Jacob Kaplan-Moss
git-svn-id: http://code.djangoproject.com/svn/django/trunk@10353 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-03-31Forms in model formsets and inline formsets can now be deleted even if they ↵Joseph Kocherhans
don't validate. Related to #9587. git-svn-id: http://code.djangoproject.com/svn/django/trunk@10283 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-03-31Fixed #9863. A ForeignKey with editable=False to the parent in an inline no ↵Joseph Kocherhans
longer raises an exception. Thanks to keithb for the test case and Alex Gaynor for the patch. git-svn-id: http://code.djangoproject.com/svn/django/trunk@10239 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-03-30Fixed #8746: Check data in raw_id_fields more closely. Thanks, dgouldinJacob Kaplan-Moss
git-svn-id: http://code.djangoproject.com/svn/django/trunk@10233 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-03-30Fixed #9284. Fixed #8813. BaseModelFormSet now calls ModelForm.save().Joseph Kocherhans
This is backwards-incompatible if you were doing things to 'initial' in BaseModelFormSet.__init__, or if you relied on the internal _total_form_count or _initial_form_count attributes of BaseFormSet. Those attributes are now public methods. git-svn-id: http://code.djangoproject.com/svn/django/trunk@10190 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-03-17Fixed #10512 -- Corrected the handling of extra fields on a ModelForm. ↵Russell Keith-Magee
Thanks to Alex Gaynor for the patch. git-svn-id: http://code.djangoproject.com/svn/django/trunk@10070 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-03-15Fixed #8164 -- Fields on a ModelForm are now ordered in the order specified ↵Russell Keith-Magee
in the fields attribute of the ModelForm's Meta class. Thanks to Alex Gaynor for the patch. git-svn-id: http://code.djangoproject.com/svn/django/trunk@10062 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-03-10Fixed #10271, #10281 -- Fixed the handling multiple inline models that ↵Russell Keith-Magee
share a common base class and have the link to the inline parent on the base class. Includes modifications that allow the equivalent handling for GenericFields. Thanks to Idan Gazit, Antti Kaihola (akaihola), and Alex Gaynor for their work on this patch. git-svn-id: http://code.djangoproject.com/svn/django/trunk@10017 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-02-03Fixed 10075: Allowed saving of inline-edited models that use multi-table ↵Karen Tracey
inheritance. git-svn-id: http://code.djangoproject.com/svn/django/trunk@9809 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-01-19Fixed #10069 -- Fixed the model form unique validation code to not proceed ↵Karen Tracey
with using, for example, RelatedObjects returned by get_field_by_name as though they were model Fields. git-svn-id: http://code.djangoproject.com/svn/django/trunk@9777 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-12-23Fixed #9882 -- Added `alters_data = True` to `BaseModelForm.save` method, ↵Gary Wilson Jr
thanks dc. git-svn-id: http://code.djangoproject.com/svn/django/trunk@9678 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-12-21Fixed #9865 -- Allow saving of new inline-edited objects with custom ↵Karen Tracey
non-auto primary key fields that are not the foreign key to the parent object. git-svn-id: http://code.djangoproject.com/svn/django/trunk@9664 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-12-08The first step in fixing a group of problems related to outputting a properMalcolm Tredinnick
"value" for a field that is a relation to another model. This part adds the utility method on Model that should help in general.Also cleans up the slightly ugly mess from r8957. git-svn-id: http://code.djangoproject.com/svn/django/trunk@9601 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-11-14Fixed #9076 -- Changed BaseInlineFormSet to not override BaseModelFormSet's ↵Karen Tracey
get_queryset method. BaseInlineFormSet's method did not include a couple of fixes/enhancements that were made to the parent's method, resulting in excessive queries (some of which can return bad data due to #9006) for admin pages with inlines. git-svn-id: http://code.djangoproject.com/svn/django/trunk@9440 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-11-05Fixed #9218 -- Simplified the fix from #9039 and added tests to ensure this ↵Karen Tracey
case doesn't break again (and that the simplification didn't break anything). git-svn-id: http://code.djangoproject.com/svn/django/trunk@9341 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-11-04Fixed #9418 -- When saving a model form, defer saving of file-type fields ↵Karen Tracey
until after other fields, so that callable upload_to methods can use data from the other fields. Thanks to Bernd Schlapsi for the report and initial patch. git-svn-id: http://code.djangoproject.com/svn/django/trunk@9334 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-11-01Fixed #9494 -- Ensure the foreign key in an inline formset is always present ↵Brian Rosner
on the forms. Thanks Fugazi for the report. git-svn-id: http://code.djangoproject.com/svn/django/trunk@9326 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-10-31Fixed #8882 -- When a foreign key is among the unique_together fields in an ↵Brian Rosner
inline formset properly handle it. git-svn-id: http://code.djangoproject.com/svn/django/trunk@9297 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-10-28Fixed #9462 -- Set the instance in an inline formset correctly so that None ↵Brian Rosner
does not get passed through to the queryset. Thanks tobias and copelco for the ticket. git-svn-id: http://code.djangoproject.com/svn/django/trunk@9293 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-10-21Fixed #9039 -- Don't perform unique checks on NULL values, since NULL != ↵Karen Tracey
NULL in SQL. git-svn-id: http://code.djangoproject.com/svn/django/trunk@9239 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-10-08Fixed #9319 -- Fixed a crash when using the same model field in multipleMalcolm Tredinnick
unique_together constraints. git-svn-id: http://code.djangoproject.com/svn/django/trunk@9208 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-09-27Fixed #9171 -- Fixed a few places where we were assuming lists instead ofMalcolm Tredinnick
generic sequences in ModelForm structures. Patch from mrmachine. git-svn-id: http://code.djangoproject.com/svn/django/trunk@9086 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-09-03Fixed #8841 -- Fixed a case of ForeignKeys to models constructed withMalcolm Tredinnick
inheritance. This patch is uglier than it needs to be (see comment in patch) to ensure no accidental bug is introduced just before 1.0. We'll clean it up later. git-svn-id: http://code.djangoproject.com/svn/django/trunk@8957 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-09-02Fixed #8788: fixed a few typoes in [8805]. Thanks, Matthew Flanagan and mir.Jacob Kaplan-Moss
git-svn-id: http://code.djangoproject.com/svn/django/trunk@8872 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-09-02Fixed #8795: unique_together validation no longer fails on model forms that ↵Jacob Kaplan-Moss
exclude fields included in the check. Thanks, Alex Gaynor. git-svn-id: http://code.djangoproject.com/svn/django/trunk@8854 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-09-01Fixed #8648 -- Admin no longer ignores to_field. Thanks for the help Karen ↵Brian Rosner
Tracey and SmileyChris. git-svn-id: http://code.djangoproject.com/svn/django/trunk@8823 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-09-01Fixup for Python 2.3.Malcolm Tredinnick
git-svn-id: http://code.djangoproject.com/svn/django/trunk@8822 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-09-01Fixed #8777: use better capitalization in unique together error message. ↵Jacob Kaplan-Moss
Thanks, Petr Marhoun. git-svn-id: http://code.djangoproject.com/svn/django/trunk@8820 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-09-01Fixed #8209: `ModelForm`s now validate unique constraints. Alex Gaynor did ↵Jacob Kaplan-Moss
much of this work, and Brian Rosner helped as well. git-svn-id: http://code.djangoproject.com/svn/django/trunk@8805 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-08-31Enforce max_num=1 on inline model formsets that have a unique foreign key to ↵Brian Rosner
its parent. I snuck in a quick clean up to the inlineformset_factory as well. git-svn-id: http://code.djangoproject.com/svn/django/trunk@8775 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-08-31Fixed handling of primary keys in model formsets. Model formsets should now ↵Brian Rosner
work nicely with custom primary keys that are OneToOneField, ForeignKey and AutoField. Added tests to handle each of them. Fixes #8241, #8694, #8695 and #8719. Thanks Karen Tracey, jonloyens, sciyoshi, semenov and magneto for tracking down various parts of this patch. git-svn-id: http://code.djangoproject.com/svn/django/trunk@8756 bcc190cf-cafb-0310-a4f2-bffc1f526a37