summaryrefslogtreecommitdiff
path: root/django/db
AgeCommit message (Collapse)Author
2022-09-25Fixed #34027 -- Fixed migrations crash when altering type of char/text ↵David Sanders
fields referenced by foreign key on PostgreSQL.
2022-09-23Fixed #34024 -- Fixed crash when aggregating querysets with Q objects ↵David Sanders
annotations. This reverts b64db05b9cedd96905d637a2d824cbbf428e40e7. It was reasonable to assume it was unnecessary code as there were no failing tests upon its removal. This commit adds the necessary regression tests for the failing condition identified in #34024 alongside the original tests added in the PR for which WhereNode.is_summary was introduced.
2022-09-22Fixed #34015 -- Allowed filtering by transforms on relation fields.Mariusz Felisiak
2022-09-16Fixed #33966 -- Added support for using KeyTextTransform from lookup.Allen Jonathan David
2022-09-15Refs #28333 -- Explicitly ordered outer qualify query on window filtering.Simon Charette
While most backends will propagate derived table ordering as long as the outer query doesn't perform additional processing the SQL specs doesn't explicitly state the ordering must be maintained.
2022-09-13Fixed #33996 -- Fixed CheckConstraint validation on NULL values.David Sanders
Bug in 667105877e6723c6985399803a364848891513cc. Thanks James Beith for the report.
2022-09-13Fixed #31335 -- Fixed removing composed composed Meta constraints/indexes on ↵Sergey Fursov
foreign keys on MySQL.
2022-09-12Refs #31335 -- Added SchemaEditor._create_missing_fk_index() on MySQL.Sergey Fursov
2022-09-09Fixed #33975 -- Fixed __in lookup when rhs is a queryset with annotate() and ↵DevilsAutumn
alias(). This fixes clearing selected fields.
2022-09-08Fixed #33992 -- Fixed queryset crash when aggregating over a group ↵Simon Charette
containing Exists. A more in-depth solution is likely to make sure that we always GROUP BY selected annotations or revisit how we use Query.exists() in the Exists expression but that requires extra work that isn't suitable for a backport. Regression in e5a92d400acb4ca6a8e1375d1ab8121f2c7220be. Thanks Fernando Flores Villaça for the report.
2022-09-07Fixed #33982 -- Fixed migrations crash when adding model with ↵James Beith
ExclusionConstraint. Regression in 0e656c02fe945389246f0c08f51c6db4a0849bd2.
2022-09-06Refs #33616 -- Updated BaseDatabaseWrapper.run_on_commit comment.DevilsAutumn
2022-09-06Fixed #33616 -- Allowed registering callbacks that can fail in ↵SirAbhi13
transaction.on_commit(). Thanks David Wobrock and Mariusz Felisiak for reviews.
2022-09-06Refs #26780 -- Made prefetch_related() don't use window expressions fo ↵Mariusz Felisiak
sliced queries if not supported.
2022-09-02Fixed #29799 -- Allowed registering lookups per field instances.Allen Jonathan David
Thanks Simon Charette and Mariusz Felisiak for reviews and mentoring this Google Summer of Code 2022 project.
2022-08-30Fixed #21204 -- Tracked field deferrals by field instead of models.Simon Charette
This ensures field deferral works properly when a model is involved more than once in the same query with a distinct deferral mask.
2022-08-30Merged nested if statements in select_related_descend().Simon Charette
2022-08-29Fixed #33960 -- Fixed migrations crash on SQLite < 3.26.Mariusz Felisiak
Regression in 0b95a96ee10d3e12aef01d449467bcf4641286b4. Thanks Aristotelis Mikropoulos for the report.
2022-08-27Fixed #33954 -- Prevented models.DecimalField from accepting NaN, Inf, and ↵Mohamed Karam
-Inf values.
2022-08-27Fixed #33952 -- Reallowed creating reverse foreign key managers on unsaved ↵David Wobrock
instances. Thanks Claude Paroz for the report. Regression in 7ba6ebe9149ae38257d70100e8bfbfd0da189862.
2022-08-27Fixed #33928 -- Avoided unnecessary queries when cascade updating.Simon Charette
Models that use SET, SET_NULL, and SET_DEFAULT as on_delete handler don't have to fetch objects for the sole purpose of passing them back to a follow up UPDATE query filtered by the retrieved objects primary key. This was achieved by flagging SET handlers as _lazy_ and having the collector logic defer object collections until the last minute. This should ensure that the rare cases where custom on_delete handlers are defined remain uncalled when when dealing with an empty collection of instances. This reduces the number queries required to apply SET handlers from 2 to 1 where the remaining UPDATE use the same predicate as the non removed SELECT query. In a lot of ways this is similar to the fast-delete optimization that was added in #18676 but for updates this time. The conditions only happen to be simpler in this case because SET handlers are always terminal. They never cascade to more deletes that can be combined. Thanks Renan GEHAN for the report.
2022-08-27Refs #33928 -- Removed unnecessary attribute assignment on on-delete updates.Simon Charette
Model instances retrieved for bulk field update purposes are not exposed to the outside world and thus are not required to be kept update to date.
2022-08-26Fixed #33953 -- Reverted "Fixed #33201 -- Made RenameModel operation a noop ↵Iuri de Silvio
for models with db_table." Regression in afeafd6036616bac8263d762c1610f22241c0187. This reverts afeafd6036616bac8263d762c1610f22241c0187. Thanks Timothy Thomas for the report.
2022-08-25Fixed #33938 -- Fixed migration crash for m2m with a through model in ↵Simon Charette
another app. Regression in aa4acc164d1247c0de515c959f7b09648b57dc42. Thanks bryangeplant for the report.
2022-08-25Fixed typo in django/db/models/fields/files.py comment.Jan Pieter Waagmeester
2022-08-25Fixed #33916 -- Added support for serialization of enum.Flag in migrations.Willem Van Onsem
2022-08-18Refs #26511 -- Fixed json.KeyTextTransform() on MySQL/MariaDB.Mariusz Felisiak
2022-08-17Fixed #33932 -- Fixed altering AutoFields to OneToOneField on PostgreSQL.Benoît Vinot
Regression in 2eea361eff58dd98c409c5227064b901f41bd0d6.
2022-08-15Fixed #26780 -- Added prefetch_related() support for sliced queries.Simon Charette
This was made possible by window function filtering support added in f387d024fc75569d2a4a338bfda76cc2f328f627.
2022-08-15Refs #28333 -- Added partial support for filtering against window functions.Simon Charette
Adds support for joint predicates against window annotations through subquery wrapping while maintaining errors for disjointed filter attempts. The "qualify" wording was used to refer to predicates against window annotations as it's the name of a specialized Snowflake extension to SQL that is to window functions what HAVING is to aggregates. While not complete the implementation should cover most of the common use cases for filtering against window functions without requiring the complex subquery pushdown and predicate re-aliasing machinery to deal with disjointed predicates against columns, aggregates, and window functions. A complete disjointed filtering implementation should likely be deferred until proper QUALIFY support lands or the ORM gains a proper subquery pushdown interface.
2022-08-15Fixed #33901 -- Skipped varchar_pattern_ops/text_pattern_ops index creation ↵Haolun Chai
when db_collation is set.
2022-08-12Fixed #33919 -- Fixed adding AutoFields on PostgreSQL.Mariusz Felisiak
Thanks Jack Calvin Brown for the report. Regression in 2eea361eff58dd98c409c5227064b901f41bd0d6.
2022-08-11Refs #28333 -- Moved SQLCompiler's forced column aliasing logic to get_select().Simon Charette
This extends query composability possibilities when dealing with subqueries which is necessary to implement window function filtering.
2022-08-11Replaced Expression.replace_references() with .replace_expressions().Simon Charette
The latter allows for more generic use cases beyond the currently limited ones constraints validation has. Refs #28333, #30581.
2022-08-10Refs #33895 -- Fixed Case() crash with filters that match everything in ↵Mariusz Felisiak
When() on Oracle. Follow up to 036bb2b74afb50a71e7a945e8dd83499b603ac3a.
2022-08-09Fixed #33895 -- Fixed Case() crash with filters that match everything in When().David Wobrock
Thanks shukryzablah for the report.
2022-08-09Fixed #33902 -- Fixed Meta.constraints validation crash with F() expressions.Mariusz Felisiak
Thanks Adam Zahradník for the report. Bug in 667105877e6723c6985399803a364848891513cc.
2022-08-08Fixed #33899 -- Fixed migration crash when removing indexed field on SQLite ↵Fiza Ashraf
3.35.5+. Regression in 702819227fd0cdd9b581cd99e11d1561d51cbeb. Thanks cessor for the report.
2022-08-06Fixed #33898 -- Fixed Window() expression crash with ArrayAgg().Mariusz Felisiak
Thanks Kia for the report. Regression in e06dc4571ea9fd5723c8029959b95808be9f8812.
2022-08-03Fixed #33872 -- Deprecated ↵Mariusz Felisiak
django.contrib.postgres.fields.CIText/CICharField/CIEmailField/CITextField.
2022-08-02Fixed #33881 -- Added support for database collations to ↵Mariusz Felisiak
ArrayField(Char/TextFields).
2022-07-27Fixed collation tests on MySQL 8.0.30+.Mariusz Felisiak
The utf8_ collations are renamed to utf8mb3_* on MySQL 8.0.30+.
2022-07-27Refs #32948, Refs #32946 -- Used Q.create() internally for dynamic Q() objects.Nick Pope
Node.create() which has a compatible signature with Node.__init__() takes in a single `children` argument rather than relying in unpacking *args in Q.__init__() which calls Node.__init__(). In addition, we were often needing to unpack iterables into *args and can instead pass a list direct to Node.create().
2022-07-27Refs #32948 -- Simplified and optimized Q._combine() and __invert__().Nick Pope
- Removed use of Q.deconstruct() in Q._combine(). - Simplified and optimized Q.__invert__() by taking a shallow copy and swapping the negated attribute only. - Simplified construction in Q._combine(). - Simplified conditions in Q._combine() as Q.conditional = True the first isinstance() check is unnecessary. - Removed copy.copy() branch in Q._combine(). Co-authored-by: Keryn Knight <keryn@kerynknight.com>
2022-07-27Refs #32948 -- Added Node.__copy__().Nick Pope
This allows the copy.copy() usage in the Q._combine() method to finish sooner, instead of having to fallback to using the __reduce_ex__(4) method. Thia also avoids having to fall into copy.copy() at in Q._combine(), when combining a Q() with another Q(). Co-authored-by: Keryn Knight <keryn@kerynknight.com>
2022-07-27Refs #32948 -- Simplified WhereNode and Node.__deepcopy__()/add().Nick Pope
We can use copy() in Node.add() instead of create() as we don't need the children to be cloned via [:] subscript in __init__().
2022-07-27Refs #32948 -- Renamed Node._new_instance() to Node.create().Nick Pope
Node._new_instance() was added in 6dd2b5468fa275d53aa60fdcaff8c28bdc5e9c25 to work around Q.__init__() having an incompatible signature with Node.__init__(). It was intended as a hook that could be overridden if subclasses needed to change the behaviour of instantiation of their specialised form of Node. In practice this doesn't ever seem to have been used for this purpose and there are very few calls to Node._new_instance() with other code, e.g. Node.__deepcopy__() calling Node and overriding __class__ as required. Rename this to Node.create() to make it a more "official" piece of private API that we can use to simplify a lot of other areas internally. The docstring and nearby comment have been reworded to read more clearly.
2022-07-27Removed obsolete docstring from WhereNode.clone().Nick Pope
Node.subtree_parents was removed in d3f00bd5706b35961390d3814dd7e322ead3a9a3. That commit also added Q.clone() which was identical to WhereNode.clone(), but lacked the docstring. Q.clone() was later removed in b454e2cbc95eb26fa0c32b54c53ae24fc40e8c02.
2022-07-27Used AND, OR, XOR constants instead of hard-coded values.Nick Pope
2022-07-26Refs #27236 -- Reverted "Refs #27236 -- Refactored out ↵Mariusz Felisiak
DeprecationForHistoricalMigrationMixin." This reverts commit 57793b47657ace966ce8ce96d801ac0d85e5efc6.