summaryrefslogtreecommitdiff
path: root/django/db/models
AgeCommit message (Collapse)Author
2011-10-07Fixed #17014 - added protection against infinite recursion.Luke Plant
Thanks to akaariai for the report and tests. No tests have been added, since unittests for termination are basically impossible, and the failure condition will take down the developer's machine in this case. It has been tested against the cases in #17014. git-svn-id: http://code.djangoproject.com/svn/django/trunk@16940 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-10-07Fixed #17003 - prefetch_related should support foreign keys/one-to-oneLuke Plant
Support for `GenericForeignKey` is also included. git-svn-id: http://code.djangoproject.com/svn/django/trunk@16939 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-10-06Removed ForeignRelatedObjectsDescriptor.RelatedManager.delete_manager, which ↵Luke Plant
has been unused since [14507] And cleaned up the result, allowing more consistency with the other related descriptors. git-svn-id: http://code.djangoproject.com/svn/django/trunk@16931 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-10-05Fixed #16937 - added `QuerySet.prefetch_related` to prefetch many related ↵Luke Plant
objects. Many thanks to akaariai for lots of review and feedback, bug finding, additional unit tests and performance testing. git-svn-id: http://code.djangoproject.com/svn/django/trunk@16930 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-10-05Fixed #16902 - select_related() results in a poor perfomanceLuke Plant
Thanks to ivan_virabyan for the great patch! (For the record, some very small tweaks were made by me). git-svn-id: http://code.djangoproject.com/svn/django/trunk@16929 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-09-30Fixed #14270 - related manager classes should be cachedLuke Plant
Thanks to Alex Gaynor for the report and initial patch, and mrmachine for more work on it. git-svn-id: http://code.djangoproject.com/svn/django/trunk@16916 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-09-29Cleanups to related manager code, especially in use of closures.Luke Plant
The related manager classes are defined within functions, and the methods had inconsistent and confusing usage of closures vs. parameters on self to retrieve needed information. Everything is stored on self now. Also some methods were not using super() where they should have been. git-svn-id: http://code.djangoproject.com/svn/django/trunk@16913 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-09-29Small cleanups of 'related manager' code for consistencyLuke Plant
git-svn-id: http://code.djangoproject.com/svn/django/trunk@16912 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-09-26Removed unused parameter 'join_table' in various bits of RelatedManager codeLuke Plant
git-svn-id: http://code.djangoproject.com/svn/django/trunk@16907 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-09-22Fixed #7198 (again) -- Corrects a problem with string interpolation from ↵Gabriel Hurley
r16876 and adds tests for the new error message. git-svn-id: http://code.djangoproject.com/svn/django/trunk@16888 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-09-22Fixed #7198 -- Improved error message when missing models.py. Thanks ↵Paul McMillan
Silver_Ghost and for the patch. git-svn-id: http://code.djangoproject.com/svn/django/trunk@16876 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-09-10Remove a bunch of deadcode/dead imports.Alex Gaynor
git-svn-id: http://code.djangoproject.com/svn/django/trunk@16794 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-09-10Fixed bulk_insertion on databases which don't yet support it. Thanks to ↵Alex Gaynor
Justin Bronn for his Oracle wizardry. git-svn-id: http://code.djangoproject.com/svn/django/trunk@16793 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-09-10Ensure bulk_create returns the right value if the argument is an empty list.Alex Gaynor
git-svn-id: http://code.djangoproject.com/svn/django/trunk@16792 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-09-10Ensure bulk_create returns what it is supposed to.Alex Gaynor
git-svn-id: http://code.djangoproject.com/svn/django/trunk@16791 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-09-10Altered the behavior of URLField to avoid a potential DOS vector, and to ↵Russell Keith-Magee
avoid potential leakage of local filesystem data. A security announcement will be made shortly. git-svn-id: http://code.djangoproject.com/svn/django/trunk@16760 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-09-09Fixed #7596. Added Model.objects.bulk_create, and make use of it in several ↵Alex Gaynor
places. This provides a performance benefit when inserting multiple objects. THanks to Russ for the review, and Simon Meers for the MySQl implementation. git-svn-id: http://code.djangoproject.com/svn/django/trunk@16739 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-08-25Make ManyToManyField model references more robust.Malcolm Tredinnick
In r16679 a test was added to verify something had been fixed when a unicode string type was passed in as a model name. The name has to be ASCII convertible, but in Python 2.6 and earlier, it must also have str type. This commit fixes the problem for earlier Python versions and is almost identical to a patch from b.leskes in #6045. Fixes #16689. Refs #6045. git-svn-id: http://code.djangoproject.com/svn/django/trunk@16682 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-08-23Allow "pk" as a field alias in QuerySet.only() calls.Malcolm Tredinnick
Thanks to GDorn for the patch. Fixed #15494. git-svn-id: http://code.djangoproject.com/svn/django/trunk@16668 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-08-23Fixed #16299 -- Ensure that unicode strings can be used to identify classes ↵Russell Keith-Magee
in ForeignKey and ManyToManyFields. Unicode strings aren't actually legal as class names, but this is an issue if you use from __future__ import unicode_literals in your models.py file. Thanks to Martijn Bastiaan for the report, and Anthony Briggs for the final patch. git-svn-id: http://code.djangoproject.com/svn/django/trunk@16663 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-08-23Fix initialisation of ImageField super classes.Malcolm Tredinnick
Fixes #16548, with thanks to pyriku. git-svn-id: http://code.djangoproject.com/svn/django/trunk@16658 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-08-23Fixed an isnull=False filtering edge-case. Fixes #15316.Malcolm Tredinnick
The bulk of this patch is due to some fine analysis from Aleksandra Sendecka. git-svn-id: http://code.djangoproject.com/svn/django/trunk@16656 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-08-23Added convenience method for viewing Query SQL without params.Malcolm Tredinnick
This is the old Query.as_sql() method revived: it's like Query.__str__, but the parameters aren't substituted into the placeholders. Thus, it's a more accurate representation of the SQL the (default) backend will see. Entirely internal. git-svn-id: http://code.djangoproject.com/svn/django/trunk@16655 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-08-22Fixed #14876 -- Ensure that join promotion works correctly when there are ↵Russell Keith-Magee
nullable related fields. Thanks to simonpercivall for the report, oinopion and Aleksandra Sendecka for the original patch, and to Malcolm for helping me wrestle the edge cases to the ground. git-svn-id: http://code.djangoproject.com/svn/django/trunk@16648 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-08-22Improved error message display during validation errors.Malcolm Tredinnick
When reporting a validation error (during model validation or fixture loading, for example), the error messages now report the bad value as well as the expected type. This can make identifying the offending field and problem a bit easier. Fixed #11595. Patch from raulcd and wildfire with supervision from Russell. git-svn-id: http://code.djangoproject.com/svn/django/trunk@16638 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-08-13Fixed #14695 -- Stopped model fields from incorrectly overwriting the field ↵Jannis Leidel
name during model initialization if it was already passed as a keyword argument. Thanks, erikrose and willhardy. git-svn-id: http://code.djangoproject.com/svn/django/trunk@16614 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-08-12Fixed #10405 -- Raise a more useful error if the formfield of a related ↵Jannis Leidel
model field can't be created yet because the related model isn't loaded yet. Thanks ojii and charstring. git-svn-id: http://code.djangoproject.com/svn/django/trunk@16604 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-08-12Fixed #16584 -- Fixed a bunch of typos in code comments. Thanks, Bernhard Essl.Jannis Leidel
git-svn-id: http://code.djangoproject.com/svn/django/trunk@16598 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-07-29Fixed #16472 -- Removed stale code in the query code. Thanks, fva@chtd.org.Jannis Leidel
git-svn-id: http://code.djangoproject.com/svn/django/trunk@16562 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-07-29Fixed #16531 -- Fixed various instances of "undefined name" issues. Thanks, ↵Jannis Leidel
Bruno Renié. git-svn-id: http://code.djangoproject.com/svn/django/trunk@16557 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-07-13Fixed #16225 -- Removed unused imports. Many thanks to Aymeric Augustin for ↵Jannis Leidel
the work on the patch and Alex for reviewing. git-svn-id: http://code.djangoproject.com/svn/django/trunk@16539 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-07-07Fixed #16409 -- Fixed an error condition when using QuerySet only()/defer() ↵Ramiro Morales
on the result of an annotate() call. Thanks jaklaassen AT gmail DOT com and Tai Lee for the reports and Tai for the patch. git-svn-id: http://code.djangoproject.com/svn/django/trunk@16522 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-06-28Fixed #5535 -- Allow using an explicit foreign key in get() calls. Thanks, ↵Jannis Leidel
Michal Petrucha. git-svn-id: http://code.djangoproject.com/svn/django/trunk@16473 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-06-13Fixed #16246 -- Fixed GenericIPAddressField tests on PostgreSQL.Jannis Leidel
git-svn-id: http://code.djangoproject.com/svn/django/trunk@16395 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-06-13Refs #16234: Avoid GenericIPAddressField clobbering Field ↵Karen Tracey
default_error_messages dict. git-svn-id: http://code.djangoproject.com/svn/django/trunk@16390 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-06-11Fixed #811 -- Added support for IPv6 to forms and model fields. Many thanks ↵Jannis Leidel
to Erik Romijn. git-svn-id: http://code.djangoproject.com/svn/django/trunk@16366 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-06-09Fixed #16155 -- Removed Python 2.4 compatibility constructs from code and ↵Ramiro Morales
mentions from docs. Thanks Aymeric Augustin for the report and patch. git-svn-id: http://code.djangoproject.com/svn/django/trunk@16349 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-06-09Fixed #8913 - Make "must be unique" error messages customisable. Thanks to ↵Andrew Godwin
Leah Culver. git-svn-id: http://code.djangoproject.com/svn/django/trunk@16345 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-06-07Made clear() on a reverse foreign key significantly more efficient. Thanks ↵Alex Gaynor
to Andrew Godwin for the review. git-svn-id: http://code.djangoproject.com/svn/django/trunk@16335 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-05-30Fixed #15776 - delete regression in Django 1.3 involving nullable foreign keysLuke Plant
Many thanks to aaron.l.madison for the detailed report and to emulbreh for the fix. git-svn-id: http://code.djangoproject.com/svn/django/trunk@16295 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-05-21Fixed #11789 -- Fixed aggregates so it interacts with QuerySet none() in a ↵Ramiro Morales
way consistent with other empty query sets. Thanks alexr for the report and patch. git-svn-id: http://code.djangoproject.com/svn/django/trunk@16254 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-05-21Fixed #14476 -- Fixed resolution of automatically generated annotation names ↵Ramiro Morales
so e.g. filtering based on them works. Thanks dirleyls for the report and patch. git-svn-id: http://code.djangoproject.com/svn/django/trunk@16252 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-05-15Fixed #15790 -- Fixed QuerySet only() and defer() methods behavior with ↵Ramiro Morales
proxy models. Thanks Michal Modzelewzki for the report and patch. git-svn-id: http://code.djangoproject.com/svn/django/trunk@16228 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-05-07Fixed #15709 - Duplicated group_by conditionLuke Plant
Thanks to ziangsong for report, and to mk for the patch git-svn-id: http://code.djangoproject.com/svn/django/trunk@16180 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-05-05Fixed #15823 - incorrect join condition when combining Q objectsLuke Plant
Thanks to dcwatson for the excellent report and patch. git-svn-id: http://code.djangoproject.com/svn/django/trunk@16159 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-05-03Fixed #5931 -- Added __repr__ to db fields. Thanks, Thomas Güttler, ↵Jannis Leidel
emulbreh and magopian. git-svn-id: http://code.djangoproject.com/svn/django/trunk@16145 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-05-03Fixed #5833 -- Modified the admin list filters to be easier to customize. ↵Jannis Leidel
Many thanks to Honza Král, Tom X. Tobin, gerdemb, eandre, sciyoshi, bendavis78 and Julien Phalip for working on this. git-svn-id: http://code.djangoproject.com/svn/django/trunk@16144 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-04-27Refs #15093 -- Fixed another get_models call missed in r16053. Thanks Luke ↵Carl Meyer
for catching it. git-svn-id: http://code.djangoproject.com/svn/django/trunk@16108 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-04-27Fixed #15903 -- Allowed not-installed models to still be referenced in ↵Carl Meyer
related fields. Missed case from r16053. git-svn-id: http://code.djangoproject.com/svn/django/trunk@16106 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-04-22Fixed #14729 -- RawQuerySet.__repr__ fails when params passed as list. ↵Jannis Leidel
Thanks, intgr for ticket and accuser for patch. git-svn-id: http://code.djangoproject.com/svn/django/trunk@16088 bcc190cf-cafb-0310-a4f2-bffc1f526a37