summaryrefslogtreecommitdiff
path: root/django/db/models/fields
AgeCommit message (Collapse)Author
2009-04-11Fixed BooleanFields being coerced null=True in Oracle.Ian Kelly
git-svn-id: http://code.djangoproject.com/svn/django/trunk@10505 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-04-10Fixed #9640, #10549: BooleanFields with choices, a default, and null=False ↵Jacob Kaplan-Moss
now correctly doesn't generate a blank option. git-svn-id: http://code.djangoproject.com/svn/django/trunk@10500 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-03-30Fixed #10149. FileFields in a form now validate max_length. Based on a patch ↵Joseph Kocherhans
by Massimo Scamarcia. git-svn-id: http://code.djangoproject.com/svn/django/trunk@10227 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-03-30Fixed #10413: RelatedManager.add no longer fails silenty when trying to add ↵Jacob Kaplan-Moss
an object of the wrong type. Thanks, dgouldin. git-svn-id: http://code.djangoproject.com/svn/django/trunk@10226 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-03-30Fixed #10157: correctly set the related objects pk when assigning a reverse ↵Jacob Kaplan-Moss
OneToOne. Thanks, dgouldin. git-svn-id: http://code.djangoproject.com/svn/django/trunk@10224 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-03-25Fixed a breakage with ManyToManyFields in admin caused by r10139.Malcolm Tredinnick
git-svn-id: http://code.djangoproject.com/svn/django/trunk@10170 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-03-20Fixed #2698 -- Fixed deleting in the presence of custom managers.Malcolm Tredinnick
A custom manager on a related object that filtered away objects would prevent those objects being deleted via the relation. This is now fixed. git-svn-id: http://code.djangoproject.com/svn/django/trunk@10104 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-03-10Fixed #10443 -- Fixed model attribute updating after r10003.Malcolm Tredinnick
Adding a get_db_prep_save() call to the UpdateQuery code path meant it was being called twice if you updated an existing model attribute. This change removes that double call and also makes TimeField.to_python() a little more robust for the benefit of the Oracle backend (just in case). git-svn-id: http://code.djangoproject.com/svn/django/trunk@10013 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-03-08Fixed #9508 -- Added an appropriate FileField.__hash__ implementation.Malcolm Tredinnick
Required because we declare a custom __eq__ method. git-svn-id: http://code.djangoproject.com/svn/django/trunk@9997 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-03-04Changed the handling of as_sql() versus _as_sql() in Query/QuerySet from r9928.Malcolm Tredinnick
This avoids inadvertently hiding AttributeError that is raised for other reasons. git-svn-id: http://code.djangoproject.com/svn/django/trunk@9965 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-03-01To avoid an unfortunately common user-error, rename QuerySet.as_sql().Malcolm Tredinnick
This was never a public API method, so this is backwards compatible, unless you're poking at the internals. Refs #10352. git-svn-id: http://code.djangoproject.com/svn/django/trunk@9928 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-02-24Fixed #10347 -- Fixed incorrect AttributeError raised when attempting to ↵Karen Tracey
access a FileField without an instance. Thanks for the report and patch dc. git-svn-id: http://code.djangoproject.com/svn/django/trunk@9902 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-02-16Fixed #10196: Restored setting of image file width and height fields lost in ↵Karen Tracey
r9766, and added tests for this function. Thanks to vicvicvic for the ticket and patch and for Alex for reminding me not to break non-PIL-boxes with the new tests. git-svn-id: http://code.djangoproject.com/svn/django/trunk@9841 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-02-16Fixed #10121: Restored code lost in r9766 that prevented overwriting an ↵Karen Tracey
already-set blank=True FileField with blank. This would happen, for instance, in the admin if an object with a FileField was edited/saved but the file not re-uploaded, resulting in the association to the previously-uploaded file being lost. Adding the ability to re-blank FileFields when they are once set is the subject of a different ticket (#7048), for now the pre-9766 behavior here has just been restored in order to avoid unexpected data loss. Thanks to Alex for help in understanding how to fix this without un-doing the intent of r9766. git-svn-id: http://code.djangoproject.com/svn/django/trunk@9840 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-02-08Fixed #7672 -- Added a 'week_day' lookup type. Many thanks to Ross Poulton ↵Karen Tracey
for the proposal and implementation on all built-in database backends.. git-svn-id: http://code.djangoproject.com/svn/django/trunk@9818 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-01-29Fixed #7210 -- Added F() expressions to query language. See the ↵Russell Keith-Magee
documentation for details on usage. Many thanks to: * Nicolas Lara, who worked on this feature during the 2008 Google Summer of Code. * Alex Gaynor for his help debugging and fixing a number of issues. * Malcolm Tredinnick for his invaluable review notes. git-svn-id: http://code.djangoproject.com/svn/django/trunk@9792 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-01-16Fixed #10044: You can now assign directly to file fields ↵Jacob Kaplan-Moss
(`instance.filefield = somefile`). Thanks, Marty Alchin. git-svn-id: http://code.djangoproject.com/svn/django/trunk@9766 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-01-03Fixed #9942 -- Added a to_python handler for FloatField to ensure correct ↵Russell Keith-Magee
typing of deserialized data before saving. Underlying problem is analogous to #8298, fixed in [8515]. Thanks to David Larlet <larlet@gmail.com> for the report and fix. git-svn-id: http://code.djangoproject.com/svn/django/trunk@9695 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-12-16Fixed #9786 -- Fixed inequality checking for ↵Malcolm Tredinnick
django.db.models.fields.file.FieldFile class. git-svn-id: http://code.djangoproject.com/svn/django/trunk@9647 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-12-11Removed django.db.models.options.Options.one_to_one_field.Malcolm Tredinnick
The last use of it was removed in r9641 (it's internal API) and it's been broken since r7477, as there's no longer a maximum of one OneToOneField per model, so anything relying on it contained subtle bugs. git-svn-id: http://code.djangoproject.com/svn/django/trunk@9643 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-12-02Fixed #8248: made help() work on models and improved introspection support.Luke Plant
Descriptors now return themselves when accessed via the class, as per standard Python descriptors like property(). git-svn-id: http://code.djangoproject.com/svn/django/trunk@9550 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-12-02Fixed a pair of bugs in determining the set of models to flush that were ↵Ian Kelly
causing test cause failures in Oracle after [9536]. git-svn-id: http://code.djangoproject.com/svn/django/trunk@9546 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-09-03Fixed #8669 -- Use a consistent version of create() across the board forMalcolm Tredinnick
model/field instance creation. Based on a patch from Richard Davies. git-svn-id: http://code.djangoproject.com/svn/django/trunk@8884 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-09-01Fixed #8648 -- Admin no longer ignores to_field. Thanks for the help Karen ↵Brian Rosner
Tracey and SmileyChris. git-svn-id: http://code.djangoproject.com/svn/django/trunk@8823 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-09-01Fixed #8210 and #8664: moved `USStateField` and `PhoneNumberField` to ↵Jacob Kaplan-Moss
`django.contrib.localflavor.us`. This is a backwards-incompatible change, albeit a minor one; just add an aditional `import` and go on your way. git-svn-id: http://code.djangoproject.com/svn/django/trunk@8819 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-09-01Fixed #7975 -- Callable defaults in inline model formsets now work ↵Brian Rosner
correctly. Based on patch from msaelices. Thanks for your hard work msaelices. git-svn-id: http://code.djangoproject.com/svn/django/trunk@8816 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-09-01Fixed #8076: fixed `get_(next/previous)_by_date` when used with subclasses. ↵Jacob Kaplan-Moss
Thanks, bjornkri and jan_oberst. git-svn-id: http://code.djangoproject.com/svn/django/trunk@8814 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-09-01Repaired an oversight from [8772] that let made certain types of fields with ↵Jacob Kaplan-Moss
choices fail. Fixes #6967 again. git-svn-id: http://code.djangoproject.com/svn/django/trunk@8806 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-09-01Fixed #8316 -- Put tighter restrictions on the type of Foreign Key fieldsMalcolm Tredinnick
created for MySQL (because MySQL + InnoDB has those restrictions). Patch from julianb. git-svn-id: http://code.djangoproject.com/svn/django/trunk@8782 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-08-31Fixed #6967: `ModelForm`s now validate choices. Thanks, mattmcc -- the ↵Jacob Kaplan-Moss
failing test helped quite a bit. git-svn-id: http://code.djangoproject.com/svn/django/trunk@8772 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-08-31Fixed handling of primary keys in model formsets. Model formsets should now ↵Brian Rosner
work nicely with custom primary keys that are OneToOneField, ForeignKey and AutoField. Added tests to handle each of them. Fixes #8241, #8694, #8695 and #8719. Thanks Karen Tracey, jonloyens, sciyoshi, semenov and magneto for tracking down various parts of this patch. git-svn-id: http://code.djangoproject.com/svn/django/trunk@8756 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-08-29Fixed a missing piece of [8721].Malcolm Tredinnick
git-svn-id: http://code.djangoproject.com/svn/django/trunk@8723 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-08-29Fixed #8279 -- Multiple many-to-many relations to "self" are now possible.Malcolm Tredinnick
git-svn-id: http://code.djangoproject.com/svn/django/trunk@8721 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-08-29Fixed #8101 -- Allow the strings '1' and '0' as filter values for booleanMalcolm Tredinnick
fields (the latter was causing problems). This allows these values in URLs (e.g. the admin filtering). Not an ideal solution to the problem, but will do the job for the time being. git-svn-id: http://code.djangoproject.com/svn/django/trunk@8691 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-08-29Fixed #7823 -- Fixed an edge case in RelatedField.get_db_prep_lookup() so thatMalcolm Tredinnick
it works correctly with custom field subclasses. Patch from Ivan Sagalaev. git-svn-id: http://code.djangoproject.com/svn/django/trunk@8690 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-08-28Fixed a bug in `NullBooleanField.to_python`.Jacob Kaplan-Moss
git-svn-id: http://code.djangoproject.com/svn/django/trunk@8684 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-08-28Fixed #8556: added a useful formfield to `CommaSeparatedIntegerField`. ↵Jacob Kaplan-Moss
gkelly, mattmcc, and kratorius all contributed portions of this patch. git-svn-id: http://code.djangoproject.com/svn/django/trunk@8682 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-08-28FIxed #8613: removed vestigal `FileField.save_file()`. Thanks, kratorius.Jacob Kaplan-Moss
git-svn-id: http://code.djangoproject.com/svn/django/trunk@8663 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-08-28Fixed #8597 -- Allow the use of strings containing underscores and percentageMalcolm Tredinnick
signs in "iexact" queries on PostgreSQL again (this case was missed in [8536]). git-svn-id: http://code.djangoproject.com/svn/django/trunk@8646 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-08-27Fixed #8534: getting the size of a file no longer opens it (at least for the ↵Jacob Kaplan-Moss
built-in file-system storage). Thanks, snaury. git-svn-id: http://code.djangoproject.com/svn/django/trunk@8638 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-08-27Fixed #8175: don't open files we're about to close. This was a pesky bug to ↵Jacob Kaplan-Moss
track down; thanks to charmless for tracking it down. git-svn-id: http://code.djangoproject.com/svn/django/trunk@8637 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-08-27Removed oldforms, validators, and related code:Gary Wilson Jr
* Removed `Manipulator`, `AutomaticManipulator`, and related classes. * Removed oldforms specific bits from model fields: * Removed `validator_list` and `core` arguments from constructors. * Removed the methods: * `get_manipulator_field_names` * `get_manipulator_field_objs` * `get_manipulator_fields` * `get_manipulator_new_data` * `prepare_field_objs_and_params` * `get_follow` * Renamed `flatten_data` method to `value_to_string` for better alignment with its use by the serialization framework, which was the only remaining code using `flatten_data`. * Removed oldforms methods from `django.db.models.Options` class: `get_followed_related_objects`, `get_data_holders`, `get_follow`, and `has_field_type`. * Removed oldforms-admin specific options from `django.db.models.fields.related` classes: `num_in_admin`, `min_num_in_admin`, `max_num_in_admin`, `num_extra_on_change`, and `edit_inline`. * Serialization framework * `Serializer.get_string_value` now calls the model fields' renamed `value_to_string` methods. * Removed a special-casing of `models.DateTimeField` in `core.serializers.base.Serializer.get_string_value` that's handled by `django.db.models.fields.DateTimeField.value_to_string`. * Removed `django.core.validators`: * Moved `ValidationError` exception to `django.core.exceptions`. * For the couple places that were using validators, brought over the necessary code to maintain the same functionality. * Introduced a SlugField form field for validation and to compliment the SlugField model field (refs #8040). * Removed an oldforms-style model creation hack (refs #2160). git-svn-id: http://code.djangoproject.com/svn/django/trunk@8616 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-08-26Removed trailing whitespace in a few files.Gary Wilson Jr
git-svn-id: http://code.djangoproject.com/svn/django/trunk@8571 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-08-25Fixed #7888 -- Handle model inheritance with model formsets correctly. ↵Brian Rosner
Thanks bpeschier for the report. git-svn-id: http://code.djangoproject.com/svn/django/trunk@8528 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-08-25Fixed #8510 -- Allow both strings (mostly for the admin) and integers to beMalcolm Tredinnick
used in "month" and "day" filters on date/datetime fields. Without this commit, SQLite behaved inconsistently after [8494]. git-svn-id: http://code.djangoproject.com/svn/django/trunk@8526 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-08-24Fixed #8298: Added a to_python method for integer fields. This ensures that ↵Russell Keith-Magee
the data from deserialized instances is of correct type prior to saving. Thanks to Andrew Badr for the report. git-svn-id: http://code.djangoproject.com/svn/django/trunk@8515 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-08-23Fixed #8040 -- SlugField now returns a proper formfield to deal with ↵Brian Rosner
validation. Thanks Daniel Pope for the ticket and patch. git-svn-id: http://code.djangoproject.com/svn/django/trunk@8477 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-08-22Fixed #8046 -- The first filter() call on a related manager for many-to-manyMalcolm Tredinnick
fields no longer creates duplicate copies of the join table(s). Basically, this means filters on the join table (for ManyToManyField(through=...)) and complex filters in the normal (non-through) case don't produce incorrect or duplicate results. git-svn-id: http://code.djangoproject.com/svn/django/trunk@8472 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-08-22Fixed #7947 -- Handle the display of OneToOneField in model forms correctly. ↵Brian Rosner
Thanks tyson for the report and original patch. git-svn-id: http://code.djangoproject.com/svn/django/trunk@8469 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-08-19Fixed #7908: Added validation checks on attempts to create ForeignKey and ↵Russell Keith-Magee
M2M relations with abstract classes. Thanks to Rock Howard for the report. git-svn-id: http://code.djangoproject.com/svn/django/trunk@8442 bcc190cf-cafb-0310-a4f2-bffc1f526a37