summaryrefslogtreecommitdiff
path: root/django/contrib/comments
AgeCommit message (Collapse)Author
2008-08-28Updated a few save() methods on models to accept force_insert and force_updateMalcolm Tredinnick
parameters. Required as a consequence of [8670] (so they can be used with create()). git-svn-id: http://code.djangoproject.com/svn/django/trunk@8673 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-08-27Fixed #8601: a small typo in comment views.Jacob Kaplan-Moss
git-svn-id: http://code.djangoproject.com/svn/django/trunk@8642 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-08-27Fixed #8544: correctly cast `Comment.object_pk` to string when doing ↵Jacob Kaplan-Moss
lookups. This really only papers over a bigger problem related to casting the RHS of GFKs, but that larger change can wait for a more systematic fix. git-svn-id: http://code.djangoproject.com/svn/django/trunk@8641 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-08-27Removed oldforms, validators, and related code:Gary Wilson Jr
* Removed `Manipulator`, `AutomaticManipulator`, and related classes. * Removed oldforms specific bits from model fields: * Removed `validator_list` and `core` arguments from constructors. * Removed the methods: * `get_manipulator_field_names` * `get_manipulator_field_objs` * `get_manipulator_fields` * `get_manipulator_new_data` * `prepare_field_objs_and_params` * `get_follow` * Renamed `flatten_data` method to `value_to_string` for better alignment with its use by the serialization framework, which was the only remaining code using `flatten_data`. * Removed oldforms methods from `django.db.models.Options` class: `get_followed_related_objects`, `get_data_holders`, `get_follow`, and `has_field_type`. * Removed oldforms-admin specific options from `django.db.models.fields.related` classes: `num_in_admin`, `min_num_in_admin`, `max_num_in_admin`, `num_extra_on_change`, and `edit_inline`. * Serialization framework * `Serializer.get_string_value` now calls the model fields' renamed `value_to_string` methods. * Removed a special-casing of `models.DateTimeField` in `core.serializers.base.Serializer.get_string_value` that's handled by `django.db.models.fields.DateTimeField.value_to_string`. * Removed `django.core.validators`: * Moved `ValidationError` exception to `django.core.exceptions`. * For the couple places that were using validators, brought over the necessary code to maintain the same functionality. * Introduced a SlugField form field for validation and to compliment the SlugField model field (refs #8040). * Removed an oldforms-style model creation hack (refs #2160). git-svn-id: http://code.djangoproject.com/svn/django/trunk@8616 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-08-27Fixed get_absolute_url() for comments. Previously, it relied on "view on site"Malcolm Tredinnick
for admin being reversible or required people to set up their own version. Now we ship a default pattern in the comments URLs in a way that is unlikely to clash with anything else. git-svn-id: http://code.djangoproject.com/svn/django/trunk@8614 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-08-26Updated comment signals to provide enough information to actually act on. ↵Jacob Kaplan-Moss
This was uncovered when working on the documentation, which'll be committed shortly. git-svn-id: http://code.djangoproject.com/svn/django/trunk@8589 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-08-26The comments app was unconditionally accessing various settings that didn'tMalcolm Tredinnick
exist in Django's global settings. Changed those accesses to conditional lookups with default fallbacks. The comment_test tests now pass without needing to add any extra settings. git-svn-id: http://code.djangoproject.com/svn/django/trunk@8573 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-08-25Refactored Django's comment system.Jacob Kaplan-Moss
Much of this work was done by Thejaswi Puthraya as part of Google's Summer of Code project; much thanks to him for the work, and to them for the program. This is a backwards-incompatible change; see the upgrading guide in docs/ref/contrib/comments/upgrade.txt for instructions if you were using the old comments system. git-svn-id: http://code.djangoproject.com/svn/django/trunk@8557 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-08-02Fixed #7919 -- md5 and sha modules are deprecated since Python 2.5, use ↵Gary Wilson Jr
hashlib module when available. Patch from Karen Tracey. git-svn-id: http://code.djangoproject.com/svn/django/trunk@8193 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-07-18Merged the newforms-admin branch into trunk.Brian Rosner
This is a backward incompatible change. The admin contrib app has been refactored. The newforms module has several improvements including FormSets and Media definitions. git-svn-id: http://code.djangoproject.com/svn/django/trunk@7967 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-01-28Fixed #6324 -- Fixed `get()` call in `UserFlagManager.flag()`.Gary Wilson Jr
git-svn-id: http://code.djangoproject.com/svn/django/trunk@7039 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-01-28Style fixes.Gary Wilson Jr
git-svn-id: http://code.djangoproject.com/svn/django/trunk@7038 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2007-11-29Fixed #5909 -- Made the various django.contrib.comment models more robust inMalcolm Tredinnick
the face of non-ASCII characters by giving them a __unicode__ method and letting the default __repr__ use that. Patches from prairiedogg and scompt. git-svn-id: http://code.djangoproject.com/svn/django/trunk@6742 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2007-10-19Fixed docstring style.Gary Wilson Jr
git-svn-id: http://code.djangoproject.com/svn/django/trunk@6529 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2007-09-21Fixed #3453: introduced a new template variable resolution system by Brian ↵Jacob Kaplan-Moss
Harring (thanks!). The upshot is that variable resolution is about 25% faster, and you should see a measurable performance increase any time you've got long or deeply nested loops. Variable resolution has changed behind the scenes -- see the note in templates_python.txt -- but template.resolve_variable() still exists. This should be fully backwards-compatible. git-svn-id: http://code.djangoproject.com/svn/django/trunk@6399 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2007-09-14Fixed #3091 -- django.contrib.comments views now accept extra_context and ↵Adrian Holovaty
context_processors arguments. Thanks, Eric Floehr and __hawkeye__ git-svn-id: http://code.djangoproject.com/svn/django/trunk@6236 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2007-08-11Fixed #4189 -- Fixed crashes in a couple of corner cases in the comments ↵Malcolm Tredinnick
app. Not a perfect fix (see ticket), but it will do as a holdover until the new comments framework is in place. git-svn-id: http://code.djangoproject.com/svn/django/trunk@5848 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2007-08-05Fixed #2101 -- Renamed `maxlength` argument to `max_length` for oldforms ↵Gary Wilson Jr
`FormField`s and db model `Field`s. This is fully backwards compatible at the moment since the legacy `maxlength` argument is still supported. Using `maxlength` will, however, issue a `PendingDeprecationWarning` when used. git-svn-id: http://code.djangoproject.com/svn/django/trunk@5803 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2007-07-16Fixed #4887 -- Fixed another place where template tag arguments are usedMalcolm Tredinnick
directly as function keyword args. Thanks, Brian Rosner. git-svn-id: http://code.djangoproject.com/svn/django/trunk@5715 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2007-07-04Merged Unicode branch into trunk (r4952:5608). This should be fullyMalcolm Tredinnick
backwards compatible for all practical purposes. Fixed #2391, #2489, #2996, #3322, #3344, #3370, #3406, #3432, #3454, #3492, #3582, #3690, #3878, #3891, #3937, #4039, #4141, #4227, #4286, #4291, #4300, #4452, #4702 git-svn-id: http://code.djangoproject.com/svn/django/trunk@5609 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2007-06-22Backed out the changes in [5482] for a bit whilst some more investigation intoMalcolm Tredinnick
side-effects is done. Refs #4565. git-svn-id: http://code.djangoproject.com/svn/django/trunk@5511 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2007-06-17Fixed #4565 -- Changed template rendering to use iterators, rather thanMalcolm Tredinnick
creating large strings, as much as possible. This is all backwards compatible. Thanks, Brian Harring. git-svn-id: http://code.djangoproject.com/svn/django/trunk@5482 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2007-06-01Fixed #4404 -- Fixed LatestCommentsFeed query problem. Thanks, SmileyChris.Malcolm Tredinnick
git-svn-id: http://code.djangoproject.com/svn/django/trunk@5408 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2007-04-26Fixed #4040 -- Changed uses of has_key() to "in". Slight performanceMalcolm Tredinnick
improvement and forward-compatible with future Python releases. Patch from Gary Wilson. git-svn-id: http://code.djangoproject.com/svn/django/trunk@5091 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2007-04-25Fixed #3185 -- Made values for login, logout and post-login redirect URLsMalcolm Tredinnick
configurable. This is a combined patch from Vasily Sulatskov, Marc Fargas and Collin Grady. git-svn-id: http://code.djangoproject.com/svn/django/trunk@5072 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2007-03-31Fixed #3473 -- Corrected access to get in manager (probably introduced as ↵Russell Keith-Magee
part of magic-removal conversion). git-svn-id: http://code.djangoproject.com/svn/django/trunk@4873 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2007-02-11Revert [4485] in order to fix accidental mod_python breakage. Refs #2920.Malcolm Tredinnick
git-svn-id: http://code.djangoproject.com/svn/django/trunk@4486 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2007-02-11Refs #2920 -- Replaced implicit uses of _() with explicit imports or calls ↵Russell Keith-Magee
to gettext(). At some point post 0.96, we need to remove the calls that put _ into the builtins. git-svn-id: http://code.djangoproject.com/svn/django/trunk@4485 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2006-12-15Copied django.forms to django.oldforms and changed all code to reference ↵Adrian Holovaty
django.oldforms instead of django.forms. Updated docs/forms.txt to add 'Forwards-compatibility' section that says you should not be using django.oldforms for any new projects. git-svn-id: http://code.djangoproject.com/svn/django/trunk@4208 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2006-11-07Fixed #2848: broken doctest in comment app. Thanks, dummy@habmalnefrage.deJacob Kaplan-Moss
git-svn-id: http://code.djangoproject.com/svn/django/trunk@4049 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2006-10-25Fixed ngettext bug in comments post viewJacob Kaplan-Moss
git-svn-id: http://code.djangoproject.com/svn/django/trunk@3936 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2006-10-24Fixed #2826 -- Added .is_authenticated() check before login() in comments viewsAdrian Holovaty
git-svn-id: http://code.djangoproject.com/svn/django/trunk@3929 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2006-07-21Part 3 of pedant day: replaced all tabs in Django with spaces. Python the ↵Jacob Kaplan-Moss
way Guido intended it, baby! git-svn-id: http://code.djangoproject.com/svn/django/trunk@3415 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2006-07-21Fixed bug in comment feed turned up by pyflakes.Jacob Kaplan-Moss
git-svn-id: http://code.djangoproject.com/svn/django/trunk@3413 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2006-07-21Fixed a bunch of spurious imports, typos, and other small errors turned up ↵Jacob Kaplan-Moss
by a pass through PyFlakes. This covers about the first third of the errors. git-svn-id: http://code.djangoproject.com/svn/django/trunk@3411 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2006-07-19Fixed #2332 -- Introduced is_authenticated() method on User and ↵Malcolm Tredinnick
AnonymousUser classes. Recommended its use over is_anonymous in the docs. Changed internal Django use to match this recommendation. Thanks to SmileyChris and Gary Wilson for the patch. git-svn-id: http://code.djangoproject.com/svn/django/trunk@3360 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2006-07-07Fixed #2283 -- Fixed XHTML-strict validation error in comment templatesAdrian Holovaty
git-svn-id: http://code.djangoproject.com/svn/django/trunk@3283 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2006-06-28Merged multi-auth branch to trunk. See the authentication docs for the ↵Jacob Kaplan-Moss
ramifications of this change. Many, many thanks to Joseph Kocherhans for the hard work! git-svn-id: http://code.djangoproject.com/svn/django/trunk@3226 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2006-06-26Fixed #2168 -- Made comment templates more accessibleAdrian Holovaty
git-svn-id: http://code.djangoproject.com/svn/django/trunk@3203 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2006-05-26Fixed #1981 -- Fixed bug in feeds.py for commentsAdrian Holovaty
git-svn-id: http://code.djangoproject.com/svn/django/trunk@2983 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2006-05-26Fixed #1997 -- Changed comments.py views to use relative URL for redirects. ↵Adrian Holovaty
Thanks, phil@produxion.net git-svn-id: http://code.djangoproject.com/svn/django/trunk@2981 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2006-05-05Fixed #1722 -- Fixed bug in CommentManager.user_is_moderator(). Thanks, Jure ↵Adrian Holovaty
Cuhalev git-svn-id: http://code.djangoproject.com/svn/django/trunk@2848 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2006-05-03Fixed #1740 -- django.contrib.comments no longer uses old-style DB API ↵Jacob Kaplan-Moss
(thanks, ubernostrum) git-svn-id: http://code.djangoproject.com/svn/django/trunk@2823 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2006-05-02MERGED MAGIC-REMOVAL BRANCH TO TRUNK. This change is highly ↵Adrian Holovaty
backwards-incompatible. Please read http://code.djangoproject.com/wiki/RemovingTheMagic for upgrade instructions. git-svn-id: http://code.djangoproject.com/svn/django/trunk@2809 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2006-02-02Removed use of deprecated template_loader from [2230]Adrian Holovaty
git-svn-id: http://code.djangoproject.com/svn/django/trunk@2233 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2006-02-02fixed #1287 - comment forms are now translateable and overrideableGeorg Bauer
git-svn-id: http://code.djangoproject.com/svn/django/trunk@2230 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2005-11-26Fixed #911 -- Made template system scoped to the parser instead of the ↵Adrian Holovaty
template module. Also changed the way tags/filters are registered and added support for multiple arguments to {% load %} tag. Thanks, rjwittams. This is a backwards-incompatible change for people who've created custom template tags or filters. See http://code.djangoproject.com/wiki/BackwardsIncompatibleChanges for upgrade instructions. git-svn-id: http://code.djangoproject.com/svn/django/trunk@1443 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2005-11-23Fixed missing {% load i18n %} tag in comments FREE_COMMENT_FORM templateAdrian Holovaty
git-svn-id: http://code.djangoproject.com/svn/django/trunk@1378 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2005-11-23Added translation strings to django.contrib.comments. Taken from new-admin.Adrian Holovaty
git-svn-id: http://code.djangoproject.com/svn/django/trunk@1364 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2005-11-18Added feed configurations for django.contrib.commentsJacob Kaplan-Moss
git-svn-id: http://code.djangoproject.com/svn/django/trunk@1281 bcc190cf-cafb-0310-a4f2-bffc1f526a37