summaryrefslogtreecommitdiff
path: root/django/contrib/comments
AgeCommit message (Collapse)Author
2010-09-14Fixed #2283 (again) - comment form templates don't validate as XHTMLLuke Plant
Thanks to hjoreteg/thejaswi_puthraya for the report and patch. git-svn-id: http://code.djangoproject.com/svn/django/trunk@13855 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-03-16Changed the comments post view code to avoid raising an exception if handed ↵Karen Tracey
invalid data for the object pk. Thanks to Leo for the test. git-svn-id: http://code.djangoproject.com/svn/django/trunk@12800 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-03-12Fixed #12940 -- Modified some admin actions in contrib.comments to use ↵Russell Keith-Magee
ungettext in order to support Russian (and similar) pluralization rules. Thanks to void for the report and patch. git-svn-id: http://code.djangoproject.com/svn/django/trunk@12770 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-03-05Fixed #12151: Ensured the comments code does not cause a server error when a ↵Karen Tracey
request comes in for a comment specifying an invalid primary key value. Thanks thejaswi_puthraya. git-svn-id: http://code.djangoproject.com/svn/django/trunk@12681 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-03-01Fixed #10878, an error in the `Moderator` docstring.Jacob Kaplan-Moss
Thanks, Travis Cline. git-svn-id: http://code.djangoproject.com/svn/django/trunk@12639 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-01-28Fixed #6188, #6304, #6618, #6969, #8758, #8989, #10334, #11069, #11973 and ↵Russell Keith-Magee
#12403 -- Modified the syndication framework to use class-based views. Thanks to Ben Firshman for his work on this patch. git-svn-id: http://code.djangoproject.com/svn/django/trunk@12338 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-01-28Fixed #12600 -- Added some extra search paths for comment preview templates, ↵Russell Keith-Magee
allowing for naming parity with other templates in comments and admin. Thanks to hvdklauw for the report. git-svn-id: http://code.djangoproject.com/svn/django/trunk@12337 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-01-04Fixed #12053 - form examples don't validate according to w3cLuke Plant
Thanks to skyl for the report. git-svn-id: http://code.djangoproject.com/svn/django/trunk@12086 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-01-04Fixed #10285 - Added render_comment_list template tag to comments app. ↵Jannis Leidel
Thanks Kyle Fuller for the patch. git-svn-id: http://code.djangoproject.com/svn/django/trunk@12082 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-01-04Fixed #11100 - Added get_comment_permalink template tag to comments app to ↵Jannis Leidel
be able to customize the anchor pattern of a comment from the template. Thanks to Idan Gazit for the patch. git-svn-id: http://code.djangoproject.com/svn/django/trunk@12080 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-12-22Fixed #1142 -- Added multiple database support.Russell Keith-Magee
This monster of a patch is the result of Alex Gaynor's 2009 Google Summer of Code project. Congratulations to Alex for a job well done. Big thanks also go to: * Justin Bronn for keeping GIS in line with the changes, * Karen Tracey and Jani Tiainen for their help testing Oracle support * Brett Hoerner, Jon Loyens, and Craig Kimmerer for their feedback. * Malcolm Treddinick for his guidance during the GSoC submission process. * Simon Willison for driving the original design process * Cal Henderson for complaining about ponies he wanted. ... and everyone else too numerous to mention that helped to bring this feature into fruition. git-svn-id: http://code.djangoproject.com/svn/django/trunk@11952 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-10-27Moved contrib.csrf.* to core code.Luke Plant
There is stub code for backwards compatiblity with Django 1.1 imports. The documentation has been updated, but has been left in docs/contrib/csrf.txt for now, in order to avoid dead links to documentation on the website. git-svn-id: http://code.djangoproject.com/svn/django/trunk@11661 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-10-26Fixed #9977 - CsrfMiddleware gets template tag added, session dependency ↵Luke Plant
removed, and turned on by default. This is a large change to CSRF protection for Django. It includes: * removing the dependency on the session framework. * deprecating CsrfResponseMiddleware, and replacing with a core template tag. * turning on CSRF protection by default by adding CsrfViewMiddleware to the default value of MIDDLEWARE_CLASSES. * protecting all contrib apps (whatever is in settings.py) using a decorator. For existing users of the CSRF functionality, it should be a seamless update, but please note that it includes DEPRECATION of features in Django 1.1, and there are upgrade steps which are detailed in the docs. Many thanks to 'Glenn' and 'bthomas', who did a lot of the thinking and work on the patch, and to lots of other people including Simon Willison and Russell Keith-Magee who refined the ideas. Details of the rationale for these changes is found here: http://code.djangoproject.com/wiki/CsrfProtection As of this commit, the CSRF code is mainly in 'contrib'. The code will be moved to core in a separate commit, to make the changeset as readable as possible. git-svn-id: http://code.djangoproject.com/svn/django/trunk@11660 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-10-23Fixed #11625: added comment moderation via admin actions.Jacob Kaplan-Moss
This is BACKWARDS INCOMPATIBLE if you were using the completely undocumented moderation view from 1.1. That view's been removed in favor of the admin actions. Thanks, Thejaswi Puthraya. git-svn-id: http://code.djangoproject.com/svn/django/trunk@11639 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-10-08Fixed #11995 -- Modified the admin site definition for comments so that ↵Russell Keith-Magee
users are shown as a raw id list. Thanks to James Bennett for the report and patch. git-svn-id: http://code.djangoproject.com/svn/django/trunk@11601 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-06-17Fixed #9268 -- Ensured that the next argument is passed on when previewing ↵Russell Keith-Magee
comments. Thanks to leanmeandonothingmachine for the patch. git-svn-id: http://code.djangoproject.com/svn/django/trunk@11019 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-05-14Fixed #11113: fixed a couple of issues that slipped through the cracks when ↵Jacob Kaplan-Moss
comment moderation was added to `django.contrib.comments`. The is a potentially backwards-incompatible change for users already relying on the internals of comment moderaration. To wit: * The moderation system now listens to the new `comment_will_be_posted`/`comment_was_posted` signals instead of `pre/post_save`. This means that import request-based information is available to moderation as it should be. * Some experimental code from `django.contrib.comments.moderation` has been removed. It was never intended to be merged into Django, and was completely untested and likely buggy. git-svn-id: http://code.djangoproject.com/svn/django/trunk@10784 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-04-07Fixed #10169: don't accidentally try to redirect to "None" after posting a ↵Jacob Kaplan-Moss
comment. git-svn-id: http://code.djangoproject.com/svn/django/trunk@10429 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-04-07Fixed #10633, #10691: marked strings in the comments app for translation. ↵Jacob Kaplan-Moss
Thanks, zgoda. git-svn-id: http://code.djangoproject.com/svn/django/trunk@10427 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-04-07Fixed #10585: comment redirects built from the `next` parameter now work ↵Jacob Kaplan-Moss
correctly when `next` already contains a query string. git-svn-id: http://code.djangoproject.com/svn/django/trunk@10424 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-04-07Fixed #9956: relax the URL pattern for primary keys in the comment redirect ↵Jacob Kaplan-Moss
so that models with custom PKs aren't cut out of the loop. git-svn-id: http://code.djangoproject.com/svn/django/trunk@10422 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-04-07Fixed #9792: corrected invalid HTML in the comment form and comment preview.Jacob Kaplan-Moss
git-svn-id: http://code.djangoproject.com/svn/django/trunk@10420 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-04-07Fixed #9268: pass the "next" param through in the comment preview/post view. ↵Jacob Kaplan-Moss
Also updated the docs to make this a bit clearer. git-svn-id: http://code.djangoproject.com/svn/django/trunk@10418 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-03-23Fixed #9282: added a generic comment moderation toolkit. See the ↵Jacob Kaplan-Moss
documentation for details. This began life as (part of) James Bennett's comment-utils app, and was adapted to be part of Django by Thejaswi Puthraya and Jannis Leidel. Thanks, all! git-svn-id: http://code.djangoproject.com/svn/django/trunk@10122 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-03-21Fixed #9958: split the `CommentForm` into a set of smaller forms. This for ↵Jacob Kaplan-Moss
better encapsulation, but also so that it's easier for subclasses to get at the pieces they might need. Thanks to Thejaswi Puthraya. git-svn-id: http://code.djangoproject.com/svn/django/trunk@10110 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-03-21Fixed #9303 (again) by removing some code missing in [9891].Jacob Kaplan-Moss
git-svn-id: http://code.djangoproject.com/svn/django/trunk@10109 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-03-18Fixed #8193: all dynamic imports in Django are now done correctly. I know ↵Jacob Kaplan-Moss
this because Brett Cannon borrowed the time machine and brought Python 2.7's '`importlib` back for inclusion in Django. Thanks for the patch-from-the-future, Brett! git-svn-id: http://code.djangoproject.com/svn/django/trunk@10088 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-02-23Fixed #9303: comment templatetags no longer assume the built-in comment model.Jacob Kaplan-Moss
git-svn-id: http://code.djangoproject.com/svn/django/trunk@9891 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-02-23Fixed #8630: finished the custom comment app API that was left out of 1.0. ↵Jacob Kaplan-Moss
This means it's now possible to override any of the models, forms, or views used by the comment app; see the new custom comment app docs for details and an example. Thanks to Thejaswi Puthraya for the original patch, and to carljm for docs and tests. git-svn-id: http://code.djangoproject.com/svn/django/trunk@9890 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-02-23Refactored CommentForm.get_comment_object into a handful of separete methods ↵Jacob Kaplan-Moss
to make it easier for subclasses to provide custom models and data. Refs #8630. git-svn-id: http://code.djangoproject.com/svn/django/trunk@9889 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-01-12A few small fixes to django.contrib.comments (Comment.get_as_text for ↵Jacob Kaplan-Moss
non-authenticated users; references to Comment.permalink; unused imports). Fixes #9143, #9429, and 9439. Thanks, Thejaswi Puthraya. git-svn-id: http://code.djangoproject.com/svn/django/trunk@9730 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-10-05Fixed #8963 -- Use the require_POST decorator instead of doing things ↵Malcolm Tredinnick
manually in one of the comment views. Thanks, zgoda. git-svn-id: http://code.djangoproject.com/svn/django/trunk@9121 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-10-05Fixed #9100 -- Added a missing CSS class to a submit button.Malcolm Tredinnick
Thanks, mordyovits and thejaswi_puthraya. git-svn-id: http://code.djangoproject.com/svn/django/trunk@9120 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-10-05Add internationalisation support to the comment templates. Fixed #8868, #8905Malcolm Tredinnick
Thanks to zgoda for a patch that did most of the internationalisation part. git-svn-id: http://code.djangoproject.com/svn/django/trunk@9119 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-10-05Fixed #8803 -- Allow authenticated users without first_name/last_name values ↵Malcolm Tredinnick
set to post comments. git-svn-id: http://code.djangoproject.com/svn/django/trunk@9118 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-10-05Fixed #8869 -- Fixed comments templates to be well-formed XHTML.Malcolm Tredinnick
Based on a patch from zgoda. git-svn-id: http://code.djangoproject.com/svn/django/trunk@9117 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-10-05Fixed #8879 -- Used ungettext instead of ngettext in the comments framework.Malcolm Tredinnick
Patch from zgoda. git-svn-id: http://code.djangoproject.com/svn/django/trunk@9116 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-10-05Fixed #9141 -- Removed two templates from django.contrib.comments that were ↵Malcolm Tredinnick
not being used. git-svn-id: http://code.djangoproject.com/svn/django/trunk@9115 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-09-28Use correct m2m join table name in LatestCommentsFeedJames Bennett
git-svn-id: http://code.djangoproject.com/svn/django/trunk@9089 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-09-28Fixed #9203: Restore correct ordering for LatestCommentsFeedJames Bennett
git-svn-id: http://code.djangoproject.com/svn/django/trunk@9088 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-09-16Fixed #8870 -- Changed django.contrib.comments templates to use lowercase ↵Adrian Holovaty
'post' for <form method> attributes, to be consistent with our other templates. Thanks, zgoda git-svn-id: http://code.djangoproject.com/svn/django/trunk@9050 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-09-16Fixed #8917 -- Comments are now displayed in reverse order by submit_date in ↵Wilson Miner
the admin. Thanks to arien for the patch. git-svn-id: http://code.djangoproject.com/svn/django/trunk@9038 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-09-10Fixed #8959 -- Removed redundant calls to the 'escape' template filter in ↵Adrian Holovaty
the django.contrib.comments templates. Thanks, zgoda git-svn-id: http://code.djangoproject.com/svn/django/trunk@9000 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-09-03Fixed two XHTML errors pointed out by Jarek Zgoda. Refs #8855.Malcolm Tredinnick
git-svn-id: http://code.djangoproject.com/svn/django/trunk@8958 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-09-03Fixed #8614 -- Typo fix.Malcolm Tredinnick
git-svn-id: http://code.djangoproject.com/svn/django/trunk@8933 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-09-02Avoid a deprecation warning when running on Python 2.6. Patch from Karen Tracey.Malcolm Tredinnick
git-svn-id: http://code.djangoproject.com/svn/django/trunk@8841 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-09-01Added a related name to the ForeignKey in the abstract base class of theMalcolm Tredinnick
comment models. You'll never need to use this name, but it will lead to invalid models if not present. git-svn-id: http://code.djangoproject.com/svn/django/trunk@8803 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-09-01Make sure to use force_unicode when looking up comment objects by ↵Jacob Kaplan-Moss
`object_pk`. Fixes #8762, and one other bug that nobody's reported yet. git-svn-id: http://code.djangoproject.com/svn/django/trunk@8800 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-08-30Fixed #8716: correctly handle name and email in comments from authenticated ↵Jacob Kaplan-Moss
users. git-svn-id: http://code.djangoproject.com/svn/django/trunk@8751 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-08-28Fixed #8608: corrected doc link in comment 400 error page.Jacob Kaplan-Moss
git-svn-id: http://code.djangoproject.com/svn/django/trunk@8677 bcc190cf-cafb-0310-a4f2-bffc1f526a37