summaryrefslogtreecommitdiff
path: root/django/contrib/comments
AgeCommit message (Collapse)Author
2008-10-05Fixed #8963 -- Use the require_POST decorator instead of doing things ↵Malcolm Tredinnick
manually in one of the comment views. Thanks, zgoda. git-svn-id: http://code.djangoproject.com/svn/django/trunk@9121 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-10-05Fixed #9100 -- Added a missing CSS class to a submit button.Malcolm Tredinnick
Thanks, mordyovits and thejaswi_puthraya. git-svn-id: http://code.djangoproject.com/svn/django/trunk@9120 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-10-05Add internationalisation support to the comment templates. Fixed #8868, #8905Malcolm Tredinnick
Thanks to zgoda for a patch that did most of the internationalisation part. git-svn-id: http://code.djangoproject.com/svn/django/trunk@9119 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-10-05Fixed #8803 -- Allow authenticated users without first_name/last_name values ↵Malcolm Tredinnick
set to post comments. git-svn-id: http://code.djangoproject.com/svn/django/trunk@9118 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-10-05Fixed #8869 -- Fixed comments templates to be well-formed XHTML.Malcolm Tredinnick
Based on a patch from zgoda. git-svn-id: http://code.djangoproject.com/svn/django/trunk@9117 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-10-05Fixed #8879 -- Used ungettext instead of ngettext in the comments framework.Malcolm Tredinnick
Patch from zgoda. git-svn-id: http://code.djangoproject.com/svn/django/trunk@9116 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-10-05Fixed #9141 -- Removed two templates from django.contrib.comments that were ↵Malcolm Tredinnick
not being used. git-svn-id: http://code.djangoproject.com/svn/django/trunk@9115 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-09-28Use correct m2m join table name in LatestCommentsFeedJames Bennett
git-svn-id: http://code.djangoproject.com/svn/django/trunk@9089 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-09-28Fixed #9203: Restore correct ordering for LatestCommentsFeedJames Bennett
git-svn-id: http://code.djangoproject.com/svn/django/trunk@9088 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-09-16Fixed #8870 -- Changed django.contrib.comments templates to use lowercase ↵Adrian Holovaty
'post' for <form method> attributes, to be consistent with our other templates. Thanks, zgoda git-svn-id: http://code.djangoproject.com/svn/django/trunk@9050 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-09-16Fixed #8917 -- Comments are now displayed in reverse order by submit_date in ↵Wilson Miner
the admin. Thanks to arien for the patch. git-svn-id: http://code.djangoproject.com/svn/django/trunk@9038 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-09-10Fixed #8959 -- Removed redundant calls to the 'escape' template filter in ↵Adrian Holovaty
the django.contrib.comments templates. Thanks, zgoda git-svn-id: http://code.djangoproject.com/svn/django/trunk@9000 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-09-03Fixed two XHTML errors pointed out by Jarek Zgoda. Refs #8855.Malcolm Tredinnick
git-svn-id: http://code.djangoproject.com/svn/django/trunk@8958 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-09-03Fixed #8614 -- Typo fix.Malcolm Tredinnick
git-svn-id: http://code.djangoproject.com/svn/django/trunk@8933 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-09-02Avoid a deprecation warning when running on Python 2.6. Patch from Karen Tracey.Malcolm Tredinnick
git-svn-id: http://code.djangoproject.com/svn/django/trunk@8841 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-09-01Added a related name to the ForeignKey in the abstract base class of theMalcolm Tredinnick
comment models. You'll never need to use this name, but it will lead to invalid models if not present. git-svn-id: http://code.djangoproject.com/svn/django/trunk@8803 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-09-01Make sure to use force_unicode when looking up comment objects by ↵Jacob Kaplan-Moss
`object_pk`. Fixes #8762, and one other bug that nobody's reported yet. git-svn-id: http://code.djangoproject.com/svn/django/trunk@8800 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-08-30Fixed #8716: correctly handle name and email in comments from authenticated ↵Jacob Kaplan-Moss
users. git-svn-id: http://code.djangoproject.com/svn/django/trunk@8751 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-08-28Fixed #8608: corrected doc link in comment 400 error page.Jacob Kaplan-Moss
git-svn-id: http://code.djangoproject.com/svn/django/trunk@8677 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-08-28Updated a few save() methods on models to accept force_insert and force_updateMalcolm Tredinnick
parameters. Required as a consequence of [8670] (so they can be used with create()). git-svn-id: http://code.djangoproject.com/svn/django/trunk@8673 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-08-27Fixed #8601: a small typo in comment views.Jacob Kaplan-Moss
git-svn-id: http://code.djangoproject.com/svn/django/trunk@8642 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-08-27Fixed #8544: correctly cast `Comment.object_pk` to string when doing ↵Jacob Kaplan-Moss
lookups. This really only papers over a bigger problem related to casting the RHS of GFKs, but that larger change can wait for a more systematic fix. git-svn-id: http://code.djangoproject.com/svn/django/trunk@8641 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-08-27Removed oldforms, validators, and related code:Gary Wilson Jr
* Removed `Manipulator`, `AutomaticManipulator`, and related classes. * Removed oldforms specific bits from model fields: * Removed `validator_list` and `core` arguments from constructors. * Removed the methods: * `get_manipulator_field_names` * `get_manipulator_field_objs` * `get_manipulator_fields` * `get_manipulator_new_data` * `prepare_field_objs_and_params` * `get_follow` * Renamed `flatten_data` method to `value_to_string` for better alignment with its use by the serialization framework, which was the only remaining code using `flatten_data`. * Removed oldforms methods from `django.db.models.Options` class: `get_followed_related_objects`, `get_data_holders`, `get_follow`, and `has_field_type`. * Removed oldforms-admin specific options from `django.db.models.fields.related` classes: `num_in_admin`, `min_num_in_admin`, `max_num_in_admin`, `num_extra_on_change`, and `edit_inline`. * Serialization framework * `Serializer.get_string_value` now calls the model fields' renamed `value_to_string` methods. * Removed a special-casing of `models.DateTimeField` in `core.serializers.base.Serializer.get_string_value` that's handled by `django.db.models.fields.DateTimeField.value_to_string`. * Removed `django.core.validators`: * Moved `ValidationError` exception to `django.core.exceptions`. * For the couple places that were using validators, brought over the necessary code to maintain the same functionality. * Introduced a SlugField form field for validation and to compliment the SlugField model field (refs #8040). * Removed an oldforms-style model creation hack (refs #2160). git-svn-id: http://code.djangoproject.com/svn/django/trunk@8616 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-08-27Fixed get_absolute_url() for comments. Previously, it relied on "view on site"Malcolm Tredinnick
for admin being reversible or required people to set up their own version. Now we ship a default pattern in the comments URLs in a way that is unlikely to clash with anything else. git-svn-id: http://code.djangoproject.com/svn/django/trunk@8614 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-08-26Updated comment signals to provide enough information to actually act on. ↵Jacob Kaplan-Moss
This was uncovered when working on the documentation, which'll be committed shortly. git-svn-id: http://code.djangoproject.com/svn/django/trunk@8589 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-08-26The comments app was unconditionally accessing various settings that didn'tMalcolm Tredinnick
exist in Django's global settings. Changed those accesses to conditional lookups with default fallbacks. The comment_test tests now pass without needing to add any extra settings. git-svn-id: http://code.djangoproject.com/svn/django/trunk@8573 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-08-25Refactored Django's comment system.Jacob Kaplan-Moss
Much of this work was done by Thejaswi Puthraya as part of Google's Summer of Code project; much thanks to him for the work, and to them for the program. This is a backwards-incompatible change; see the upgrading guide in docs/ref/contrib/comments/upgrade.txt for instructions if you were using the old comments system. git-svn-id: http://code.djangoproject.com/svn/django/trunk@8557 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-08-02Fixed #7919 -- md5 and sha modules are deprecated since Python 2.5, use ↵Gary Wilson Jr
hashlib module when available. Patch from Karen Tracey. git-svn-id: http://code.djangoproject.com/svn/django/trunk@8193 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-07-18Merged the newforms-admin branch into trunk.Brian Rosner
This is a backward incompatible change. The admin contrib app has been refactored. The newforms module has several improvements including FormSets and Media definitions. git-svn-id: http://code.djangoproject.com/svn/django/trunk@7967 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-01-28Fixed #6324 -- Fixed `get()` call in `UserFlagManager.flag()`.Gary Wilson Jr
git-svn-id: http://code.djangoproject.com/svn/django/trunk@7039 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-01-28Style fixes.Gary Wilson Jr
git-svn-id: http://code.djangoproject.com/svn/django/trunk@7038 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2007-11-29Fixed #5909 -- Made the various django.contrib.comment models more robust inMalcolm Tredinnick
the face of non-ASCII characters by giving them a __unicode__ method and letting the default __repr__ use that. Patches from prairiedogg and scompt. git-svn-id: http://code.djangoproject.com/svn/django/trunk@6742 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2007-10-19Fixed docstring style.Gary Wilson Jr
git-svn-id: http://code.djangoproject.com/svn/django/trunk@6529 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2007-09-21Fixed #3453: introduced a new template variable resolution system by Brian ↵Jacob Kaplan-Moss
Harring (thanks!). The upshot is that variable resolution is about 25% faster, and you should see a measurable performance increase any time you've got long or deeply nested loops. Variable resolution has changed behind the scenes -- see the note in templates_python.txt -- but template.resolve_variable() still exists. This should be fully backwards-compatible. git-svn-id: http://code.djangoproject.com/svn/django/trunk@6399 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2007-09-14Fixed #3091 -- django.contrib.comments views now accept extra_context and ↵Adrian Holovaty
context_processors arguments. Thanks, Eric Floehr and __hawkeye__ git-svn-id: http://code.djangoproject.com/svn/django/trunk@6236 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2007-08-11Fixed #4189 -- Fixed crashes in a couple of corner cases in the comments ↵Malcolm Tredinnick
app. Not a perfect fix (see ticket), but it will do as a holdover until the new comments framework is in place. git-svn-id: http://code.djangoproject.com/svn/django/trunk@5848 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2007-08-05Fixed #2101 -- Renamed `maxlength` argument to `max_length` for oldforms ↵Gary Wilson Jr
`FormField`s and db model `Field`s. This is fully backwards compatible at the moment since the legacy `maxlength` argument is still supported. Using `maxlength` will, however, issue a `PendingDeprecationWarning` when used. git-svn-id: http://code.djangoproject.com/svn/django/trunk@5803 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2007-07-16Fixed #4887 -- Fixed another place where template tag arguments are usedMalcolm Tredinnick
directly as function keyword args. Thanks, Brian Rosner. git-svn-id: http://code.djangoproject.com/svn/django/trunk@5715 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2007-07-04Merged Unicode branch into trunk (r4952:5608). This should be fullyMalcolm Tredinnick
backwards compatible for all practical purposes. Fixed #2391, #2489, #2996, #3322, #3344, #3370, #3406, #3432, #3454, #3492, #3582, #3690, #3878, #3891, #3937, #4039, #4141, #4227, #4286, #4291, #4300, #4452, #4702 git-svn-id: http://code.djangoproject.com/svn/django/trunk@5609 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2007-06-22Backed out the changes in [5482] for a bit whilst some more investigation intoMalcolm Tredinnick
side-effects is done. Refs #4565. git-svn-id: http://code.djangoproject.com/svn/django/trunk@5511 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2007-06-17Fixed #4565 -- Changed template rendering to use iterators, rather thanMalcolm Tredinnick
creating large strings, as much as possible. This is all backwards compatible. Thanks, Brian Harring. git-svn-id: http://code.djangoproject.com/svn/django/trunk@5482 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2007-06-01Fixed #4404 -- Fixed LatestCommentsFeed query problem. Thanks, SmileyChris.Malcolm Tredinnick
git-svn-id: http://code.djangoproject.com/svn/django/trunk@5408 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2007-04-26Fixed #4040 -- Changed uses of has_key() to "in". Slight performanceMalcolm Tredinnick
improvement and forward-compatible with future Python releases. Patch from Gary Wilson. git-svn-id: http://code.djangoproject.com/svn/django/trunk@5091 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2007-04-25Fixed #3185 -- Made values for login, logout and post-login redirect URLsMalcolm Tredinnick
configurable. This is a combined patch from Vasily Sulatskov, Marc Fargas and Collin Grady. git-svn-id: http://code.djangoproject.com/svn/django/trunk@5072 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2007-03-31Fixed #3473 -- Corrected access to get in manager (probably introduced as ↵Russell Keith-Magee
part of magic-removal conversion). git-svn-id: http://code.djangoproject.com/svn/django/trunk@4873 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2007-02-11Revert [4485] in order to fix accidental mod_python breakage. Refs #2920.Malcolm Tredinnick
git-svn-id: http://code.djangoproject.com/svn/django/trunk@4486 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2007-02-11Refs #2920 -- Replaced implicit uses of _() with explicit imports or calls ↵Russell Keith-Magee
to gettext(). At some point post 0.96, we need to remove the calls that put _ into the builtins. git-svn-id: http://code.djangoproject.com/svn/django/trunk@4485 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2006-12-15Copied django.forms to django.oldforms and changed all code to reference ↵Adrian Holovaty
django.oldforms instead of django.forms. Updated docs/forms.txt to add 'Forwards-compatibility' section that says you should not be using django.oldforms for any new projects. git-svn-id: http://code.djangoproject.com/svn/django/trunk@4208 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2006-11-07Fixed #2848: broken doctest in comment app. Thanks, dummy@habmalnefrage.deJacob Kaplan-Moss
git-svn-id: http://code.djangoproject.com/svn/django/trunk@4049 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2006-10-25Fixed ngettext bug in comments post viewJacob Kaplan-Moss
git-svn-id: http://code.djangoproject.com/svn/django/trunk@3936 bcc190cf-cafb-0310-a4f2-bffc1f526a37
generated by cgit v1.3 (git 2.53.0) at 2026-09-01 16:08:11 +0000