| Age | Commit message (Collapse) | Author |
|
|
|
With Python 2.7 and up, named parameter keys are not limited to
bytestrings any longer. This mainly reverts 3bd384aa626.
|
|
|
|
ModelAdmin.add_view formset validation.
Updated ModelAdmin to use form.instance when passing parent model to
child inlines for add_view. There is effectively no change in the
change_view since the previously passed 'obj' is the same as form.instance.
Thanks to meshy for report, and EvilDMP and timo for review.
|
|
Thanks to trac user parsch for the report.
|
|
Thanks guido@20tab.com for the report and Tim Graham for the
analyze.
|
|
|
|
Report, analysis and tests from stephenmcd.
|
|
ModelAdmin displayed the "View on site" link even if the Model didn't
define the `get_absolute_url()` method.
|
|
Reviewed by Chris Medrela.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
``ModelAdmin.view_on_site`` defines wether to show a link to the object on the
admin detail page. If ``True``, cleverness (i.e. ``Model.get_absolute_url``) is
used to get the url. If it's a callable, the callable is called with the object
as the only parameter. If ``False``, not link is displayed.
With the aim of maitaining backwards compatibility, ``True`` is the default.
|
|
|
|
Added a refresh() before quit() in the selenium tests, since this
solves the problem of spurious test failures in some environments.
|
|
Previously there was a mixture of the two which resulted in inconsistent
casing.
|
|
|
|
|
|
Thanks to flake8 path/to/file.py | awk -F ' ' '{ print $5 }' | sort | uniq
|
|
|
|
|
|
|
|
|
|
Thanks Aymeric Augustin for the suggestion.
|
|
|
|
refs #21220.
|
|
|
|
* Removed trailing whitespace.
* Added newline to EOF if missing.
* Removed blank lines at EOF.
* Removed some stray tabs.
|
|
|
|
* header selected twice -merged
* match indentation throughout
* color names to hex
refs #21220.
|
|
refs #21220.
|
|
This reverts commit 698dd82eee1cb83f51d4cd39546461bf76976b5e.
The patch introduced a backward incompatible change.
|
|
Refs #13749 and #21220.
|
|
|
|
Thanks hvdklauw for the report and patch.
|
|
Thanks bartTC for the report.
|
|
SimpleListFilter) syntax.
Thanks gauss for the report.
|
|
exception.
Thanks Tuttle for the report.
|
|
list links.
Thanks rm_ for the suggestion.
|
|
list_filter.
Thanks to onlygoldi2201 for the report and to ramiro and apollo13
for the reviews.
|
|
Thanks stanislas.guerra at gmail.com for the report.
|
|
Thanks Alexey Boriskin for the report.
|
|
Thanks stavros for the suggestion.
|
|
Ensure that selenium quits before the live server thread to
prevent occasional hangs when killing the live server.
|
|
tearDownClass is not called if setUpClass throws an exception, in our case
this means that LiveServerTestCase leaks LiveServerThread sockets if the
test happens to be skipped later on, and AdminSeleniumWebDriverTestCase
doesn't close it's already open browser window. To prevent this leakage
we catch errors where needed and manually call _tearDownClassInternal.
_tearDownClassInternal should be written as defensively as possible since
it is not allowed to make any assumptions on how far setUpClass got.
This patch should fix the sporadic "Address already in use"-errors on jenkins
and also the "This code isn't under transaction management"-error for sqlite
(also just on jenkins).
After discussion with koniiiik, jezdez, kmtracey, tos9, lifeless, nedbat and
voidspace it was decided that this is the safest approach (thanks to everyone
for their comments and help). Manually calling tearDownClass was shut down
cause we don't know how our users override our classes.
This is a private and very specialized API on purpose and should not be used
without a strong reason!
This patch partially reverts the earlier attempts to fix those issues,
namely:
2fa0dd73b18f55d0fdd1c1d54b1d18031bfcf1ed and
3c5775d36f7e431d9691829a78580873111cb714
Final note: If this patch breaks in a later version of Django, please be
very careful on how you fix it, you might not see test failures locally.
That said, this patch hopefully doesn't produce even more failures.
|