summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2021-04-30Fixed #32678 -- Removed SECURE_BROWSER_XSS_FILTER setting.Tim Graham
2021-04-30Fixed #32698 -- Moved HttpRequest.get_raw_uri() to ↵Hasan Ramezani
ExceptionReporter._get_raw_insecure_uri().
2021-04-29Refs #32178 -- Doc'd ↵Hasan Ramezani
DatabaseFeatures.django_test_skips/django_test_expected_failures in contributing guide.
2021-04-29Fixed capitalization of "ECMAScript" and "JavaScript".Nick Pope
2021-04-29Refs #32674 -- Noted that auto-created through table PKs cannot be ↵Carlton Gibson
automatically migrated.
2021-04-29Refs #32682 -- Renamed lookup_needs_distinct() to lookup_spawns_duplicates().Mariusz Felisiak
Follow up to 187118203197801c6cb72dc8b06b714b23b6dd3d.
2021-04-29Refs #32694 -- Clarified when colorama requirement is needed in Windows how-to.Carlton Gibson
2021-04-29Fixed #32675 -- Doc'd that autodector changes might cause generation of ↵David Wobrock
no-op migrations. Follow up to aa4acc164d1247c0de515c959f7b09648b57dc42.
2021-04-29Refs #32675 -- Removed to_field from ForeignKeys in contrib apps' migrations.David Wobrock
Refs #22889.
2021-04-28Removed unnecessary reuse_with_filtered_relation argument from Query methods.Nick Pope
In Query.join() the argument reuse_with_filtered_relation was used to determine whether to use == or .equals(). As this area of code is related to aliases, we only expect an instance of Join or BaseTable to be provided - the only two classes that provide .equals(). In both cases, the implementations of __eq__() and equals() are based on use of the "identity" property. __eq__() performs an isinstance() check first, returning NotImplemented if required. BaseTable.equals() then does a straightforward equality check on "identity". Join.equals() is a little bit different as it skips checking the last element of the "identity" property: filtered_relation. This was only included previously when the with_filtered_relation argument was True, impossible since bbf141bcdc31f1324048af9233583a523ac54c94.
2021-04-28Removed unused with_filtered_relation argument from .equals()Nick Pope
Unused since bbf141bcdc31f1324048af9233583a523ac54c94.
2021-04-28Corrected introduction to range field lookups docs.Adam Johnson
Follow up to 24b9f5082344a127147266dd52d5d2dcd1c9cb44.
2021-04-28Fixed #32632, Fixed #32657 -- Removed flawed support for Subquery ↵Simon Charette
deconstruction. Subquery deconstruction support required implementing complex and expensive equality rules for sql.Query objects for little benefit as the latter cannot themselves be made deconstructible to their reference to model classes. Making Expression @deconstructible and not BaseExpression allows interested parties to conform to the "expression" API even if they are not deconstructible as it's only a requirement for expressions allowed in Model fields and meta options (e.g. constraints, indexes). Thanks Phillip Cutter for the report. This also fixes a performance regression in bbf141bcdc31f1324048af9233583a523ac54c94.
2021-04-28Refs #32632 -- Added tests for returning a copy when combining Q() objects.Mariusz Felisiak
2021-04-27Fixed #32687 -- Restored passing process’ environment to underlying tool ↵Konstantin Alekseev
in dbshell on PostgreSQL. Regression in bbe6fbb8768e8fb1aecb96d51c049d7ceaf802d3.
2021-04-27Fixed #32682 -- Made admin changelist use Exists() instead of distinct() for ↵Mariusz Felisiak
preventing duplicates. Thanks Zain Patel for the report and Simon Charette for reviews. The exception introduced in 6307c3f1a123f5975c73b231e8ac4f115fd72c0d revealed a possible data loss issue in the admin.
2021-04-27Refs #32682 -- Renamed use_distinct variable to may_have_duplicates.Mariusz Felisiak
QuerySet.distinct() is not the only way to avoid duplicate, it's also not preferred.
2021-04-27Refs #32682 -- Fixed QuerySet.delete() crash on querysets with ↵Mariusz Felisiak
self-referential subqueries on MySQL.
2021-04-27Refs #19080 -- Added tests for preserving select_related() in the admin ↵Mariusz Felisiak
changelist.
2021-04-27Refs 32637 -- Made technical 404 debug page display exception message when ↵Mariusz Felisiak
URL is resolved. Follow up to 3b8527e32b665df91622649550813bb1ec9a9251.
2021-04-27Fixed #32686 -- Removed unnecessary semicolon on collected multiline SQL for ↵Hannes Ljungberg
RunSQL.
2021-04-27Refs #32686 -- Added tests for adding a semicolon when collecting SQL for ↵Hannes Ljungberg
RunSQL.
2021-04-26Fixed #32681 -- Fixed VariableDoesNotExist when rendering some admin template.Zain Patel
Regression in 84609b3205905097d7d3038d32e6101f012c0619.
2021-04-26Fixed isolation of test_rename_table_renames_deferred_sql_references().Mariusz Felisiak
2021-04-23Refs #32673 -- Fixed lookups crash when comparing against lookups on Oracle.Mariusz Felisiak
Follow up to 170b006ce82b0ecf26dc088f832538b747ca0115.
2021-04-23Fixed #32673 -- Fixed lookups crash when comparing against lookups on ↵Simon Charette
PostgreSQL. Regression in 3a505c70e7b228bf1212c067a8f38271ca86ce09. Nonlitteral right-hand-sides of lookups need to be wrapped in parentheses to avoid operator precedence ambiguities. Thanks Charles Lirsac for the detailed report.
2021-04-23Refs #28034 -- Corrected docs example in contributing tutorial.Clumart.G
2021-04-23Fixed isolation of test_showmigrations_unmigrated_app().Mariusz Felisiak
Follow up to 90916f050c64b817fdf2ea13b5c20986005fd029.
2021-04-22Fixed isolation of i18n.tests.FormattingTests.test_get_custom_format().Mariusz Felisiak
2021-04-22Fixed isolation of test_showmigrations_unmigrated_app().Mariusz Felisiak
2021-04-22Used assertCountEqual() in ExcludeTests.test_exclude_subquery().Mariusz Felisiak
2021-04-22Added note to update docs config when creating new stable branch.Carlton Gibson
django_next_version in docs/conf.py should be bumped when creating a new stable branch.
2021-04-21Fixed #32667 -- Added link to labeling checks in ↵Abhyudai
BaseCommand.requires_system_checks docs. Co-authored-by: Mariusz Felisiak <felisiak.mariusz@gmail.com>
2021-04-21Fixed #32662 -- Refactored a generator out of SQLCompiler.get_order_by().Chris Jerdonek
This also renames the `asc` variable to `default_order`, markes the `desc` variable as unused, fixes a typo in SQLCompiler.get_order_by() docstring, and reorders some blocks in SQLCompiler._order_by_pairs().
2021-04-21Fixed #32650 -- Fixed handling subquery aliasing on queryset combination.Simon Charette
This issue started manifesting itself when nesting a combined subquery relying on exclude() since 8593e162c9cb63a6c0b06daf045bc1c21eb4d7c1 but sql.Query.combine never properly handled subqueries outer refs in the first place, see QuerySetBitwiseOperationTests.test_subquery_aliases() (refs #27149). Thanks Raffaele Salmaso for the report.
2021-04-21Fixed #32665 -- Fixed caches system check crash when STATICFILES_DIRS is a ↵Mariusz Felisiak
list of 2-tuples. Thanks Jared Lockhart for the report. Regression in c36075ac1dddfa986340b1a5e15fe48833322372.
2021-04-21Fixed #32647 -- Restored multi-row select with shift-modifier in admin ↵Carlton Gibson
changelist. Regression in 30e59705fc3e3e9e8370b965af794ad6173bf92b.
2021-04-20Refs #25287 -- Added support for multiplying and dividing DurationField by ↵Tobias Bengfort
scalar values on SQLite.
2021-04-20Refs #25287 -- Added _sqlite_prepare_dtdelta_param() hook.Tobias Bengfort
2021-04-20Removed unnecessary line in OrderBy.as_sql().David Beitey
Unnecessary since 7286eaf681d497167cd7dc8b70ceebfcf5cd21ad.
2021-04-20Fixed #32664 -- Made PasswordResetTokenGenerator.secret validation lazy.François Freitag
Django apps initialization to run management command triggers the admin autodiscovery. Importing django.contrib.auth.tokens creates an instance of PasswordResetTokenGenerator which required a SECRET_KEY. For several management commands, the token generator is unused. It should only complain about a missing SECRET_KEY when it is used.
2021-04-20Refs #28017 -- Added test for PasswordResetTokenGenerator subclass with a ↵François Freitag
custom secret.
2021-04-19Fixed #32574 -- Confirmed support for PROJ 8.x.David Smith
2021-04-19Refs #32609 -- Simplified test_labels_set construction in runtests.py's setup().Chris Jerdonek
Follow up to 7cf3a5786bc76374e743fbc0c1a1c8470a61f6c0.
2021-04-19Refs #32611 -- Removed initial "Testing against ..." log message calls from ↵Chris Jerdonek
--bisect/--pair runtests options.
2021-04-19Fixed #32611 -- Prevented unecessary setup()/teardown() calls when using ↵Chris Jerdonek
--bisect/--pair runtests options. This commit changes runtests.py's bisect_tests() and paired_tests() to change settings only when necessary, namely when specific test names aren't provided.
2021-04-16Fixed #29899 -- Made autodetector use model states instead of model classes.David Wobrock
Thanks Simon Charette and Markus Holtermann for reviews.
2021-04-16Refs #29899 -- Improved variable names in ↵David Wobrock
MigrationAutodetector._detect_changes().
2021-04-16Refs #29899 -- Moved resolve_relation() to django.db.migrations.utils.David Wobrock
2021-04-16Corrected File, ContentFile, and ImageFile signatures in docs.Adam Johnson