summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2024-04-23Refs #35356 -- Clarified select related with masked field logic.Simon Charette
By always including related objects in the select mask via adjusting the defer logic (_get_defer_select_mask()), it becomes possible for select_related_descend() to treat forward and reverse relationships indistinctively. This work also simplifies and adds comments to select_related_descend() to make it easier to understand.
2024-04-23Fixed #35356 -- Deferred self-referential foreign key fields adequately.Simon Charette
While refs #34612 surfaced issues with reverse one-to-one fields deferrals, it missed that switching to storing remote fields would break self-referential relationships. This change switches to storing related objects in the select mask instead of remote fields to prevent collisions when dealing with self-referential relationships that might have a different directional mask. Despite fixing #21204 introduced a crash under some self-referential deferral conditions, it was simply not working even before that as it aggregated the sets of deferred fields by model. Thanks Joshua van Besouw for the report and Mariusz Felisiak for the review.
2024-04-22Fixed incorrect blockquotes in docs/topics/forms/index.txt.minusf
2024-04-22Fixed #35392, Refs #34331 -- Allowed importing aprefetch_related_objects ↵James Ostrander
from django.db.models. Thanks James Ostrander for the report and fix, and to Tim Graham and Mariusz Felisiak for the reviews.
2024-04-19Fixed #35321 -- Prevented Mobile Safari zoom-in on Django admin inputs.Jkhall81
Thanks Simon Willison for the report and Ben Cardy for testing.
2024-04-19Reverted release notes for bdd76c4c3817d8e3ed5b0450d5e18e4eae096f16.Sarah Boyce
2024-04-19Fixed #34994, Fixed #35386 -- Applied checkbox-row CSS class unconditionally ↵Adam Johnson
in Admin.
2024-04-17Made SeleniumTests.test_inline_add_another_widgets less flaky by adding ↵Marijke Luttekes
explicit wait.
2024-04-16Doc'd that RemoveField also drops related database objects in PostgreSQL.David Sanders
2024-04-16Fixed #35373 -- Fixed a crash when indexing a generated field on SQLite.Simon Charette
Generated fields have to be excluded from the INSERT query against the remade table including the index. Thanks Moshe Dicker for the report, David Sanders and Mariusz Felisiak for the review.
2024-04-15Extended docs for Q() objects mentioning the ~ (NOT) operator.Mohammad Kazemi
Co-authored-by: Sarah Boyce <42296566+sarahboyce@users.noreply.github.com>
2024-04-15Fixed #35375 -- Fixed tabular inline admin original line to be on the right ↵Eyal Cherevatsky
in RTL.
2024-04-15Fixed ↵Mariusz Felisiak
backends.oracle.tests.TransactionalTests.test_hidden_no_data_found_exception() on oracledb >= 2.1.2. python-oracledb 2.1.2+ no longer hides 'ORA-1403: no data found' exceptions raised in database triggers: https://github.com/oracle/python-oracledb/issues/321
2024-04-12Corrected alphabetical order of latest author added to AUTHORS.nessita
2024-04-12Refs #35361 -- Clarified release notes for 4.2.12 and 5.0.5.Natalia
2024-04-12Fixed #35364 -- Stopped AdminEmailHandler rendering email unnecessarily.Adam Johnson
2024-04-12Refs #35364 -- Tested AdminEmailHandler with empty ADMINS.Adam Johnson
2024-04-12Refs #35194 -- Adjusted a generated field test to work on Postgres 15.6+.Simon Charette
Postgres >= 12.18, 13.14, 14.11, 15.6, 16.2 changed the way the immutability of generated and default expressions is detected in postgres/postgres@743ddaf. The adjusted test semantic is presereved by switching from __icontains to __contains as both make use of a `%` literal which requires proper escaping. Refs #35336. Thanks bcail for the report.
2024-04-11Corrected description of list_display being a list in tutorial 7.Aleksander Milinkevich
2024-04-10Fixed settings path in docs for installing SpatiaLite with Homebrew.Adam Johnson
Co-authored-by: Adam Zapletal <adamzap@gmail.com>
2024-04-10Updated docs for updating translations in ↵nessita
docs/internals/howto-release-django.txt. Co-authored-by: Mariusz Felisiak <felisiak.mariusz@gmail.com>
2024-04-10Made postgresql.tests.Tests.test_connect_pool less flaky by increasing ↵Sarah Boyce
timeout value.
2024-04-10Fixed #35361 -- Added release notes for 4.2.12 and 5.0.5 for backport of ↵Natalia
b231bcd19e57267ce1fc21d42d46f0b65fdcfcf8.
2024-04-10Refs #35361 -- Added test for Email line length checks when dealing with ↵Natalia
surrogate pairs. Refs #33173, #34118 and #34900.
2024-04-10Fixed #35350 -- Fixed save() with pk set on models with GeneratedFields.Sarah Boyce
Thanks Matt Hegarty for the report and Simon Charette and Natalia Bidart for the reviews. Regression in f333e35.
2024-04-05Refs #35354 -- Clarified FORCE_SCRIPT_NAME docs.Carlton Gibson
2024-04-05Fixed #35354 -- Simplified ASGIRequest path handling.Carlton Gibson
Following the ASGI HTTP Connection Scope docs[0], the provided `path` is already the correct value that Django requires. In combination with `root_path`, from which `script_name` is derived, the `path_info` variable is set. It's then redundant to re-calculate `path` from `script_name` and `path_info`. See also, a clarifying discussion on the ASGIref repo[1]. [0]: https://asgi.readthedocs.io/en/latest/specs/www.html#http-connection-scope [1]: https://github.com/django/asgiref/issues/424
2024-04-05Refs #35169 -- Added test for ASGIRequest root_path handling.Carlton Gibson
2024-04-04Refs #31710 -- Improved multiple file upload docs.Adam Johnson
2024-04-04Fixed #35347 -- Clarified choice_set attribute in tutorial 2.Lang Tran
2024-04-03Added stub release notes for 5.0.5.Natalia
2024-04-03Added release date for 5.0.4.Natalia
2024-04-03Fixed SeleniumTests.test_related_object_update_with_camel_casing() assert.Sarah Boyce
A selenium web element was compared to a string rather than its innerHTML.
2024-04-02Fixed #35330 -- Fixed the update of related widgets when the referenced ↵devin13cox
model is camel case named. Co-authored-by: Natalia <124304+nessita@users.noreply.github.com>
2024-04-02Fixed #35336 -- Addressed crash when adding a GeneratedField with % literals.Simon Charette
A longer term solution is likely to have a better separation of parametrized DDL altogether to handle checks, constraints, defaults, and generated fields but such a change would require a significant refactor that isn't suitable for a backport. Thanks Adrian Garcia for the report.
2024-04-01Fixed #35344, Refs #34838 -- Corrected output_field of resolved columns for ↵Johannes Westphal
GeneratedFields in aliased tables. Thanks Simon Charette for the review.
2024-03-30Refs #35234 -- Skipped CheckConstraint system checks if not supported.Mariusz Felisiak
Thanks Tim Graham for the report. Regression in 0fb104dda287431f5ab74532e45e8471e22b58c8.
2024-03-29Restored django.db.models.F import in final code snippet added at the ↵Taishi Endo
beginning of tutorial 4.
2024-03-28Fixed typo in docs/topics/signals.txt.Matthias Kestenholz
2024-03-27Fixed #34977 -- Improved accessibility in the UserChangeForm by replacing ↵Fabian Braun
the reset password link with a button. Co-authored-by: Natalia <124304+nessita@users.noreply.github.com>
2024-03-27Fixed #35233 -- Moved template engine system checks to backend methods.Giannis Terzopoulos
Thanks Adam Johnson for reviews.
2024-03-26Fixed #35329 -- Fixed migrations crash when adding partial unique ↵Mariusz Felisiak
constraints with nulls_distinct. Bug in 595a2abb58e04caa4d55fb2589bb80fb2a8fdfa1. Thanks Lucas Lemke Saunitti for the report.
2024-03-25Removed unused _alter_column_collation_sql() in PostgreSQL DatabaseSchemaEditor.Mariusz Felisiak
Unused since ae0899be0d787fbfc5f5ab2b18c5a8219d822d2b.
2024-03-25Increased test coverage for django.db.migrations.operations.special.Mariusz Felisiak
2024-03-24Fixed #35323 -- Prevented file_move_safe() from trying to overwrite existing ↵Ben Cail
file when allow_overwrite is False.
2024-03-22Fixed #34841 -- Avoided rendering apps on state still requiring mutation.David Sanders
2024-03-22Added ModelState.from_model() test for abstract model with unnamed indexes.Mariusz Felisiak
2024-03-21Fixed #35320 -- Removed unnecessary django.core.files.move._samefile() hook.Ben Cail
os.path.samefile() uses the same implementation on Windows as all other platforms since Python 3.4.
2024-03-21Fixed #35257 -- Corrected resolving output_field for ↵sharonwoo
IntegerField/DecimalField with NULL.
2024-03-21Added RowNumber() link in Rank() docs.Adam Zapletal