summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-11-10Fixed #32182 -- Fixed crash of JSONField nested key transforms with subquery ↵Hannes Ljungberg
annotations on PostgreSQL.
2020-11-09Renamed BaseSpatialOperations.geography to ↵Tim Graham
BaseSpatialFeatures.supports_geography.
2020-11-09Removed BaseSpatialOperations.geometry.Tim Graham
Unused since 26996e2d55719deb0a0b85c642c88658c929106c.
2020-11-07Removed hardcoded pks in migrations' test_alter_order_with_respect_to.Tim Graham
2020-11-06Fixed #32045 -- Doc'd GenericRelatedObjectManager methods.Craig Smith
This also documents that .remove() and clear() methods delete related objects.
2020-11-06Refs #32045 -- Added tests for GenericRelatedObjectManager.clear()/remove().Craig Smith
2020-11-06Fixed #31235 -- Made assertQuerysetEqual() compare querysets directly.Hasan Ramezani
This also replaces assertQuerysetEqual() to assertSequenceEqual()/assertCountEqual() where appropriate. Co-authored-by: Peter Inglesby <peter.inglesby@gmail.com> Co-authored-by: Mariusz Felisiak <felisiak.mariusz@gmail.com>
2020-11-06Refs #31910 -- Fixed GeoQuerySetTest.test_geoagg_subquery() test on Oracle 18c.Mariusz Felisiak
2020-11-05Fixed #25791 -- Implement autoreload behaviour for cached template loader.Tom Forbes
2020-11-05Refs #25791 -- Added get_dirs() method to cached template loader.Tom Forbes
2020-11-05Fixed #22276 -- Fixed crash when formset management form is invalid.Jon Dufresne
Co-authored-by: Patryk Zawadzki <patrys@room-303.com>
2020-11-05Fixed #31550 -- Adjusted ASGI test_file_response for various Windows content ↵Christopher Keith
types.
2020-11-04Fixed #32168 -- Removed serial pk assumption in aggregation_regress tests.Christopher Wang
2020-11-04Refs #32168 -- Fixed Publisher assertions in AggregationTests.test_more_more.Christopher Wang
Refer to Publisher objects instead of Books. Test regression in 1bf25e9bc6df6c2ae4c0b10fb839e101471e8373.
2020-11-04Fixed #32169 -- Added distinct support to JSONBAgg.Artur Beltsov
2020-11-04Fixed #31983 -- Added system check for file system caches location.christa
Thanks Johannes Maron and Nick Pope for reviews.
2020-11-04Fixed #32159 -- Ensured AsyncRequestFactory correctly sets headers.Carlton Gibson
2020-11-04Fixed #31910 -- Fixed crash of GIS aggregations over subqueries.Simon Charette
Regression was introduced by fff5186 but was due a long standing issue. AggregateQuery was abusing Query.subquery: bool by stashing its compiled inner query's SQL for later use in its compiler which made select_format checks for Query.subquery wrongly assume the provide query was a subquery. This patch prevents that from happening by using a dedicated inner_query attribute which is compiled at a later time by SQLAggregateCompiler. Moving the inner query's compilation to SQLAggregateCompiler.compile had the side effect of addressing a long standing issue with aggregation subquery pushdown which prevented converters from being run. This is now fixed as the aggregation_regress adjustments demonstrate. Refs #25367. Thanks Eran Keydar for the report.
2020-11-04Removed hardcoded pk in defer_regress test.Tim Graham
2020-11-04Fixed GenericRelationTests.test_annotate when primary key values are large.Tim Graham
On CockroachDB, primary key values stored in this fields are larger than they accept.
2020-11-03Removed serial pk assumption in ordering tests.Tim Graham
Fixed OrderingTests.test_order_by_fk_attname and test_order_by_pk on CockroachDB.
2020-11-03Refs #32061 -- Fixed test_crash_password_does_not_leak() crash on Windows.Mariusz Felisiak
When env is passed to subprocess.run() we should pass all existing environment variables. This fixes crash on Windows: Fatal Python error: failed to get random numbers to initialize Python Fatal Python error: _Py_HashRandomization_Init: failed to get random numbers to initialize Python Python runtime state: preinitialized
2020-11-03Fixed #32162 -- Fixed setting Content-Length header in AsyncRequestFactory.Patrick Arminio
2020-11-03Refs #29113 -- Simplified formset validation.Claude Paroz
Thanks Nick Pope for review and complement.
2020-11-03Fixed DistinctOnTests.test_basic_distinct_on on CockroachDB.Tim Graham
2020-11-03Removed serial pk assumption from ↵Tim Graham
FormfieldShouldDeleteFormTests.test_custom_delete.
2020-11-03Fixed #32166 -- Removed redundant definition of Greatest in ↵Sicong
test_expression_on_aggregation.
2020-11-02Fixed #32132 -- Fixed column types in m2m intermediary tables for ↵David-Wobrock
Positive(Big/Small)IntegerFields.
2020-11-02Refs #32132 -- Added rel_db_type() tests for auto and integer fields.David-Wobrock
2020-11-02Simplified DeclarativeFieldsMetaclass.__new__() a bit.Vitaliy Yelnik
2020-11-02Updated {% static %} tag examples in docs to use single quotes where ↵Nikita Sobolev
appropriate.
2020-11-02Added stub release notes for 3.1.4.Carlton Gibson
2020-11-02Set release date for 3.1.3, 3.0.11, and 2.2.17.Carlton Gibson
2020-11-02Protected Watchman autoreloader against busy loops.Daniel Hahler
With an error in the loop above (e.g. using query without args), this would trigger a busy loop. While this was caused due to changes to the loop itself, it seems to be just good practice to protect against this.
2020-10-30Fixed #32153 -- Fixed management commands when using required list options.Hasan Ramezani
Thanks Mark Gajdosik for the report and initial patch.
2020-10-30Updated MultiValueDict.update() to mirror dict.update() behavior.Nick Pope
Changes in behavior include: - Accepting iteration over empty sequences, updating nothing. - Accepting iterable of 2-tuples providing key-value pairs. - Failing with the same or comparable exceptions for invalid input. Notably this replaces the previous attempt to catch TypeError which was unreachable as the call to .items() resulted in AttributeError on non-dict objects.
2020-10-30Removed unused custom exception support for ImmutableList.Nick Pope
If the warning provided was an instance of Exception, then it would be used as-is. In practice this is untested, unused and ImmutableList is an undocumented internal datastructure.
2020-10-30Increased test coverage for django.utils.datastructures.MultiValueDict.Nick Pope
Co-authored-by: Mads Jensen <mje@inducks.org>
2020-10-30Increased test coverage for django.utils.datastructures.OrderedSet.Mads Jensen
Co-authored-by: Nick Pope <nick.pope@flightdataservices.com>
2020-10-30Refs #32061 -- Prevented password leak on MySQL dbshell crash.Simon Charette
The usage of the --password flag when invoking the mysql CLI has the potential of exposing the password in plain text if the command happens to crash due to the inclusion of args provided to subprocess.run(check=True) in the string representation of the subprocess.CalledProcessError exception raised on non-zero return code. Since this has the potential of leaking the password to logging facilities configured to capture crashes (e.g. sys.excepthook, Sentry) it's safer to rely on the MYSQL_PWD environment variable instead even if its usage is discouraged due to potential leak through the ps command on old flavors of Unix. Thanks Charlie Denton for reporting the issue to the security team. Refs #24999.
2020-10-30Refs #32061 -- Added test for dbshell password leak on PostgreSQL.Simon Charette
2020-10-29Refs #32061 -- Unified DatabaseClient.runshell() in db backends.Simon Charette
2020-10-29Fixed #32152 -- Fixed grouping by subquery aliases.Christian Klus
Regression in 42c08ee46539ef44f8658ebb1cbefb408e0d03fe. Thanks Simon Charette for the review.
2020-10-29Fixed #26962 -- Doc'd running migrations in transactions.Caio Ariede
2020-10-28Made small readability improvements.Martin Thoma
2020-10-28Refs #28215 -- Marked auth credentials as sensitive variables.Hasan Ramezani
Co-authored-by: Collin Anderson <collin@onetencommunications.com>
2020-10-28Refs #25780 -- Removed redundant status code assertions from tests.Jon Dufresne
2020-10-28Fixed #32062 -- Added %b support to Date.strftime.Gagan Deep
This enables the admin to display the month as locale's abbreviated name if %b is used in the date format.
2020-10-28Added unit test for Date.getFullMonthName.Gagan Deep
2020-10-28Fixed #32143 -- Used EXISTS to exclude multi-valued relationships.Simon Charette
As mentioned in the pre-existing split_exclude() docstring EXISTS is easier to optimize for query planers and circumvents the IN (NULL) handling issue.