summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2011-08-26Be very clear about when it's appropriate to use defer() and only().Malcolm Tredinnick
I've been seeing a bit of over-reliance on defer() and only() in code around the place and it's generally better modelled with normalised data or shadow (unmanaged) models. This commit makes this position clearer. git-svn-id: http://code.djangoproject.com/svn/django/trunk@16692 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-08-26Add a note about discouraging whitespace- or formatting-only patches.Malcolm Tredinnick
We follow the python-dev path here. Deliberately. git-svn-id: http://code.djangoproject.com/svn/django/trunk@16691 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-08-26Further improved on the work done in r16622 by making the help text icons ↵Julien Phalip
look hoverable in the admin tabular inline headers. git-svn-id: http://code.djangoproject.com/svn/django/trunk@16690 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-08-26Added a bit to 'Saving ManyToMany Fields' explicitly explaining how to add ↵Adrian Holovaty
multiple relations in one statement git-svn-id: http://code.djangoproject.com/svn/django/trunk@16689 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-08-26Added some tips to the contributor docs, namely about removing trailing ↵Julien Phalip
whitespaces and about mentioning relevant ticket numbers in tests. git-svn-id: http://code.djangoproject.com/svn/django/trunk@16688 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-08-25Fixed #16677 -- Fixed the future version of the ssi template tag to work ↵Julien Phalip
with template file names that contain spaces. Note that this fix cannot be applied to the currently deprecated version of the ssi tag since it requires an unquoted literal as parameter. Many thanks to Aymeric Augustin for the report and patch. git-svn-id: http://code.djangoproject.com/svn/django/trunk@16687 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-08-25Fix test from r16678 and r16681 properly for Oracle.Malcolm Tredinnick
Fixes #16694, with thanks to aagustin for the Oracle testing and tweaking. git-svn-id: http://code.djangoproject.com/svn/django/trunk@16686 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-08-25Documented `translation.override` context manager introduced in r16166.Jannis Leidel
git-svn-id: http://code.djangoproject.com/svn/django/trunk@16685 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-08-25Fixed a small admin CSS issue where the "Save and continue editing" and ↵Julien Phalip
"Save and add another" buttons were wrongly aligned with left-to-right languages in IE7. git-svn-id: http://code.djangoproject.com/svn/django/trunk@16683 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-08-25Make ManyToManyField model references more robust.Malcolm Tredinnick
In r16679 a test was added to verify something had been fixed when a unicode string type was passed in as a model name. The name has to be ASCII convertible, but in Python 2.6 and earlier, it must also have str type. This commit fixes the problem for earlier Python versions and is almost identical to a patch from b.leskes in #6045. Fixes #16689. Refs #6045. git-svn-id: http://code.djangoproject.com/svn/django/trunk@16682 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-08-25Modify validity check from r16678 slightly to work with Oracle.Malcolm Tredinnick
We now skip this particular check on Oracle backends. Change is based on a backend feature check, so it also works with other backends that may treat NULL as equal to an empty string. Fixes #16694 (with luck). git-svn-id: http://code.djangoproject.com/svn/django/trunk@16681 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-08-24Fixed #15837. Consolidated all the locaflavor tests into a single, logical, ↵Julien Phalip
place (regressiontests/localflavor/). git-svn-id: http://code.djangoproject.com/svn/django/trunk@16680 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-08-24Added another test to confirm fix in r16663.Malcolm Tredinnick
This is the test case from #6045, which was fixed by the above commit. Refs #6045, #16299 git-svn-id: http://code.djangoproject.com/svn/django/trunk@16679 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-08-23Teach "django-admin.py validate" to forbid nullable primary keys.Malcolm Tredinnick
Fixes #15884, with thanks to JustinTArthur and Julie Pichon. git-svn-id: http://code.djangoproject.com/svn/django/trunk@16678 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-08-23Corrected the setup and teardown of the refactored invalid_models test so ↵Russell Keith-Magee
that it guarantees that stdout is restored, and purges all the temporary models from the app cache after running the test. git-svn-id: http://code.djangoproject.com/svn/django/trunk@16670 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-08-23Reverted r16662 -- There are bunch of problems with this patch, including ↵Russell Keith-Magee
failing tests, that I didn't pick up before committing. git-svn-id: http://code.djangoproject.com/svn/django/trunk@16669 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-08-23Allow "pk" as a field alias in QuerySet.only() calls.Malcolm Tredinnick
Thanks to GDorn for the patch. Fixed #15494. git-svn-id: http://code.djangoproject.com/svn/django/trunk@16668 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-08-23Fixed a broken test from r16656.Malcolm Tredinnick
git-svn-id: http://code.djangoproject.com/svn/django/trunk@16667 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-08-23Fixed #16669 -- Made the startproject instruction formatting easier to read ↵Julien Phalip
and more consistent with other formatting in the tutorial part 1. Thanks to Daniel Lawrence and Aymeric Augustin. git-svn-id: http://code.djangoproject.com/svn/django/trunk@16664 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-08-23Fixed #16299 -- Ensure that unicode strings can be used to identify classes ↵Russell Keith-Magee
in ForeignKey and ManyToManyFields. Unicode strings aren't actually legal as class names, but this is an issue if you use from __future__ import unicode_literals in your models.py file. Thanks to Martijn Bastiaan for the report, and Anthony Briggs for the final patch. git-svn-id: http://code.djangoproject.com/svn/django/trunk@16663 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-08-23Fixed #16202 -- Added a Slovenian localflavor. Thanks to Jure Cuhalev ↵Russell Keith-Magee
<gandalf@owca.info>, Gasper Zejn, Domen Kozar and iElectric for the patch. git-svn-id: http://code.djangoproject.com/svn/django/trunk@16662 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-08-23Fixed #16681 -- Refactored the invalid_models unit test so that it can be ↵Russell Keith-Magee
invoked manually. Thanks to Anthony Briggs for the report and patch. git-svn-id: http://code.djangoproject.com/svn/django/trunk@16661 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-08-23Fixed #16680 -- Used single quotes for the TEMPLATE_DIRS examples in part 2 ↵Julien Phalip
of the tutorial to be consistent with the settings.py file generated by the startproject command. Thanks, Michael Tomkins. git-svn-id: http://code.djangoproject.com/svn/django/trunk@16660 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-08-23Fixed #15315 -- Added support for the 'widget' argument to ↵Russell Keith-Magee
modelform_factory. Thanks to SardarNL and Will Hardy for the patch. git-svn-id: http://code.djangoproject.com/svn/django/trunk@16659 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-08-23Fix initialisation of ImageField super classes.Malcolm Tredinnick
Fixes #16548, with thanks to pyriku. git-svn-id: http://code.djangoproject.com/svn/django/trunk@16658 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-08-23Fixed #15499 -- Ensure that cache control headers don't try to set public ↵Russell Keith-Magee
and private as a result of multiple calls to patch_cache_control with different arguments. Thanks to AndiDog for the report and patch. git-svn-id: http://code.djangoproject.com/svn/django/trunk@16657 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-08-23Fixed an isnull=False filtering edge-case. Fixes #15316.Malcolm Tredinnick
The bulk of this patch is due to some fine analysis from Aleksandra Sendecka. git-svn-id: http://code.djangoproject.com/svn/django/trunk@16656 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-08-23Added convenience method for viewing Query SQL without params.Malcolm Tredinnick
This is the old Query.as_sql() method revived: it's like Query.__str__, but the parameters aren't substituted into the placeholders. Thus, it's a more accurate representation of the SQL the (default) backend will see. Entirely internal. git-svn-id: http://code.djangoproject.com/svn/django/trunk@16655 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-08-23Add the ability to do unordered comparisons in assertQuerysetEqual.Malcolm Tredinnick
git-svn-id: http://code.djangoproject.com/svn/django/trunk@16654 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-08-23Fixed #15838 -- Promoted assertFieldOutput to a general test utility. Thanks ↵Russell Keith-Magee
to Ramiro Morales for the patch. git-svn-id: http://code.djangoproject.com/svn/django/trunk@16653 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-08-23Added myself to the list of committers.Julien Phalip
git-svn-id: http://code.djangoproject.com/svn/django/trunk@16652 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-08-23Fixed #10571 -- Factored out the payload encoding code to make sure it is ↵Russell Keith-Magee
used for PUT requests. Thanks to kennu for the report, pterk for the patch, and wildfire for the review comments. git-svn-id: http://code.djangoproject.com/svn/django/trunk@16651 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-08-23Fixed #16672 -- Ensure that test classes decorated with @override_setings ↵Russell Keith-Magee
gets the right name when running the tests. Thanks to Julien Phalip for the report and initial patch git-svn-id: http://code.djangoproject.com/svn/django/trunk@16650 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-08-22Silenced a "classic division" warning in floatformat template filter.Malcolm Tredinnick
Fixes #16514. Thanks, Mike Blume. git-svn-id: http://code.djangoproject.com/svn/django/trunk@16649 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-08-22Fixed #14876 -- Ensure that join promotion works correctly when there are ↵Russell Keith-Magee
nullable related fields. Thanks to simonpercivall for the report, oinopion and Aleksandra Sendecka for the original patch, and to Malcolm for helping me wrestle the edge cases to the ground. git-svn-id: http://code.djangoproject.com/svn/django/trunk@16648 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-08-22Minor Debian/Ubuntu install instruction update.Malcolm Tredinnick
This is all a bit of a mess (and fragile and mostly their own fault), but this at least gives people a clue. Fixes #16287. Patch from bpeschier. git-svn-id: http://code.djangoproject.com/svn/django/trunk@16647 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-08-22Documented some Oracle-specific test settings.Malcolm Tredinnick
Patch from aaugustin that should help people with specific testing requirements for Oracle set things up in their preferred way. The settings have always existed, but now they are documented. Fixes #16478. git-svn-id: http://code.djangoproject.com/svn/django/trunk@16646 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-08-22Trivial documentation typo fix.Malcolm Tredinnick
Fixed #16545. Thanks, Audrey Roy. git-svn-id: http://code.djangoproject.com/svn/django/trunk@16645 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-08-22Improved documentation around HTTP server meta variables.Malcolm Tredinnick
Fixed #16581, with thanks to Bernhard Essl. git-svn-id: http://code.djangoproject.com/svn/django/trunk@16644 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-08-22Added myself to the committers listPaul McMillan
git-svn-id: http://code.djangoproject.com/svn/django/trunk@16643 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-08-22Removed unused admin Javascript functions from source.Malcolm Tredinnick
Fixed #16204. Thanks, melinath. git-svn-id: http://code.djangoproject.com/svn/django/trunk@16642 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-08-22Teach inspectdb to handle SQL column names that are digits.Malcolm Tredinnick
There's no accounting for taste in the way some people name columns, apparently. Create a column with a name of "1" and inspectdb will still produce valid Python code now. Fixed #16536. Thanks tereaom and danodonovan. git-svn-id: http://code.djangoproject.com/svn/django/trunk@16641 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-08-22Typo fix in class-based view documentation.Malcolm Tredinnick
Fixed #16666. Thanks saebyn. git-svn-id: http://code.djangoproject.com/svn/django/trunk@16640 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-08-22Made documentation of ManyToManyField placement clearer (kind of).Malcolm Tredinnick
Inspired by ticket #16661. git-svn-id: http://code.djangoproject.com/svn/django/trunk@16639 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-08-22Improved error message display during validation errors.Malcolm Tredinnick
When reporting a validation error (during model validation or fixture loading, for example), the error messages now report the bad value as well as the expected type. This can make identifying the offending field and problem a bit easier. Fixed #11595. Patch from raulcd and wildfire with supervision from Russell. git-svn-id: http://code.djangoproject.com/svn/django/trunk@16638 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-08-22Pre-formatted text wrapping change in technical debug page.Malcolm Tredinnick
In (typically rare) cases, a very long exception line can appear that requires horiztonal scrolling in the cut-and-paste exception layout box. To make this fractionally more readable, we pre-wrap the text now. Fixes #16331, based on a patch from Trinh Hai-Anh. git-svn-id: http://code.djangoproject.com/svn/django/trunk@16637 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-08-21Fixed #16644 -- Fixed one additional test that was failing in Oracle due to ↵Ramiro Morales
false assumptions about the primary keys of objects. Thanks Aymeric Augustin for report and patch. git-svn-id: http://code.djangoproject.com/svn/django/trunk@16636 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-08-21Fixed #16481 -- Adapted one raw SQL query in cull immplementation of the ↵Ramiro Morales
database-based cache backend so it works with Oracle. Thanks Aymeric Augustin for the report and patch. git-svn-id: http://code.djangoproject.com/svn/django/trunk@16635 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-08-21Update my committer bio since I work somewhere else now.James Bennett
git-svn-id: http://code.djangoproject.com/svn/django/trunk@16634 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-08-21Fixed #16602 - Added forms.widgets TOC links to docs; thanks kencochrane.Timo Graham
git-svn-id: http://code.djangoproject.com/svn/django/trunk@16633 bcc190cf-cafb-0310-a4f2-bffc1f526a37
generated by cgit v1.3 (git 2.53.0) at 2026-11-10 03:37:22 +0000