| Age | Commit message (Collapse) | Author |
|
Fixed #19433 -- Added some class attributes to pass initial form lists to the WizardView.
|
|
without the need to add them in the as_view call.
|
|
|
|
|
|
User models.
Thanks to matiasb for the report of #20060 and the draft patch for #20048.
|
|
This improves rendering in some foreign languages.
|
|
|
|
Docs template name typo
|
|
This was a regression due to unicode_literals usage. Thanks Ivan
Virabyan for the report and the initial patch.
|
|
Python 2.6 has some different behaviour when checking
isinstance(foo, collections.Iterator).
|
|
Thanks guettli for the suggestion.
|
|
change_list_request.html doesn't exist, it's named change_list_results.html
|
|
This is provided as a new "validate_max" formset_factory option defaulting to
False, since the non-validating behavior of max_num is longstanding, and there
is certainly code relying on it. (In fact, even the Django admin relies on it
for the case where there are more existing inlines than the given max_num). It
may be that at some point we want to deprecate validate_max=False and
eventually remove the option, but this commit takes no steps in that direction.
This also fixes the DoS-prevention absolute_max enforcement so that it causes a
form validation error rather than an IndexError, and ensures that absolute_max
is always 1000 more than max_num, to prevent surprising changes in behavior
with max_num close to absolute_max.
Lastly, this commit fixes the previous inconsistency between a regular formset
and a model formset in the precedence of max_num and initial data. Previously
in a regular formset, if the provided initial data was longer than max_num, it
was truncated; in a model formset, all initial forms would be displayed
regardless of max_num. Now regular formsets are the same as model formsets; all
initial forms are displayed, even if more than max_num. (But if validate_max is
True, submitting these forms will result in a "too many forms" validation
error!) This combination of behaviors was chosen to keep the max_num validation
simple and consistent, and avoid silent data loss due to truncation of initial
data.
Thanks to Preston for discussion of the design choices.
|
|
|
|
|
|
Thanks to amosonn at yahoo.com for the report, @doda for the initial patch and
@datagrok for the revamped logic and test case.
|
|
The ticket dealt with a case where one query had .exclude() that
produced a subquery, the other query had a join to the same model that
was subqueried in the first query. This was already fixed in master, so
only test added.
|
|
|
|
Thanks to loic84 for the report and patch.
|
|
exception too"
This reverts commit 2cd0edaa477b327024e4007c8eaf46646dcd0f21.
This commit was the cause of a memory leak. See ticket for more details.
Thanks Anssi Kääriäinen for identifying the source of the bug.
|
|
|
|
Thanks martinogden for the initial patch and d1ffuz0r for tests.
|
|
|
|
|
|
catalanojuan/fix-admin-log-dependency-on-user-id-field-20088
Fixed #20088 -- Changed get_admin_log not to depend on User id field
|
|
Thanks jrothenbuhler for draft patch, Konark Modi for updates.
|
|
Before this change, the get_admin_log method would expect User model's
FK to be named `id`. When changing that FK name, admin/index.html
rendering would fail.
This includes:
* Changed the use of id for the use of pk property.
* Added a regression test that fails without the patch.
This commit refs #20088.
|
|
Removed the RIP, which seemed callous given today's news of Malcolm's death.
|
|
Documentation - Small update to SESSION_COOKIE_DOMAIN documentation
|
|
|
|
Thanks to Krzysztof Jurewicz for initial patch and
adupin for tests.
|
|
catalanojuan/adds-dates-containing-zeros-note-to-docs
Added warn note to docs about MySQL issues with 0000-00-00 date strings
|
|
MySQL accepts 0000-00-00 as a valid date but MySQLdb converts those
values into None. So there will be problems for instance if trying to
transport the data using dumpdata/loaddata.
This patch refs #6642 that has been closed as wontfix since this is a
particular problem of MySQL.
|
|
|
|
|
|
|
|
Thanks blaze33 for the patch.
|
|
Thanks Roman Gladkov and Zbigniew Siciarz.
|
|
|
|
|
|
Thanks Kronuz and regebro.
|
|
Thanks Claude and Julien for the review.
|
|
|
|
Thanks Erik Romijn.
|
|
|
|
|
|
Fixed #20043 -- Removed unused BLANK_CHOICE_NONE
|
|
The backwards-incompatible changes section wasn't structured in sections
like it is in release notes for previous versions.
|
|
Some alternative implementations don't have them.
Closes #19944.
|
|
|