| Age | Commit message (Collapse) | Author |
|---|
|
|
|
|
|
Thanks Tim Graham for the review.
|
|
If importing or initializing a template backend fails, attempting to
access this template backend again must raise the same exception.
|
|
In addition to ImproperlyConfigured, Engine.get_default() may also raise
ImportError or other exceptions. It's better to catch all exceptions in
places where the default engine isn't strictly required.
|
|
|
|
Thanks Collin Anderson for the report.
|
|
Also made RegexURLResolver.url_patterns a cached property for
consistency and efficiency.
|
|
|
|
During direct assignment, evaluating the iterable before the transaction
is started avoids leaving the transaction dirty if an exception is raised.
This is slightly more wasteful but probably not enough to warrant a change
of behavior.
Thanks Anssi for the feedback. Refs #6707.
|
|
inline.
Refs #6707.
|
|
Thanks Anssi Kääriäinen, Carl Meyer, Collin Anderson, and Tim Graham for the reviews.
|
|
|
|
The function no longer flushes zfile after each write as doing so can
lead to the gzipped streamed content being larger than the original
content; each flush adds a 5/6 byte type 0 block. Removing this means
buf.read() may return nothing, so only yield if that has some data.
Testing shows without the flush() the buffer is being flushed every 17k
or so and compresses the same as if it had been done as a whole string.
|
|
during tests
Cleared caching in staticfiles_storage and get_finder when
relevant settings are changed.
|
|
|
|
|
|
|
|
At the same time, made sure that empty nodes in where clause match
everything.
|
|
Instead of splitting filter clauses to where and having parts before
adding them to query.where or query.having, add all filter clauses to
query.where, and when compiling the query split the where to having and
where parts.
|
|
Based on patch by Adam J Forster, Paul Collins, and Julien.
|
|
|
|
|
|
Thanks to Tim for the review.
|
|
Added in 3e97535907baa7b57c9bf322871ef6243e2045a9, this check
appears to never be triggered today.
|
|
A change in Python test discovery [1] causes the old packages that raised
an error to be discovered; now we use a common directory that's
ignored during discovery. Refs #23763.
[1] http://bugs.python.org/issue7559
|
|
Thanks to Aron Podrigal for the initial patch and Tim for the review.
|
|
|
|
This reverts commit e8171daf0cd7f0e070395cb4c850c17fea32f11d.
A new solution is forthcoming.
|
|
|
|
|
|
|
|
Thanks Stanislas Guerra for the report and Tomas Ehrlich for
the review.
|
|
make_bytes() assumed that if the Content-Encoding header is set, then
everything had already been dealt with bytes-wise, but in a streaming
situation this was not necessarily the case.
make_bytes() is only called when necessary when working with a
StreamingHttpResponse iterable, but by that point the middleware has
added the Content-Encoding header and thus make_bytes() tried to call
bytes(value) (and dies). If it had been a normal HttpResponse,
make_bytes() would have been called when the content was set, well
before the middleware set the Content-Encoding header.
This commit removes the special casing when Content-Encoding is set,
allowing unicode strings to be encoded during the iteration before they
are e.g. gzipped. This behaviour was added a long time ago for #4969 and
it doesn't appear to be necessary any more, as everything is correctly
made into bytes at the appropriate places.
Two new tests, to show that supplying non-ASCII characters to a
StreamingHttpResponse works fine normally, and when passed through the
GZip middleware (the latter dies without the change to make_bytes()).
Removes the test with a nonsense Content-Encoding and Unicode input - if
this were to happen, it can still be encoded as bytes fine.
|
|
|
|
The method is mainly intended for use with UUIDField. For UUIDField we
want to call the field's default even when primary key value is
explicitly set to None to match the behavior of AutoField.
Thanks to Marc Tamlyn and Tim Graham for review.
|
|
queryset.
Thanks jekka-ua for the report and patch.
|
|
|
|
|
|
Specifically in rendering shortcuts, template responses, and class-based
views that return template responses.
Also added a test for render_to_response(status=...) which was missing
from fdbfc980.
Thanks Tim and Carl for the review.
|
|
This function is unused since dce820ff70f00e974afd3e6e310aa825bc55319f
after being introduced in 718a5ba1a1a77374c26b134ded46dab13776d1a1
|
|
inlineformset_factory examples.
|
|
This function is unused since 6fe2b001dba45134d7c10729c57959995e241a88
|
|
|
|
This method is unused since f567d04b249913db4a37adab8ba521cdc974d423
|
|
This method was inadvertently reintroduced in
f59fd15c4928caf3dfcbd50f6ab47be409a43b01
|
|
This method is unused since 337d102b8612503bb9dc712bfbf07432a9a96302
|
|
|
|
Needed for tests for migrations handling of database defaults.
|
|
This method is unused since 8717b0668caf00ec5e81ef5a1e31b4d7c64eee8a.
|
