diff options
| author | Andreas Hug <hello@foonicorn.com> | 2012-12-06 20:00:56 +0100 |
|---|---|---|
| committer | Claude Paroz <claude@2xlibre.net> | 2012-12-06 20:05:16 +0100 |
| commit | 67bddc0b7b6468abe875f30e4b70560787b5eb5b (patch) | |
| tree | b6db0267656f34289fc4627159fe8adfebec2ff4 /django/forms/formsets.py | |
| parent | e9301ae451f84b06687d27af0a43bcb986054f63 (diff) | |
[1.5.x] Fixed #18574 -- Make BaseFormSet.is_valid call its underlying forms' is_valid
Thanks Simon Charette for the report and the initial patch.
Backport of 66dfcc10b from master.
Diffstat (limited to 'django/forms/formsets.py')
| -rw-r--r-- | django/forms/formsets.py | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/django/forms/formsets.py b/django/forms/formsets.py index a0a38f336f..3893cc54ba 100644 --- a/django/forms/formsets.py +++ b/django/forms/formsets.py @@ -267,7 +267,7 @@ class BaseFormSet(object): def is_valid(self): """ - Returns True if form.errors is empty for every form in self.forms. + Returns True if every form in self.forms is valid. """ if not self.is_bound: return False @@ -282,8 +282,7 @@ class BaseFormSet(object): # This form is going to be deleted so any of its errors # should not cause the entire formset to be invalid. continue - if bool(self.errors[i]): - forms_valid = False + forms_valid &= form.is_valid() return forms_valid and not bool(self.non_form_errors()) def full_clean(self): |
