django.git/tests/delete_regress, branch maindjango
http://cgit.adnoto.dev/django.git/atom?h=main2024-02-08T17:41:32ZFixed #35073 -- Avoided unnecessary calling of callables used by SET/SET_DEFAULT in Collector.collect().2024-02-08T17:41:32Zbcailbcail@crossway.org2024-02-08T17:41:32Zurn:sha1:9c5e382b981608a26f2c55f1259d9e823fee5f15Used addCleanup() in tests where appropriate.2023-12-31T09:01:31ZMariusz Felisiakfelisiak.mariusz@gmail.com2023-12-31T09:01:31Zurn:sha1:d88ec42bd0a37340c8477a6f20bf26e58bd84735Refs #32433 -- Reallowed calling QuerySet.delete() after distinct().2023-07-07T05:08:28ZSimon Charettecharette.s@gmail.com2023-07-04T21:34:20Zurn:sha1:28e2077148f7602d29165e90965974698819cbba
While values(*field_excluding_pk).distinct() and
distinct(*field_excluding_pk) can reduce the number of resulting rows
in a way that makes subsequent delete() calls ambiguous standalone
.distinct() calls cannot.
Since delete() already disallows chain usages with values() the only
case that needs to be handled, as originally reported, is when
DISTINCT ON is used via distinct(*fields).
Refs #32682 which had to resort to subqueries to prevent duplicates in
the admin and caused significant performance regressions on MySQL
(refs #34639).
This partly reverts 6307c3f1a123f5975c73b231e8ac4f115fd72c0d.
Fixed #33759 -- Avoided unnecessary subquery in QuerySet.delete() with self-referential subqueries if supported.2023-05-01T08:20:20Z4the4ryushinaman2001mi@gmail.com2023-04-27T21:03:25Zurn:sha1:0b0998dc151feb77068e2387c34cc50ef6b356aeRefs #33476 -- Applied Black's 2023 stable style.2023-02-01T10:04:38ZDavid Smithsmithdc@gmail.com2023-02-01T07:13:39Zurn:sha1:097e3a70c1481ee7b042b2edd91b2be86fb7b5b6
Black 23.1.0 is released which, as the first release of the year,
introduces the 2023 stable style. This incorporates most of last year's
preview style.
https://github.com/psf/black/releases/tag/23.1.0
Fixed #33928 -- Avoided unnecessary queries when cascade updating.2022-08-27T12:25:55ZSimon Charettecharette.s@gmail.com2022-08-17T20:33:22Zurn:sha1:0701bb8e1f1771b36cdde45602ad377007e372b3
Models that use SET, SET_NULL, and SET_DEFAULT as on_delete handler
don't have to fetch objects for the sole purpose of passing them back to
a follow up UPDATE query filtered by the retrieved objects primary key.
This was achieved by flagging SET handlers as _lazy_ and having the
collector logic defer object collections until the last minute. This
should ensure that the rare cases where custom on_delete handlers are
defined remain uncalled when when dealing with an empty collection of
instances.
This reduces the number queries required to apply SET handlers from
2 to 1 where the remaining UPDATE use the same predicate as the non
removed SELECT query.
In a lot of ways this is similar to the fast-delete optimization that
was added in #18676 but for updates this time. The conditions only
happen to be simpler in this case because SET handlers are always
terminal. They never cascade to more deletes that can be combined.
Thanks Renan GEHAN for the report.
Refs #33476 -- Refactored code to strictly match 88 characters line length.2022-02-07T19:37:05ZMariusz Felisiakfelisiak.mariusz@gmail.com2022-02-04T07:08:27Zurn:sha1:7119f40c9881666b6f9b5cf7df09ee1d21cc8344Refs #33476 -- Reformatted code with Black.2022-02-07T19:37:05Zdjango-botops@djangoproject.com2022-02-03T19:24:19Zurn:sha1:9c19aff7c7561e3a82978a272ecdaad40dda5c00Refs #32682 -- Fixed QuerySet.delete() crash on querysets with self-referential subqueries on MySQL.2021-04-27T08:34:47ZMariusz Felisiakfelisiak.mariusz@gmail.com2021-04-27T07:53:27Zurn:sha1:4074f38e1dcc93b859bbbfd6abd8441c3bca36b3Fixed #32433 -- Added error message on QuerySet.delete() following distinct().2021-02-11T07:33:30ZEgidijus Macijauskase.macijauskas@outlook.com2021-02-09T21:43:01Zurn:sha1:6307c3f1a123f5975c73b231e8ac4f115fd72c0d