chango.git/tests/builtin_server, branch devmain
django
http://cgit.adnoto.dev/chango.git/atom?h=devmain
2023-01-05T18:26:56Z
Fixed #33865 -- Optimized LimitedStream wrapper.
2023-01-05T18:26:56Z
Nick Pope
nick@nickpope.me.uk
2022-07-22T20:08:10Z
urn:sha1:b47f2f5b907732d80b164f1f361ae39da94a3fa6
The current implementation of LimitedStream is slow because .read()
performs an extra copy into a buffer and .readline() performs two
extra copies. The stream being wrapped is already typically a BytesIO
object so this is unnecessary.
This implementation has largely been untouched for 12 years and,
inspired by a simpler implementation in werkzeug, it was possible to
achieve the following performance improvement:
LimitedStream.read() (single line):
Mean +- std dev: [bench_limitedstream-main] 286 ns +- 6 ns
-> [bench_limitedstream-patch] 227 ns +- 6 ns: 1.26x faster
LimitedStream.readline() (single line):
Mean +- std dev: [bench_limitedstream-main] 507 ns +- 11 ns
-> [bench_limitedstream-patch] 232 ns +- 8 ns: 2.18x faster
LimitedStream.read(8192) (single line):
Mean +- std dev: [bench_limitedstream-main] 360 ns +- 8 ns
-> [bench_limitedstream-patch] 297 ns +- 6 ns: 1.21x faster
LimitedStream.readline(8192) (single line):
Mean +- std dev: [bench_limitedstream-main] 602 ns +- 10 ns
-> [bench_limitedstream-patch] 305 ns +- 10 ns: 1.98x faster
LimitedStream.read() (multiple lines):
Mean +- std dev: [bench_limitedstream-main] 290 ns +- 5 ns
-> [bench_limitedstream-patch] 236 ns +- 6 ns: 1.23x faster
LimitedStream.readline() (multiple lines):
Mean +- std dev: [bench_limitedstream-main] 517 ns +- 19 ns
-> [bench_limitedstream-patch] 239 ns +- 7 ns: 2.16x faster
LimitedStream.read(8192) (multiple lines):
Mean +- std dev: [bench_limitedstream-main] 363 ns +- 8 ns
-> [bench_limitedstream-patch] 311 ns +- 11 ns: 1.17x faster
LimitedStream.readline(8192) (multiple lines):
Mean +- std dev: [bench_limitedstream-main] 601 ns +- 12 ns
-> [bench_limitedstream-patch] 308 ns +- 7 ns: 1.95x faster
Geometric mean: 1.59x faster
Refs #33476 -- Reformatted code with Black.
2022-02-07T19:37:05Z
django-bot
ops@djangoproject.com
2022-02-03T19:24:19Z
urn:sha1:9c19aff7c7561e3a82978a272ecdaad40dda5c00
Refs #29069 -- Added test for calling request_finished signal by static file responses.
2020-04-20T04:17:57Z
Tom Forbes
tom@tomforb.es
2020-04-18T20:59:06Z
urn:sha1:141ab6bc6d93d3a91259896f6ea3b7485172df88
Fixed in 41a3b3d18647b258331104520e76f977406c590d.
Fixed #31240 -- Properly closed FileResponse when wsgi.file_wrapper is used.
2020-02-11T19:39:12Z
Florian Apolloner
florian@apolloner.eu
2020-02-07T11:55:59Z
urn:sha1:41a3b3d18647b258331104520e76f977406c590d
Thanks to Oskar Persson for the report.
Fixed typos in test names and a comment.
2019-08-23T08:46:43Z
Min ho Kim
minho42@gmail.com
2019-08-23T08:46:43Z
urn:sha1:7bd963332017eace00be8caf7dc1b7b304da613a
Refs #23919 -- Replaced super(ClassName, self) with super().
2017-01-25T17:23:46Z
chillaranand
anand21nanda@gmail.com
2017-01-21T13:13:44Z
urn:sha1:d6eaf7c0183cd04b78f2a55e1d60bb7e59598310
Refs #23919 -- Removed unneeded str() calls
2017-01-20T13:13:55Z
Claude Paroz
claude@2xlibre.net
2017-01-20T09:20:53Z
urn:sha1:042b7350a080cc964f913faf1cf7f0097f650a58
Refs #23919 -- Stopped inheriting from object to define new style classes.
2017-01-19T07:39:46Z
Simon Charette
charettes@users.noreply.github.com
2017-01-19T07:39:46Z
urn:sha1:cecc079168e8669138728d31611ff3a1e7eb3a9f
Refs #23919 -- Removed encoding preambles and future imports
2017-01-18T08:55:19Z
Claude Paroz
claude@2xlibre.net
2016-11-19T17:19:41Z
urn:sha1:d7b9aaa366dd54ecc3142c588162e3adc7c2f7ac
Removed a bit of builtin_server tests for Python ≤ 2.7.3.
2016-11-11T03:20:09Z
Tim Graham
timograham@gmail.com
2016-11-11T03:12:08Z
urn:sha1:7b05ffd95d2ab8c6653ce4efc49658efb79965c8